Skip to content

Update base.py revert grpc_port changes #14745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Update base.py revert grpc_port changes #14745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ydb/tools/cfg/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,12 +709,7 @@ def default_log_level(self):

@property
def grpc_config(self):
grpc_config = merge_with_default(GRPC_DEFAULT_CONFIG, self.__cluster_description.get("grpc", {}))
# specifying both `port` and `ssl_port` leads to erroneous behavior in ydbd, half of the incoming
# connections use tls, half do not, so this is prohibited
if grpc_config.get("ssl_port") is not None:
del grpc_config["port"]
return grpc_config
return merge_with_default(GRPC_DEFAULT_CONFIG, self.__cluster_description.get("grpc", {}))

@property
def dynamicnameservice_config(self):
Expand Down
Loading