Fix cdc heartbeats reporting unconfirmed volatile transactions as resolved KIKIMR-20962 #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olved KIKIMR-20962
|
⚪
|
|
⚪
|
CyberROFL
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 7, 2024
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Fix cdc heartbeats reporting unconfirmed volatile transactions as resolved.
Changelog category
Additional information
Volatile transactions persist changes during execution, but those changes are confirmed or aborted later. When confirmed their pending change records are added to the outgoing queue and send to consumers. Unfortunately heartbeats could mark their global timestamp as resolved before they are actually resolved, and later changes would appear out of order, violating the invariant.