Skip to content

Add admin cluster config generate command #14711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 18, 2025
Merged

Add admin cluster config generate command #14711

merged 4 commits into from
Feb 18, 2025

Conversation

mregrock
Copy link
Collaborator

@mregrock mregrock commented Feb 17, 2025 •
edited
Loading

Changelog entry

Add command that generate dynamic config from startup static config

Changelog category

  • New feature

Description for reviewers

...

@mregrock mregrock requested review from a team as code owners February 17, 2025 17:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

🟢 2025-02-18 14:14:14 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

⚪ 2025-02-17 17:48:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for f11923d has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

⚪ 2025-02-17 17:50:35 UTC Pre-commit check linux-x86_64-release-asan for f11923d has started.
⚪ 2025-02-17 17:54:16 UTC Artifacts will be uploaded here
⚪ 2025-02-17 17:57:24 UTC ya make is running...
🔴 2025-02-17 18:00:16 UTC Build failed, see the logs. Also see fail summary

Enjection
Enjection requested changes Feb 17, 2025
View reviewed changes
@mregrock mregrock force-pushed the admin_cluster_config_generate branch from 44ef76c to 3b66a64 Compare February 17, 2025 20:00
@mregrock mregrock requested a review from a team as a code owner February 17, 2025 20:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

⚪ 2025-02-17 20:01:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0678317 has started.
⚪ 2025-02-17 20:01:35 UTC Artifacts will be uploaded here
⚪ 2025-02-17 20:04:58 UTC ya make is running...
🟡 2025-02-17 21:39:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28527 25937 0 1 2456 133

⚪ 2025-02-17 21:41:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-17 22:04:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
202 (only retried tests) 72 0 0 1 129

🟢 2025-02-17 22:04:19 UTC Build successful.
🟡 2025-02-17 22:04:40 UTC ydbd size 2.1 GiB changed* by +625.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f2c5cc1 merge: 0678317 diff diff %
ydbd size 2 236 143 688 Bytes 2 236 784 064 Bytes +625.4 KiB +0.029%
ydbd stripped size 473 901 720 Bytes 474 041 368 Bytes +136.4 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

⚪ 2025-02-17 20:01:54 UTC Pre-commit check linux-x86_64-release-asan for 0678317 has started.
⚪ 2025-02-17 20:02:27 UTC Artifacts will be uploaded here
⚪ 2025-02-17 20:06:21 UTC ya make is running...
🟡 2025-02-17 21:46:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14293 14205 0 42 8 38

⚪ 2025-02-17 21:47:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-17 22:07:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 100 0 6 2 34

⚪ 2025-02-17 22:07:35 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-17 22:19:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 34 0 6 2 33

🟢 2025-02-17 22:19:27 UTC Build successful.
🟡 2025-02-17 22:19:56 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f2c5cc1 merge: 0678317 diff diff %
ydbd size 3 890 194 704 Bytes 3 891 358 048 Bytes +1.1 MiB +0.030%
ydbd stripped size 1 361 991 872 Bytes 1 362 477 536 Bytes +474.3 KiB +0.036%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Gazizonoki
Gazizonoki requested changes Feb 17, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

⚪ 2025-02-17 22:40:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for f7db551 has started.
⚪ 2025-02-17 22:40:19 UTC Artifacts will be uploaded here
⚪ 2025-02-17 22:43:36 UTC ya make is running...
🟡 2025-02-17 23:38:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28527 25930 0 2 2456 139

⚪ 2025-02-17 23:41:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-17 23:59:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 80 0 0 3 128

🟢 2025-02-17 23:59:58 UTC Build successful.
🟡 2025-02-18 00:00:40 UTC ydbd size 2.1 GiB changed* by +625.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c25b7ee merge: f7db551 diff diff %
ydbd size 2 236 143 688 Bytes 2 236 784 064 Bytes +625.4 KiB +0.029%
ydbd stripped size 473 901 720 Bytes 474 041 368 Bytes +136.4 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

⚪ 2025-02-17 22:40:07 UTC Pre-commit check linux-x86_64-release-asan for f7db551 has started.
⚪ 2025-02-17 22:41:31 UTC Artifacts will be uploaded here
⚪ 2025-02-17 22:44:51 UTC ya make is running...
🟡 2025-02-17 23:49:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14293 14173 0 70 15 35

⚪ 2025-02-17 23:50:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-18 00:04:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 125 0 2 8 34

⚪ 2025-02-18 00:04:16 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-18 00:22:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 36 0 2 3 32

🟢 2025-02-18 00:22:49 UTC Build successful.
🟡 2025-02-18 00:23:19 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c25b7ee merge: f7db551 diff diff %
ydbd size 3 890 194 704 Bytes 3 891 358 048 Bytes +1.1 MiB +0.030%
ydbd stripped size 1 361 991 872 Bytes 1 362 477 536 Bytes +474.3 KiB +0.036%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 09:30:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for cea838c has started.
⚪ 2025-02-18 09:30:41 UTC Artifacts will be uploaded here
⚪ 2025-02-18 09:33:48 UTC ya make is running...
🟡 2025-02-18 11:16:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28527 25932 0 3 2456 136

⚪ 2025-02-18 11:19:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-18 11:31:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 81 0 1 3 126

⚪ 2025-02-18 11:31:40 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-18 11:44:04 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 63 0 1 1 126

🟢 2025-02-18 11:44:11 UTC Build successful.
🟡 2025-02-18 11:44:38 UTC ydbd size 2.1 GiB changed* by +625.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0a1a524 merge: cea838c diff diff %
ydbd size 2 236 147 032 Bytes 2 236 787 376 Bytes +625.3 KiB +0.029%
ydbd stripped size 473 902 008 Bytes 474 041 624 Bytes +136.3 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 09:32:38 UTC Pre-commit check linux-x86_64-release-asan for cea838c has started.
⚪ 2025-02-18 09:32:51 UTC Artifacts will be uploaded here
⚪ 2025-02-18 09:36:10 UTC ya make is running...
🟡 2025-02-18 11:12:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14293 14210 0 32 15 36

⚪ 2025-02-18 11:13:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-18 11:39:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 85 0 4 3 33

⚪ 2025-02-18 11:39:35 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-18 11:54:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 31 0 3 2 34

🟢 2025-02-18 11:54:43 UTC Build successful.
🟡 2025-02-18 11:55:21 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0a1a524 merge: cea838c diff diff %
ydbd size 3 890 200 192 Bytes 3 891 367 616 Bytes +1.1 MiB +0.030%
ydbd stripped size 1 361 992 768 Bytes 1 362 482 528 Bytes +478.3 KiB +0.036%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock
Copy link
Collaborator Author

mregrock commented Feb 18, 2025 •
edited
Loading

Failed test already in muted_ya.txt
#14727

Gazizonoki
Gazizonoki approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@Gazizonoki Gazizonoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK LGTM

pnv1
pnv1 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@pnv1 pnv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI part LGTM. Changelog entry should be added for this (can be done in another PR to save approvals)

@Enjection Enjection added the rebase-and-check Rebase PR with the current base branch and check label Feb 18, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 14:24:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for a0e19bd has started.
⚪ 2025-02-18 14:24:29 UTC Artifacts will be uploaded here
⚪ 2025-02-18 14:27:48 UTC ya make is running...
🟢 2025-02-18 16:08:29 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28531 25931 0 0 2460 140

🟢 2025-02-18 16:11:02 UTC Build successful.
🟡 2025-02-18 16:11:21 UTC ydbd size 2.1 GiB changed* by +625.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d1f5b91 merge: a0e19bd diff diff %
ydbd size 2 236 933 728 Bytes 2 237 574 080 Bytes +625.3 KiB +0.029%
ydbd stripped size 474 020 440 Bytes 474 160 088 Bytes +136.4 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 14:26:54 UTC Pre-commit check linux-x86_64-release-asan for a0e19bd has started.
⚪ 2025-02-18 14:28:29 UTC Artifacts will be uploaded here
⚪ 2025-02-18 14:31:37 UTC ya make is running...
🟡 2025-02-18 16:01:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14293 14164 0 82 13 34

⚪ 2025-02-18 16:03:01 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 16:21:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
175 (only retried tests) 139 0 0 4 32

🟢 2025-02-18 16:21:18 UTC Build successful.
🟡 2025-02-18 16:21:48 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d1f5b91 merge: a0e19bd diff diff %
ydbd size 3 891 711 472 Bytes 3 892 874 824 Bytes +1.1 MiB +0.030%
ydbd stripped size 1 362 428 448 Bytes 1 362 914 112 Bytes +474.3 KiB +0.036%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@mregrock mregrock merged commit 74b61d7 into ydb-platform:main Feb 18, 2025
19 of 20 checks passed
@blinkov blinkov mentioned this pull request Feb 19, 2025
Closed
This was referenced Feb 19, 2025
Merged
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@mregrock
Add admin cluster config generate command (ydb-platform#14711)
3e3df41
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@mregrock @blinkov
Add admin cluster config generate command (#14711)
004c705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnv1 pnv1 pnv1 approved these changes

@Enjection Enjection Enjection approved these changes

@Gazizonoki Gazizonoki Gazizonoki approved these changes

@stanislav-shchetinin stanislav-shchetinin Awaiting requested review from stanislav-shchetinin stanislav-shchetinin is a code owner automatically assigned from ydb-platform/core

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mregrock @pnv1 @Enjection @Gazizonoki