Skip to content

store all versions of TTL in memory #14677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2025
Merged

store all versions of TTL in memory #14677

merged 4 commits into from
Feb 19, 2025

Conversation

swalrus1
Copy link
Collaborator

Changelog entry

store all versions of TTL in memory on CS

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@swalrus1 swalrus1 requested a review from a team as a code owner February 17, 2025 14:56
@github-actions GitHub Actions
Copy link

🟢 2025-02-17 14:57:36 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

⚪ 2025-02-17 14:57:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 737e3ba has started.
⚪ 2025-02-17 15:23:24 UTC Artifacts will be uploaded here
⚪ 2025-02-17 15:26:11 UTC ya make is running...
🟢 2025-02-17 16:20:32 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18779 17417 0 0 1224 138

🟢 2025-02-17 16:22:36 UTC Build successful.
🟢 2025-02-17 16:22:53 UTC ydbd size 2.1 GiB changed* by +43.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 609889d merge: 737e3ba diff diff %
ydbd size 2 236 263 928 Bytes 2 236 308 624 Bytes +43.6 KiB +0.002%
ydbd stripped size 473 848 280 Bytes 473 851 096 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

⚪ 2025-02-17 15:00:48 UTC Pre-commit check linux-x86_64-release-asan for 737e3ba has started.
⚪ 2025-02-17 15:02:37 UTC Artifacts will be uploaded here
⚪ 2025-02-17 15:05:37 UTC ya make is running...
🟡 2025-02-17 16:19:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11692 11612 0 27 16 37

⚪ 2025-02-17 16:20:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-17 16:33:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
122 (only retried tests) 81 0 1 2 38

⚪ 2025-02-17 16:33:24 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-17 16:45:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 33 0 0 3 35

🟢 2025-02-17 16:45:57 UTC Build successful.
🟢 2025-02-17 16:46:27 UTC ydbd size 3.6 GiB changed* by +75.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 609889d merge: 737e3ba diff diff %
ydbd size 3 890 045 208 Bytes 3 890 122 112 Bytes +75.1 KiB +0.002%
ydbd stripped size 1 361 717 056 Bytes 1 361 731 776 Bytes +14.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 15:12:39 UTC Pre-commit check linux-x86_64-release-asan for f36f9ab has started.
⚪ 2025-02-18 15:12:52 UTC Artifacts will be uploaded here
⚪ 2025-02-18 15:15:39 UTC ya make is running...
🔴 2025-02-18 15:19:11 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 15:13:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for f36f9ab has started.
⚪ 2025-02-18 15:39:28 UTC Artifacts will be uploaded here
⚪ 2025-02-18 15:42:17 UTC ya make is running...
🔴 2025-02-18 15:45:53 UTC Build failed, see the logs. Also see fail summary

ivanmorozov333
ivanmorozov333 previously approved these changes Feb 18, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 20:28:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for d67e099 has started.
⚪ 2025-02-18 20:28:47 UTC Artifacts will be uploaded here
⚪ 2025-02-18 20:31:34 UTC ya make is running...
🟡 2025-02-18 21:26:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18798 17441 0 3 1220 134

⚪ 2025-02-18 21:28:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-18 21:46:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 80 0 1 1 129

⚪ 2025-02-18 21:46:10 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-18 21:57:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
195 (only retried tests) 69 0 0 0 126

🟢 2025-02-18 21:57:07 UTC Build successful.
🟢 2025-02-18 21:57:30 UTC ydbd size 2.1 GiB changed* by +37.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a48e948 merge: d67e099 diff diff %
ydbd size 2 237 664 768 Bytes 2 237 703 480 Bytes +37.8 KiB +0.002%
ydbd stripped size 474 182 680 Bytes 474 184 856 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

⚪ 2025-02-18 20:28:48 UTC Pre-commit check linux-x86_64-release-asan for d67e099 has started.
⚪ 2025-02-18 20:29:00 UTC Artifacts will be uploaded here
⚪ 2025-02-18 20:31:45 UTC ya make is running...
🟡 2025-02-18 21:48:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11701 11588 0 59 16 38

⚪ 2025-02-18 21:49:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-18 22:02:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
179 (only retried tests) 141 0 0 5 33

🟢 2025-02-18 22:02:11 UTC Build successful.
🟢 2025-02-18 22:02:41 UTC ydbd size 3.6 GiB changed* by +73.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a48e948 merge: d67e099 diff diff %
ydbd size 3 892 971 712 Bytes 3 893 046 968 Bytes +73.5 KiB +0.002%
ydbd stripped size 1 362 937 728 Bytes 1 362 952 320 Bytes +14.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 enabled auto-merge (squash) February 19, 2025 07:13
@swalrus1 swalrus1 merged commit 85359f5 into ydb-platform:main Feb 19, 2025
12 checks passed
This was referenced Feb 19, 2025
Merged
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@swalrus1
store all versions of TTL in memory (ydb-platform#14677)
2146e41
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
@naspirato naspirato mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@swalrus1 @blinkov
store all versions of TTL in memory (#14677)
f2a8e49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swalrus1 @ivanmorozov333