Skip to content

Compatibility for asynchronous compaction #14569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Feb 14, 2025

Changelog entry

Asynchronous compaction will work in version 25-1. During the transition period, versions 24-4 and 25-1 can run simultaneously on the cluster. We need to prepare version 24-4 to work with the new blob keys.

At the start, the actor of the partition checks whether the keys from version 25-1 are still there. If there are any left, it removes the superfluous ones and renames those that the compact did not reach.

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner February 14, 2025 11:36
Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 11:40:24 UTC Pre-commit check for f4f1b5f has started.
2025-02-14 11:43:11 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-14 12:08:33 UTC Build successful.
2025-02-14 12:08:50 UTC Tests are running...
🔴 2025-02-14 12:45:55 UTC Test run completed, no test results found for commit 9fd96b5. Please check test log.
🟡 2025-02-14 12:46:48 UTC ydbd size 5.6 GiB changed* by +293.5 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: df03f29 merge: f4f1b5f diff diff %
ydbd size 6 002 867 240 Bytes 6 003 167 768 Bytes +293.5 KiB +0.005%
ydbd stripped size 1 504 261 472 Bytes 1 504 291 680 Bytes +29.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-14 12:46:49 UTC Check cancelled

Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 11:40:58 UTC Pre-commit check for f4f1b5f has started.
2025-02-14 11:43:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-14 12:23:58 UTC Build successful.
2025-02-14 12:24:17 UTC Tests are running...
🔴 2025-02-14 12:45:54 UTC Test run completed, no test results found for commit 9fd96b5. Please check test log.
🟡 2025-02-14 12:46:37 UTC ydbd size 8.3 GiB changed* by +183.1 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: df03f29 merge: f4f1b5f diff diff %
ydbd size 8 874 304 768 Bytes 8 874 492 312 Bytes +183.1 KiB +0.002%
ydbd stripped size 483 821 544 Bytes 483 831 080 Bytes +9.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-14 12:46:39 UTC Check cancelled

Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 12:51:30 UTC Pre-commit check for a19e58f has started.
2025-02-14 12:54:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-14 13:35:07 UTC Build successful.
2025-02-14 13:35:23 UTC Tests are running...
🔴 2025-02-14 15:04:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14738 13376 0 26 1300 36

🟡 2025-02-14 15:05:32 UTC ydbd size 8.3 GiB changed* by +206.7 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: d20b238 merge: a19e58f diff diff %
ydbd size 8 874 278 992 Bytes 8 874 490 616 Bytes +206.7 KiB +0.002%
ydbd stripped size 483 821 160 Bytes 483 830 888 Bytes +9.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 12:51:47 UTC Pre-commit check for a19e58f has started.
2025-02-14 12:54:36 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-14 13:20:20 UTC Build successful.
2025-02-14 13:20:37 UTC Tests are running...
🔴 2025-02-14 15:36:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10410 10302 0 38 29 41

🟡 2025-02-14 15:37:48 UTC ydbd size 5.6 GiB changed* by +276.1 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: d20b238 merge: a19e58f diff diff %
ydbd size 6 002 880 224 Bytes 6 003 162 968 Bytes +276.1 KiB +0.005%
ydbd stripped size 1 504 267 936 Bytes 1 504 290 912 Bytes +22.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 16:20:10 UTC Pre-commit check for 5b0d3a8 has started.
2025-02-14 16:22:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-14 17:05:19 UTC Build successful.
2025-02-14 17:05:37 UTC Tests are running...
🔴 2025-02-14 18:34:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14764 13401 0 24 1302 37

🔴 2025-02-14 18:35:26 UTC ydbd size 8.3 GiB changed* by +16.7 MiB, which is >= 2.0 MiB vs stable-24-4: Alert

ydbd size dash stable-24-4: d20b238 merge: 5b0d3a8 diff diff %
ydbd size 8 874 278 992 Bytes 8 891 780 888 Bytes +16.7 MiB +0.197%
ydbd stripped size 483 821 160 Bytes 484 828 168 Bytes +983.4 KiB +0.208%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: Compatibility for asynchronous compact Compatibility for asynchronous compaction Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

2025-02-14 16:29:44 UTC Pre-commit check for 5b0d3a8 has started.
2025-02-14 16:32:22 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-14 16:57:19 UTC Build successful.
2025-02-14 16:57:34 UTC Tests are running...
🔴 2025-02-14 19:14:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10437 10325 0 44 27 41

🟡 2025-02-14 19:16:02 UTC ydbd size 5.6 GiB changed* by +272.1 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: c710d8a merge: 5b0d3a8 diff diff %
ydbd size 6 022 716 088 Bytes 6 022 994 736 Bytes +272.1 KiB +0.005%
ydbd stripped size 1 507 675 840 Bytes 1 507 694 720 Bytes +18.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 07:42:19 UTC Pre-commit check for 77b2b8c has started.
2025-02-17 07:44:56 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-17 08:08:36 UTC Build successful.
2025-02-17 08:08:53 UTC Tests are running...
🔴 2025-02-17 10:10:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10434 10337 0 35 23 39

🟡 2025-02-17 10:11:32 UTC ydbd size 5.6 GiB changed* by +270.1 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: c710d8a merge: 77b2b8c diff diff %
ydbd size 6 022 716 088 Bytes 6 022 992 624 Bytes +270.1 KiB +0.005%
ydbd stripped size 1 507 675 840 Bytes 1 507 694 080 Bytes +17.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 17, 2025

2025-02-17 07:48:55 UTC Pre-commit check for 77b2b8c has started.
2025-02-17 07:51:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-17 08:30:34 UTC Build successful.
2025-02-17 08:30:51 UTC Tests are running...
🔴 2025-02-17 10:05:55 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14763 13404 0 23 1300 36

🟡 2025-02-17 10:06:43 UTC ydbd size 8.3 GiB changed* by +202.7 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash stable-24-4: c710d8a merge: 77b2b8c diff diff %
ydbd size 8 891 573 352 Bytes 8 891 780 880 Bytes +202.7 KiB +0.002%
ydbd stripped size 484 822 536 Bytes 484 828 040 Bytes +5.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 89d3412 into ydb-platform:stable-24-4 Feb 18, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants