YQ-4108 Add topic session thread num settings #14532
Conversation
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -36,6 +36,8 @@ struct IPqGateway : public TThrRefBase { | |||
| const TString& endpoint, | |||
| const TString& database, | |||
| bool secure) = 0; | |||
|
|
|||
| virtual NYdb::NTopic::TTopicClientSettings GetTopicClientSettings() = 0; | |||
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -144,6 +147,10 @@ ITopicClient::TPtr TPqNativeGateway::GetTopicClient(const NYdb::TDriver& driver, | |||
| return MakeIntrusive<TNativeTopicClient>(driver, settings); | |||
| } | |||
|
|
|||
| NYdb::NTopic::TTopicClientSettings TPqNativeGateway::GetTopicClientSettings() const { | |||
| return CommonTopicClientSettings.GetOrElse(NYdb::NTopic::TTopicClientSettings()); | |||
There was a problem hiding this comment.
Тут, кмк, всегда вычисляется новый экземпляр TTopicClientSettings()
There was a problem hiding this comment.
Ага, можно наверное пофиксить тернарным оператором CommonTopicClientSettings ? *CommonTopicClientSettings : NYdb::NTopic::TTopicClientSettings()
| @@ -163,6 +163,10 @@ class TMockPqGateway : public IMockPqGateway { | |||
| GetEventQueue(topic)->Push(std::move(e), size); | |||
| } | |||
|
|
|||
| virtual NYdb::NTopic::TTopicClientSettings GetTopicClientSettings() const override { | |||
There was a problem hiding this comment.
Не уверен, что про это говорит style guide, но virtual тут не обязателен (override implies virtual)
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -181,7 +181,7 @@ class TPendingFetcher : public NActors::TActorBootstrapped<TPendingFetcher> { | |||
| , Monitoring(monitoring) | |||
| , ComputeConfig(config.GetCompute()) | |||
| , S3ActorsFactory(std::move(s3ActorsFactory)) | |||
| , DefaultPqGateway(std::move(defaultPqGateway)) | |||
| , PqGatewayFactory(pqGatewayFactory) | |||
There was a problem hiding this comment.
very nit: std::move() (it's more about consistency; unless you need another round -- feel free to ignore)
| @@ -591,7 +591,7 @@ NActors::IActor* CreatePendingFetcher( | |||
| tenantName, | |||
| monitoring, | |||
| std::move(s3ActorsFactory), | |||
| defaultPqGateway); | |||
| pqGatewayFactory); | |||
| @@ -118,7 +118,7 @@ TRunActorParams::TRunActorParams( | |||
| , QueryParameters(std::move(queryParameters)) | |||
| , S3ActorsFactory(std::move(s3ActorsFactory)) | |||
| , WorkloadManager(workloadManager) | |||
| , DefaultPqGateway(defaultPqGateway) | |||
| , PqGatewayFactory(pqGatewayFactory) | |||
ydb/core/fq/libs/init/init.cpp
Outdated
| @@ -67,7 +78,7 @@ void Init( | |||
| const std::function<IActor*(const NKikimrProto::NFolderService::TFolderServiceConfig& authConfig)>& folderServiceFactory, | |||
| ui32 icPort, | |||
| const std::vector<NKikimr::NMiniKQL::TComputationNodeFactory>& additionalCompNodeFactories, | |||
| NYql::IPqGateway::TPtr defaultPqGateway | |||
| NYql::IPqGatewayFactory::TPtr defaultPqGatewayFactory | |||
There was a problem hiding this comment.
Теперь можно наверное просто назвать pqGatewayFactory вместо defaultPqGatewayFactory
ydb/core/fq/libs/init/init.h
Outdated
| @@ -38,7 +38,7 @@ void Init( | |||
| const std::function<IActor*(const NKikimrProto::NFolderService::TFolderServiceConfig& authConfig)>& folderServiceFactory, | |||
| ui32 icPort, | |||
| const std::vector<NKikimr::NMiniKQL::TComputationNodeFactory>& additionalCompNodeFactories, | |||
| NYql::IPqGateway::TPtr defaultPqGateway = nullptr | |||
| NYql::IPqGatewayFactory::TPtr defaultPqGatewayFactory = nullptr | |||
There was a problem hiding this comment.
Тут тоже можно переименовать, наверное defaultPqGatewayFactory -> pqGatewayFactory
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Additional information
...