Skip to content

YQL-17542 pass allocator from ComputeActor to TaskRunnerActor #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

YQL-17542 pass allocator from ComputeActor to TaskRunnerActor #1445

merged 1 commit into from
Jan 31, 2024

Conversation

@zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Jan 31, 2024

@zverevgeny zverevgeny requested review from a team as code owners January 31, 2024 04:59
@github-actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

⚪ 2024-01-31 05:02:32 UTC Pre-commit check for c36e2ae has started.
⚪ 2024-01-31 05:02:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-31 05:04:48 UTC Build successful.
⚪ 2024-01-31 05:05:03 UTC Tests are running...
🟢 2024-01-31 06:27:22 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60312 51012 0 0 9264 36

@github-actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

⚪ 2024-01-31 05:04:23 UTC Pre-commit check for c36e2ae has started.
⚪ 2024-01-31 05:04:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-31 05:06:34 UTC Build successful.
⚪ 2024-01-31 05:06:45 UTC Tests are running...
🔴 2024-01-31 06:45:05 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16023 15927 0 12 54 30

Darych
Darych reviewed Jan 31, 2024
View reviewed changes
ydb/library/yql/providers/dq/actors/worker_actor.cpp
std::make_shared<NKikimr::NMiniKQL::TScopedAlloc>(
__LOCATION__,
NKikimr::TAlignedPagePoolCounters(),
true,
Copy link
Contributor

@Darych Darych Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вкусовщина, но я бы добавил inline комменты с именами параметров для этих булевых значений.

Copy link
Contributor

@Darych Darych Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И еще вопрос, хотя worker_actor планируется вообще выпилить. но FuncRegistry.SupportsSizedAllocators() всегда true выдает?

Copy link
Collaborator Author

@zverevgeny zverevgeny Jan 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не знаю, но не стал тут усложнять. Тесты проходят, а до конца недели я надеюсь выпилить TDqWorkerActor. Уже даже PR есть: https://github.com/ydb-platform/ydb/pulls/zverevgeny

@zverevgeny zverevgeny merged commit 90d1110 into ydb-platform:main Jan 31, 2024
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 3, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 4, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik approved these changes

@rvu1024 rvu1024 rvu1024 approved these changes

+1 more reviewer

@Darych Darych Darych left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zverevgeny @Darych @uzhastik @rvu1024