schemeshard: fix copy-tables memory hog #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export launches copy-tables operation, copy-tables invokes multiple copy table suboperations, each copy-table suboperation grabs and saves aside metadata of table's subdomain (to be able to restore original subdomain state in case IgniteOperation() fails). Straightforward implementation of TMemChanges resulted in that the same and only subdomain being copied multiple times. Which for massive export actions with many-many tables copied is both cpu intensive and, more importantly, requires excessive amount of memory (up to several observed OOM events). This fix changes TMemChanges to store only one subdomain state version per operation. Which is correct and appropriate for copy-tables and all other (sub)operations. KIKIMR-20242
|
⚪
|
|
⚪
|
snaury
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 7, 2024
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Fix excessive memory requirements for backing up databases with massive amount of tables.
Changelog category
Additional information
Simplified tracking of in-memory schema state in schemeshard captured too many copies of database metadata objects during database export/backup.
KIKIMR-20242