Stable-24-4: initial commits #14402

maximyurchuk · 2025-02-10T18:33:03Z

KIKIMR-21727

Co-authored-by: Ilnaz Nizametdinov <ilnaz@ydb.tech>

)

Co-authored-by: Nikolay Shumkov <shumkovnd@ydb.tech> Co-authored-by: Vasily Gerasimov <UgnineSirdis@ydb.tech>

ydb-platform#14076)

This reverts commit f6a4561.

This reverts commit c84474a.

github-actions · 2025-02-10T18:40:13Z

⚪ 2025-02-10 18:40:12 UTC Pre-commit check for c11ccf0 has started.
⚪ 2025-02-10 18:43:12 UTC Build linux-x86_64-release-asan is running...
⚫ 2025-02-10 18:45:20 UTC Check cancelled

github-actions · 2025-02-10T18:40:18Z

⚪ 2025-02-10 18:40:17 UTC Pre-commit check for c11ccf0 has started.
⚪ 2025-02-10 18:43:22 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2025-02-10 18:45:02 UTC Check cancelled

This reverts commit 7b221e9.

…HiveFirst (ydb-platform#14076)" This reverts commit 7a1008a.

github-actions · 2025-02-10T18:48:07Z

⚪ 2025-02-10 18:48:07 UTC Pre-commit check for 25746c5 has started.
⚪ 2025-02-10 18:51:07 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2025-02-10 18:54:04 UTC Check cancelled

github-actions · 2025-02-10T18:50:27Z

⚪ 2025-02-10 18:50:27 UTC Pre-commit check for 25746c5 has started.
⚪ 2025-02-10 18:53:36 UTC Build linux-x86_64-release-asan is running...
⚫ 2025-02-10 18:54:41 UTC Check cancelled

github-actions · 2025-02-10T18:58:36Z

⚪ 2025-02-10 18:58:35 UTC Pre-commit check for b24e0e4 has started.
⚪ 2025-02-10 19:01:36 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-10 19:53:16 UTC Build successful.
⚪ 2025-02-10 19:53:31 UTC Tests are running...
🔴 2025-02-10 22:07:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15787	15645	0	49	51	42

🟡 2025-02-10 22:08:05 UTC ydbd size 5.6 GiB changed* by +117.7 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash	stable-24-4: `a254002`	merge: `b24e0e4`	diff	diff %
ydbd size	6 002 741 216 Bytes	6 002 861 712 Bytes	+117.7 KiB	+0.002%
ydbd stripped size	1 504 236 640 Bytes	1 504 258 592 Bytes	+21.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-02-10T18:58:42Z

⚪ 2025-02-10 18:58:41 UTC Pre-commit check for b24e0e4 has started.
⚪ 2025-02-10 19:01:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-10 20:08:20 UTC Build successful.
⚪ 2025-02-10 20:08:33 UTC Tests are running...
🔴 2025-02-10 22:18:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
76923	63425	0	26	13434	38

🟡 2025-02-10 22:19:36 UTC ydbd size 8.3 GiB changed* by +850.8 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash	stable-24-4: `a254002`	merge: `b24e0e4`	diff	diff %
ydbd size	8 874 098 288 Bytes	8 874 969 480 Bytes	+850.8 KiB	+0.010%
ydbd stripped size	483 816 072 Bytes	484 304 872 Bytes	+477.3 KiB	+0.101%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

pixcc · 2025-02-11T08:10:47Z

ydb/core/protos/feature_flags.proto

    optional bool EnableInsertWriteIdSpecialColumnCompatibility = 147 [default = false];
    optional bool EnableDriveSerialsDiscovery = 152 [default = false];
-    optional bool EnableScaleRecommender = 157 [default = false];
+    optional bool EnableScaleRecommender = 157 [default = true];


Не готов включать по дефолту, но будет хорошо, если поучаствует в тестировании на совместимость

Откачу

(откатил)

…atform#13962)" This reverts commit 3c6a812.

github-actions · 2025-02-11T08:50:56Z

⚪ 2025-02-11 08:50:55 UTC Pre-commit check for 5f17198 has started.
⚪ 2025-02-11 08:54:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-11 10:07:06 UTC Build successful.
⚪ 2025-02-11 10:07:21 UTC Tests are running...
🔴 2025-02-11 12:27:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
76925	63429	0	27	13432	37

🟡 2025-02-11 12:29:12 UTC ydbd size 8.3 GiB changed* by +224.5 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash	stable-24-4: `a254002`	merge: `5f17198`	diff	diff %
ydbd size	8 874 098 288 Bytes	8 874 328 184 Bytes	+224.5 KiB	+0.003%
ydbd stripped size	483 816 072 Bytes	483 822 056 Bytes	+5.8 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-02-11T08:54:11Z

⚪ 2025-02-11 08:54:11 UTC Pre-commit check for 5f17198 has started.
⚪ 2025-02-11 08:57:21 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-11 09:46:45 UTC Build successful.
⚪ 2025-02-11 09:47:02 UTC Tests are running...
🔴 2025-02-11 12:16:53 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15791	15639	0	57	55	40

🟡 2025-02-11 12:17:53 UTC ydbd size 5.6 GiB changed* by +135.2 KiB, which is >= 100.0 KiB vs stable-24-4: Warning

ydbd size dash	stable-24-4: `a254002`	merge: `5f17198`	diff	diff %
ydbd size	6 002 741 216 Bytes	6 002 879 704 Bytes	+135.2 KiB	+0.002%
ydbd stripped size	1 504 236 640 Bytes	1 504 263 776 Bytes	+26.5 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

serbel324

Надо будет отдельным PR оторвать совместимость со старыми NBS

zverevgeny · 2025-02-11T11:24:57Z

ок на включение: EnableImmediateWritingOnBulkUpsert = true

maximyurchuk · 2025-02-11T11:27:24Z

ок на включение: EnableImmediateWritingOnBulkUpsert = true

И еще не-повышение SSA_RUNTIME_VERSION
@zverevgeny

zverevgeny · 2025-02-11T12:01:45Z

ок на включение: EnableImmediateWritingOnBulkUpsert = true

И еще не-повышение SSA_RUNTIME_VERSION @zverevgeny

ок

maximyurchuk and others added 17 commits January 22, 2025 17:35

Bump MKQL_RUNTIME_VERSION and SSA_RUNTIME_VERSION

eab81dc

Fix compatibility info

98041ad

Add prestable into ci checks (ydb-platform#13927)

f6a4561

Temporary remove ReleaseApprovers for prestable

c84474a

Enable topics transactions and autopartitioning (ydb-platform#13922)

46e00b8

Co-authored-by: Ilnaz Nizametdinov <ilnaz@ydb.tech>

[24-4] EnableLocalDBBtreeIndex = true (ydb-platform#13923)

f1c3a77

[24-4] TSharedCacheConfig.ReplacementPolicy = S3FIFO (ydb-platform#13924

b6ac41a

)

prestable-24-4: Enable scale recommender feature flag (ydb-platform#1…

3c6a812

…3962)

VIEW: enable the feature flag by default (ydb-platform#13990)

8b87241

enable per-database hc cache (ydb-platform#14022)

7b221e9

24-4: Set EnableDataShardVolatileTransactions = true by default (ydb-…

17d3c4d

…platform#14077)

Revert "[24-4] EnableLocalDBBtreeIndex = true (ydb-platform#13923)" (y…

0ddde76

…db-platform#14082)

enable stream lookup 24-4 (ydb-platform#14088)

482623c

EnableImmediateWritingOnBulkUpsert by default (ydb-platform#12272) (y…

e60149b

…db-platform#14090)

Update version definition (ydb-platform#14087)

a7d68df

Merge result changes 24 4 (ydb-platform#14102)

752664d

Co-authored-by: Nikolay Shumkov <shumkovnd@ydb.tech> Co-authored-by: Vasily Gerasimov <UgnineSirdis@ydb.tech>

prestable-24-4: enable feature flag EnableAlterDatabaseCreateHiveFirst (

7a1008a

ydb-platform#14076)

maximyurchuk requested a review from a team as a code owner February 10, 2025 18:33

maximyurchuk force-pushed the prestable-24-4 branch from 860d457 to 7a1008a Compare February 10, 2025 18:35

maximyurchuk added 2 commits February 10, 2025 21:35

Revert "Add prestable into ci checks (ydb-platform#13927)"

686068a

This reverts commit f6a4561.

Revert "Temporary remove ReleaseApprovers for prestable"

7ff1dbb

This reverts commit c84474a.

maximyurchuk added 2 commits February 10, 2025 21:43

Revert "enable per-database hc cache (ydb-platform#14022)"

8d77ebe

This reverts commit 7b221e9.

Revert "prestable-24-4: enable feature flag EnableAlterDatabaseCreate…

8fb35d4

…HiveFirst (ydb-platform#14076)" This reverts commit 7a1008a.

SSA_RUNTIME_VERSION -> 4

77103ce

maximyurchuk changed the title ~~Stable-24-4~~ Stable-24-4: initial commits Feb 10, 2025

jepett0 self-requested a review February 11, 2025 07:27

jepett0 previously approved these changes Feb 11, 2025

View reviewed changes

pixcc reviewed Feb 11, 2025

View reviewed changes

Revert "prestable-24-4: Enable scale recommender feature flag (ydb-pl…

fbee8c8

…atform#13962)" This reverts commit 3c6a812.

maximyurchuk dismissed jepett0’s stale review via fbee8c8 February 11, 2025 08:49

pixcc approved these changes Feb 11, 2025

View reviewed changes

nshestakov approved these changes Feb 11, 2025

View reviewed changes

jepett0 self-requested a review February 11, 2025 09:54

jepett0 approved these changes Feb 11, 2025

View reviewed changes

snaury approved these changes Feb 11, 2025

View reviewed changes

azevaykin approved these changes Feb 11, 2025

View reviewed changes

serbel324 approved these changes Feb 11, 2025

View reviewed changes

gridnevvvit self-requested a review February 11, 2025 11:09

gridnevvvit approved these changes Feb 11, 2025

View reviewed changes

maximyurchuk requested a review from zverevgeny February 11, 2025 11:18

zverevgeny approved these changes Feb 11, 2025

View reviewed changes

fomichev3000 approved these changes Feb 11, 2025

View reviewed changes

maximyurchuk merged commit 80dbaee into ydb-platform:stable-24-4 Feb 11, 2025
6 of 10 checks passed

alexv-smirnov mentioned this pull request Mar 25, 2025

Merge stable 24-4 to stream-nb-24-4 #16228

Merged

This was referenced Jun 3, 2025

Enable kafka port for local ydb container #19218

Closed

Enable kafka port for local ydb container #19220

Closed

Stable-24-4: initial commits #14402

Stable-24-4: initial commits #14402

Uh oh!

Conversation

maximyurchuk commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pixcc Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

maximyurchuk Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

maximyurchuk Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serbel324 left a comment

Choose a reason for hiding this comment

Uh oh!

zverevgeny commented Feb 11, 2025

Uh oh!

maximyurchuk commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zverevgeny commented Feb 11, 2025

Uh oh!

Uh oh!

Uh oh!

maximyurchuk commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

maximyurchuk commented Feb 11, 2025 •

edited

Loading