YQL-17567: Fix of INSERT with no columns specified #1438

marsaly79 · 2024-01-30T19:07:40Z

Changelog entry

Changelog category

Bugfix

github-actions · 2024-01-30T19:10:48Z

⚪ 2024-01-30 19:10:47 UTC Pre-commit check for 0ffd21f has started.
⚪ 2024-01-30 19:10:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 19:16:06 UTC Build successful.
⚪ 2024-01-30 19:16:23 UTC Tests are running...
🔴 2024-01-30 20:56:42 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16035	15910	0	35	58	32

github-actions · 2024-01-30T19:15:26Z

⚪ 2024-01-30 19:15:26 UTC Pre-commit check for 0ffd21f has started.
⚪ 2024-01-30 19:15:29 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 19:19:57 UTC Build successful.
⚪ 2024-01-30 19:20:10 UTC Tests are running...
🔴 2024-01-30 21:00:07 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60316	47325	0	2619	9247	1125

github-actions · 2024-01-31T11:59:24Z

⚪ 2024-01-31 11:59:24 UTC Pre-commit check for b66c18e has started.
⚪ 2024-01-31 11:59:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-31 12:04:19 UTC Build successful.
⚪ 2024-01-31 12:04:35 UTC Tests are running...
🔴 2024-01-31 12:27:35 UTC Test run completed, no test results found for commit 595b4a6. Please check build logs.
⚫ 2024-01-31 12:27:39 UTC Check cancelled

github-actions · 2024-01-31T11:59:44Z

⚪ 2024-01-31 11:59:44 UTC Pre-commit check for b66c18e has started.
⚪ 2024-01-31 11:59:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-31 12:04:36 UTC Build successful.
⚪ 2024-01-31 12:04:46 UTC Tests are running...
🔴 2024-01-31 12:27:35 UTC Test run completed, no test results found for commit 595b4a6. Please check build logs.
⚫ 2024-01-31 12:27:38 UTC Check cancelled

github-actions · 2024-01-31T12:29:04Z

⚪ 2024-01-31 12:29:04 UTC Pre-commit check for 69dfdd6 has started.
⚪ 2024-01-31 12:29:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-31 12:30:10 UTC Build successful.
⚪ 2024-01-31 12:30:21 UTC Tests are running...
🔴 2024-01-31 14:06:42 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60344	51002	0	15	9268	59

github-actions · 2024-01-31T12:31:24Z

⚪ 2024-01-31 12:31:24 UTC Pre-commit check for 69dfdd6 has started.
⚪ 2024-01-31 12:31:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-31 12:32:25 UTC Build successful.
⚪ 2024-01-31 12:32:36 UTC Tests are running...
🔴 2024-01-31 14:06:46 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16025	15931	0	8	51	35

github-actions · 2024-01-31T21:08:31Z

⚪ 2024-01-31 21:08:30 UTC Pre-commit check for 1765110 has started.
⚪ 2024-01-31 21:08:32 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-31 21:13:47 UTC Build successful.
⚪ 2024-01-31 21:13:58 UTC Tests are running...
🔴 2024-01-31 22:51:48 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16033	15917	0	22	62	32

github-actions · 2024-01-31T21:10:50Z

⚪ 2024-01-31 21:10:50 UTC Pre-commit check for 1765110 has started.
⚪ 2024-01-31 21:10:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-31 21:15:31 UTC Build successful.
⚪ 2024-01-31 21:15:44 UTC Tests are running...
🔴 2024-01-31 22:53:48 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60356	51057	0	1	9270	28

github-actions · 2024-02-12T20:10:35Z

⚪ 2024-02-12 20:10:35 UTC Pre-commit check for 63494d4 has started.
⚪ 2024-02-12 20:10:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-12 20:16:23 UTC Build successful.
⚪ 2024-02-12 20:16:33 UTC Tests are running...
🔴 2024-02-12 21:57:19 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14753	14524	0	60	133	36

github-actions · 2024-02-12T20:10:53Z

⚪ 2024-02-12 20:10:52 UTC Pre-commit check for 63494d4 has started.
⚪ 2024-02-12 20:10:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-12 20:16:08 UTC Build successful.
⚪ 2024-02-12 20:16:21 UTC Tests are running...
🔴 2024-02-12 22:04:28 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67445	56413	0	46	10956	30

github-actions · 2024-02-18T11:18:42Z

⚪ 2024-02-18 11:18:42 UTC Pre-commit check for c68a77d has started.
⚪ 2024-02-18 11:18:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-18 11:30:26 UTC Build successful.
⚪ 2024-02-18 11:30:44 UTC Tests are running...
🔴 2024-02-18 12:36:48 UTC Test run completed, no test results found for commit 27e1e38. Please check build logs.
⚫ 2024-02-18 12:36:52 UTC Check cancelled

github-actions · 2024-02-18T11:19:25Z

⚪ 2024-02-18 11:19:25 UTC Pre-commit check for c68a77d has started.
⚪ 2024-02-18 11:19:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-18 11:28:40 UTC Build successful.
⚪ 2024-02-18 11:28:56 UTC Tests are running...
🔴 2024-02-18 12:36:48 UTC Test run completed, no test results found for commit 27e1e38. Please check build logs.
⚫ 2024-02-18 12:36:51 UTC Check cancelled

… updated tests

github-actions · 2024-02-18T12:38:03Z

⚪ 2024-02-18 12:38:02 UTC Pre-commit check for b7144e6 has started.
⚪ 2024-02-18 12:38:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-18 12:40:47 UTC Build successful.
⚪ 2024-02-18 12:41:00 UTC Tests are running...
🔴 2024-02-18 13:25:13 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67566	56551	0	3	10979	33

github-actions · 2024-02-18T12:40:25Z

⚪ 2024-02-18 12:40:25 UTC Pre-commit check for b7144e6 has started.
⚪ 2024-02-18 12:40:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-18 12:41:57 UTC Build successful.
⚪ 2024-02-18 12:42:11 UTC Tests are running...
🔴 2024-02-18 13:26:53 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14780	14584	0	19	136	41

github-actions · 2024-02-18T16:23:21Z

⚪ 2024-02-18 16:23:20 UTC Pre-commit check for 42e251f has started.
⚪ 2024-02-18 16:23:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-18 16:26:37 UTC Build successful.
⚪ 2024-02-18 16:26:50 UTC Tests are running...
🔴 2024-02-18 18:20:02 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67567	56546	0	9	10979	33

github-actions · 2024-02-18T16:23:25Z

⚪ 2024-02-18 16:23:25 UTC Pre-commit check for 42e251f has started.
⚪ 2024-02-18 16:23:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-18 16:26:13 UTC Build successful.
⚪ 2024-02-18 16:26:30 UTC Tests are running...
🔴 2024-02-18 18:12:48 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14775	14585	0	12	139	39

ydb/library/yql/providers/yt/provider/yql_yt_datasink_type_ann.cpp

ydb/library/yql/providers/yt/provider/yql_yt_physical_optimize.cpp

ydb/library/yql/tools/pgrun/pgrun.cpp

marsaly79 requested a review from vitstn January 30, 2024 19:07

marsaly79 requested a review from a team as a code owner January 30, 2024 19:07

github-actions bot added the bugfix label Jan 30, 2024

marsaly79 marked this pull request as draft January 30, 2024 19:34

marsaly79 force-pushed the pg-insert-without-columns branch from 595b4a6 to 8a1225f Compare January 31, 2024 12:27

marsaly79 force-pushed the pg-insert-without-columns branch from 0544f8f to 27940c3 Compare February 12, 2024 20:10

marsaly79 force-pushed the pg-insert-without-columns branch from 27940c3 to 27e1e38 Compare February 18, 2024 11:16

marsaly79 added 11 commits February 18, 2024 14:23

Fix of INSERT with no columns specified + removed redundant patches +…

d9ec939

… updated tests

Use table columns only in case of PG's INSERT with no columns specified

1f67e1c

Codestyle

762101a

Updated status of PG tests

7ee155d

Use target table columns for INSERT into existing table only

e3c9898

Added new tickets for tests

f0e5496

Added some more new tickets for tests

87f432d

Write YT schema into .attr files + debug options in pgrun

d4c0b32

Fixed patch logging in pg-make-test

917642d

Fixed CreateTable bug

b077e7e

Patches for removal of max_stack_depth tests

8d6880f

marsaly79 added 6 commits February 18, 2024 14:23

Fix loss of column's order in YT provider

f274ecd

Fix of various Key parsing problems

bb3bc42

Sorting of pg_tests.csv + logging improvements

69c03e4

Updated status of PG regression tests

e533951

Registered new tickets for the PG regression testsuites

d637a46

Deps cleanup

f53c7e0

marsaly79 force-pushed the pg-insert-without-columns branch from 27e1e38 to f53c7e0 Compare February 18, 2024 12:36

Fixed codestyle

d679ddd

marsaly79 marked this pull request as ready for review February 19, 2024 08:27

marsaly79 linked an issue Feb 19, 2024 that may be closed by this pull request

[PG][YT] INSERT INTO VALUES doesn't work without columns list #1834

Closed

marsaly79 commented Feb 19, 2024

View reviewed changes

ydb/library/yql/providers/yt/provider/yql_yt_datasink_type_ann.cpp Show resolved Hide resolved

marsaly79 commented Feb 19, 2024

View reviewed changes

ydb/library/yql/providers/yt/provider/yql_yt_physical_optimize.cpp Show resolved Hide resolved

marsaly79 commented Feb 19, 2024

View reviewed changes

ydb/library/yql/tools/pgrun/pgrun.cpp Show resolved Hide resolved

vitstn approved these changes Feb 19, 2024

View reviewed changes

marsaly79 merged commit b50baf6 into ydb-platform:main Feb 19, 2024

marsaly79 deleted the pg-insert-without-columns branch February 19, 2024 11:59

This was referenced Feb 20, 2024

YQ-2883 fix retries for recover point COMPLETING #2107

Merged

YQ-2873 fix hanging in kqp compute actor #2131

Merged

YQ-2786 partly unmute tests fq s3 #2143

Merged

YQ-2898 fix query failed with unknown uncommitted upload issue #2240

Merged

YQL-17567: Fix of INSERT with no columns specified #1438

YQL-17567: Fix of INSERT with no columns specified #1438

Uh oh!

Conversation

marsaly79 commented Jan 30, 2024

Changelog entry

Changelog category

Uh oh!

github-actions bot commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 30, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading

github-actions bot commented Feb 18, 2024 •

edited

Loading