Skip to content

Blocks for first stages #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 30, 2024
Merged

Blocks for first stages #1404

merged 8 commits into from
Jan 30, 2024

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Jan 30, 2024

Changelog entry

enable block computation for first stages

Changelog category

  • Improvement

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 07:55:29 UTC Pre-commit check for 1d96bf9 has started.
⚪ 2024-01-30 07:55:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 07:58:07 UTC Build successful.
⚪ 2024-01-30 07:58:22 UTC Tests are running...
🔴 2024-01-30 09:09:01 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60250 50954 0 16 9253 27

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 07:55:35 UTC Pre-commit check for 1d96bf9 has started.
⚪ 2024-01-30 07:55:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 07:58:31 UTC Build successful.
⚪ 2024-01-30 07:58:46 UTC Tests are running...
🔴 2024-01-30 09:31:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16002 15919 0 13 44 26

nepal
nepal reviewed Jan 30, 2024
View reviewed changes
ydb/core/kqp/host/kqp_runner.cpp
@@ -192,14 +194,19 @@ class TKqpRunner : public IKqpRunner {
YQL_ENSURE(IsIn({EKikimrQueryType::Query, EKikimrQueryType::Script}, TransformCtx->QueryCtx->Type));
YQL_ENSURE(TMaybeNode<TKiDataQueryBlocks>(query));

TypesCtx.BlockEngineMode = NYql::EBlockEngineMode::Auto;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to explicitly disable dq.UseWideChannels and dq.UseWideBlockChannels, since BlockEngineMode=auto will enable WideChannels and WideBlocksChannels unless they are disabled explicitly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already set scalar channels only mode here

ydb/ydb/core/kqp/opt/kqp_opt_build_txs.cpp

Line 26 in 9710337

EChannelMode mode = EChannelMode::CHANNEL_SCALAR;

(similar to

ydb/ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp

Line 287 in 9710337

NDq::EChannelMode mode = GetConfiguredChannelMode(State_, typesCtx);
)

@nikvas0 nikvas0 force-pushed the blocks-for-first-stages branch from c84e62b to f1dd049 Compare January 30, 2024 10:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 10:37:46 UTC Pre-commit check for 5e21381 has started.
⚪ 2024-01-30 10:37:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 10:40:55 UTC Build successful.
⚪ 2024-01-30 10:41:07 UTC Tests are running...
🔴 2024-01-30 12:00:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60166 50884 0 1 9256 25

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 10:38:39 UTC Pre-commit check for 5e21381 has started.
⚪ 2024-01-30 10:38:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 10:41:31 UTC Build successful.
⚪ 2024-01-30 10:41:44 UTC Tests are running...
🔴 2024-01-30 12:14:31 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15998 15890 0 26 46 36

@nikvas0 nikvas0 merged commit 7c628c7 into ydb-platform:main Jan 30, 2024
This was referenced Jan 30, 2024
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nepal nepal nepal approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikvas0 @nepal