Skip to content

24-3: Preliminary fix for erase cache consistency problems #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 29, 2025

Changelog entry

Fixed consistency issues related to caching deleted ranges.

Changelog category

  • Bugfix

Additional information

Several issues have been identified using a new jepsen workload that produces and tests deleted rows. The root cause is due to datashard transaction map remapping already committed or rolled back transactions to different committed versions, which doesn't affect correctness when replying to requests (datashards use transaction observers to filter inconsistent results), but confuses LocalDB when it uses these remapped versions for caching.

This temporary fix avoids caching over uncompacted deltas so it's easier to backport.

Fixes KIKIMR-22506.

@snaury snaury self-assigned this Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 07:47:38 UTC Pre-commit check for 730b0b7 has started.
2025-01-29 07:50:27 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-29 08:35:52 UTC Build successful.
2025-01-29 08:36:08 UTC Tests are running...
🔴 2025-01-29 10:48:51 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11724 11618 0 32 30 44

🟢 2025-01-29 10:49:40 UTC ydbd size 5.6 GiB changed* by -30.8 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: cbc5af1 merge: 730b0b7 diff diff %
ydbd size 6 002 370 968 Bytes 6 002 339 432 Bytes -30.8 KiB -0.001%
ydbd stripped size 1 504 183 200 Bytes 1 504 183 136 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 29, 2025

2025-01-29 07:49:28 UTC Pre-commit check for 730b0b7 has started.
2025-01-29 07:52:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-29 08:56:12 UTC Build successful.
2025-01-29 08:56:26 UTC Tests are running...
🔴 2025-01-29 10:53:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40296 35020 0 19 5218 39

🟢 2025-01-29 10:54:22 UTC ydbd size 8.3 GiB changed* by -119.5 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: cbc5af1 merge: 730b0b7 diff diff %
ydbd size 8 874 106 640 Bytes 8 873 984 272 Bytes -119.5 KiB -0.001%
ydbd stripped size 484 288 904 Bytes 484 284 808 Bytes -4.0 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review January 29, 2025 08:24
@snaury snaury requested a review from a team as a code owner January 29, 2025 08:24
@snaury snaury merged commit a1e2575 into ydb-platform:stable-24-3 Jan 29, 2025
6 of 10 checks passed
@snaury snaury deleted the bugfix-KIKIMR-22506-volatile-erase-cache-24-3 branch January 29, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants