Skip to content

TotalCpuLimitPercentPerNode has been added to FQ WM (#13768) #13782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

TotalCpuLimitPercentPerNode has been added to FQ WM (#13768) #13782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ydb/core/fq/libs/compute/ydb/synchronization_service/synchronization_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,13 +627,15 @@ class TSynchronizeScopeActor : public NActors::TActorBootstrapped<TSynchronizeSc
CREATE RESOURCE POOL `{resource_pool_name}` WITH (
CONCURRENT_QUERY_LIMIT="{concurrent_query_limit}",
QUEUE_SIZE="{queue_size}",
DATABASE_LOAD_CPU_THRESHOLD="{database_load_cpu_threshold}"
DATABASE_LOAD_CPU_THRESHOLD="{database_load_cpu_threshold}",
TOTAL_CPU_LIMIT_PERCENT_PER_NODE="{total_cpu_limit_percent_per_node}"
);
)",
"resource_pool_name"_a = resourcePool.GetName(),
"concurrent_query_limit"_a = resourcePool.GetConcurrentQueryLimit(),
"queue_size"_a = resourcePool.GetQueueSize(),
"database_load_cpu_threshold"_a = resourcePool.GetDatabaseLoadCpuThreshold()));
"database_load_cpu_threshold"_a = resourcePool.GetDatabaseLoadCpuThreshold(),
"total_cpu_limit_percent_per_node"_a = resourcePool.GetTotalCpuLimitPercentPerNode()));
})
.Subscribe([actorSystem = TActivationContext::ActorSystem(), self = SelfId(), i](const NYdb::TAsyncStatus& future) {
actorSystem->Send(self, new TEvYdbCompute::TEvCreateResourcePoolResponse(ExtractStatus(future)), 0, i);
Expand Down Expand Up @@ -663,13 +665,16 @@ class TSynchronizeScopeActor : public NActors::TActorBootstrapped<TSynchronizeSc
ALTER RESOURCE POOL `{resource_pool_name}` SET (
CONCURRENT_QUERY_LIMIT="{concurrent_query_limit}",
QUEUE_SIZE="{queue_size}",
DATABASE_LOAD_CPU_THRESHOLD="{database_load_cpu_threshold}"
DATABASE_LOAD_CPU_THRESHOLD="{database_load_cpu_threshold}",
TOTAL_CPU_LIMIT_PERCENT_PER_NODE="{total_cpu_limit_percent_per_node}"
);
)",
"resource_pool_name"_a = resourcePool.GetName(),
"concurrent_query_limit"_a = resourcePool.GetConcurrentQueryLimit(),
"queue_size"_a = resourcePool.GetQueueSize(),
"database_load_cpu_threshold"_a = resourcePool.GetDatabaseLoadCpuThreshold()));
"database_load_cpu_threshold"_a = resourcePool.GetDatabaseLoadCpuThreshold(),
"total_cpu_limit_percent_per_node"_a = resourcePool.GetTotalCpuLimitPercentPerNode()
));
})
.Subscribe([actorSystem = TActivationContext::ActorSystem(), self = SelfId(), index](const NYdb::TAsyncStatus& future) {
actorSystem->Send(self, new TEvYdbCompute::TEvCreateResourcePoolResponse(ExtractStatus(future)), 0, index);
Expand Down
1 change: 1 addition & 0 deletions ydb/core/fq/libs/config/protos/compute.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ message TWorkloadManagerConfig {
int32 ConcurrentQueryLimit = 2;
int32 QueueSize = 3;
double DatabaseLoadCpuThreshold = 4;
double TotalCpuLimitPercentPerNode = 5;
}

bool Enable = 1;
Expand Down
Loading