Skip to content

[dq] Don't return future with exception from ExecPlan call (YQL-17677) #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

[dq] Don't return future with exception from ExecPlan call (YQL-17677) #1374

merged 1 commit into from
Jan 29, 2024

Conversation

@rvu1024
Copy link
Member

@rvu1024 rvu1024 commented Jan 29, 2024

Changelog entry

  • Fix query assert/crash when DQ session is unexpectedly closed

Changelog category

  • Bugfix

@rvu1024 rvu1024 requested a review from a team as a code owner January 29, 2024 11:44
@github-actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 11:47:30 UTC Pre-commit check for 9f1b6ee has started.
⚪ 2024-01-29 11:47:34 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-29 11:49:07 UTC Build successful.
⚪ 2024-01-29 11:49:19 UTC Tests are running...
🔴 2024-01-29 13:22:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15882 15770 0 30 60 22

@github-actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 11:47:32 UTC Pre-commit check for 9f1b6ee has started.
⚪ 2024-01-29 11:47:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-29 11:49:08 UTC Build successful.
⚪ 2024-01-29 11:49:20 UTC Tests are running...
🔴 2024-01-29 13:29:54 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60133 50845 0 11 9257 20

@rvu1024 rvu1024 requested a review from resetius January 29, 2024 11:51
resetius
resetius approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@resetius resetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@rvu1024 rvu1024 merged commit b16f3db into ydb-platform:main Jan 29, 2024
This was referenced Jan 29, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
@rvu1024 rvu1024 deleted the YQL-17677-dq-fail branch January 30, 2024 14:46
This was referenced Jan 30, 2024
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@resetius resetius resetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rvu1024 @resetius