Skip to content

YQL-17542 Introduce TDqSyncComputeActorBase #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024
Merged

YQL-17542 Introduce TDqSyncComputeActorBase #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ydb/core/kqp/compute_actor/kqp_pure_compute_actor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
#include <ydb/core/sys_view/scan.h>
#include <ydb/library/yverify_stream/yverify_stream.h>

#include <ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h>
#include <ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h>


namespace NKikimr {
namespace NKqp {

class TKqpComputeActor : public TDqComputeActorBase<TKqpComputeActor> {
using TBase = TDqComputeActorBase<TKqpComputeActor>;
class TKqpComputeActor : public TDqSyncComputeActorBase<TKqpComputeActor> {
using TBase = TDqSyncComputeActorBase<TKqpComputeActor>;

public:
static constexpr NKikimrServices::TActivity::EType ActorActivityType() {
Expand Down
6 changes: 3 additions & 3 deletions ydb/core/kqp/compute_actor/kqp_scan_compute_actor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
#include "kqp_scan_events.h"

#include <ydb/core/kqp/runtime/kqp_scan_data.h>
#include <ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h>
#include <ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h>
#include <ydb/library/yql/dq/actors/compute/dq_compute_actor_async_io.h>
#include <ydb/library/yql/dq/actors/compute/dq_compute_actor.h>

namespace NKikimr::NKqp::NScanPrivate {

class TKqpScanComputeActor: public NYql::NDq::TDqComputeActorBase<TKqpScanComputeActor> {
class TKqpScanComputeActor: public NYql::NDq::TDqSyncComputeActorBase<TKqpScanComputeActor> {
private:
using TBase = NYql::NDq::TDqComputeActorBase<TKqpScanComputeActor>;
using TBase = NYql::NDq::TDqSyncComputeActorBase<TKqpScanComputeActor>;
NMiniKQL::TKqpScanComputeContext ComputeCtx;
NKikimrTxDataShard::TKqpTransaction::TScanTaskMeta Meta;
using TBase::TaskRunner;
Expand Down
6 changes: 3 additions & 3 deletions ydb/library/yql/dq/actors/compute/dq_compute_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "dq_compute_actor_impl.h"
#include "dq_sync_compute_actor_base.h"
#include "dq_compute_actor.h"
#include "dq_task_runner_exec_ctx.h"

Expand Down Expand Up @@ -27,8 +27,8 @@ TDqExecutionSettings& GetDqExecutionSettingsForTests() {
return ExecutionSettings;
}

class TDqComputeActor : public TDqComputeActorBase<TDqComputeActor> {
using TBase = TDqComputeActorBase<TDqComputeActor>;
class TDqComputeActor : public TDqSyncComputeActorBase<TDqComputeActor> {
using TBase = TDqSyncComputeActorBase<TDqComputeActor>;

public:
static constexpr char ActorName[] = "DQ_COMPUTE_ACTOR";
Expand Down
1 change: 0 additions & 1 deletion ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
RlNoResourceTag = 102,
};

static constexpr bool HasAsyncTaskRunner = false;

public:
void Bootstrap() {
Expand Down
13 changes: 13 additions & 0 deletions ydb/library/yql/dq/actors/compute/dq_sync_compute_actor_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#include "./dq_compute_actor_impl.h"

namespace NYql::NDq {

template<typename TDerived>
class TDqSyncComputeActorBase: public TDqComputeActorBase<TDerived> {
public:
using TDqComputeActorBase<TDerived>::TDqComputeActorBase;
static constexpr bool HasAsyncTaskRunner = false;
};

} //namespace NYql::NDq