Skip to content

Fix PDisk log flush completion action use after free #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2024
Merged

Fix PDisk log flush completion action use after free #1359

merged 2 commits into from
Jan 29, 2024

Conversation

@SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented Jan 26, 2024 •
edited
Loading

Changelog entry

Fixes use after free in pdisk log flush wrapper

Changelog category

  • Bugfix

Additional information

Should fix:

Test crashed (return code: -6)
See logs for more info
Problem thread backtrace:
Thread 1 (LWP 156277):
#0  0x00007fb31dedf00b in raise () from /lib/x86_64-linux-gnu/libc.so.6
No symbol table info available.
#1  0x00007fb31debe859 in abort () from /lib/x86_64-linux-gnu/libc.so.6
No symbol table info available.
#2  0x0000000001e027c6 in __cxa_pure_virtual () at /-S/contrib/libs/cxxsupp/libcxxrt/auxhelper.cc:80
No locals.
#3  0x00000000031cdbde in NKikimr::NPDisk::TLogFlushCompletionAction::Release(NActors::TActorSystem*) () at /-S/contrib/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_log.cpp:36
No locals.

@github-actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

⚪ 2024-01-26 21:14:35 UTC Pre-commit check for da07029 has started.
⚪ 2024-01-26 21:14:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-26 21:16:40 UTC Build successful.
⚪ 2024-01-26 21:16:55 UTC Tests are running...
🔴 2024-01-26 22:29:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60210 50920 0 3 9251 36

@github-actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

⚪ 2024-01-26 21:14:41 UTC Pre-commit check for da07029 has started.
⚪ 2024-01-26 21:14:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-26 21:16:53 UTC Build successful.
⚪ 2024-01-26 21:17:05 UTC Tests are running...
🔴 2024-01-26 22:54:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15985 15870 0 28 63 24

@github-actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 10:56:32 UTC Pre-commit check for 307a247 has started.
⚪ 2024-01-29 10:56:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-29 10:58:33 UTC Build successful.
⚪ 2024-01-29 10:58:48 UTC Tests are running...
🔴 2024-01-29 12:35:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60134 50837 0 14 9260 23

@github-actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 10:56:50 UTC Pre-commit check for 307a247 has started.
⚪ 2024-01-29 10:56:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-29 10:59:01 UTC Build successful.
⚪ 2024-01-29 10:59:14 UTC Tests are running...
🔴 2024-01-29 12:30:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15887 15786 0 23 48 30

@SammyVimes SammyVimes merged commit a24a53f into ydb-platform:main Jan 29, 2024
This was referenced Jan 29, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexvru alexvru alexvru approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SammyVimes @alexvru