YQL-17371: fix ASCII-compatibe bytea output in pgrun #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
vitstn
approved these changes
Jan 26, 2024
MrLolthe1st
reviewed
Jan 26, 2024
| [] (ui64 acc, char c) { | ||
| return acc + ((c == '\\') | ||
| ? 2 | ||
| : ((ui8)c < 0x20 || 0x7e < (ui8)c) |
There was a problem hiding this comment.
давай тут magic уберем и вынесем куда-нибудь (можно в макрос/constexpr функцию)
There was a problem hiding this comment.
Это взято из кода PG. Можно поправить, но, в целом, стандартная штука же
| if (c == '\\') { | ||
| *p++ = '\\'; | ||
| *p++ = '\\'; | ||
| } else if ((ui8)c < 0x20 || 0x7e < (ui8)c) { |
This was referenced Jan 29, 2024
Merged
Merged
Merged
This was referenced Jan 30, 2024
Merged
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.