Skip to content

24-3: Fix uncommitted changes leak and clean them up on startup #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 16, 2025

Changelog entry

Fix uncommitted changes leak and clean them up on startup.

Changelog category

  • Bugfix

Additional information

It was discovered that uncommitted changes are slowly leaking in some workloads, which turned out to be due to writes combined with a broken read-only lock. This patch fixes the issue and adds automatic cleanup on shard startup.

Fixes #13387.

Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 14:14:34 UTC Pre-commit check for b640acf has started.
2025-01-16 14:17:11 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-16 14:43:03 UTC Build successful.
2025-01-16 14:43:20 UTC Tests are running...
🔴 2025-01-16 16:48:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10400 10311 0 23 26 40

🟡 2025-01-16 16:48:53 UTC ydbd size 5.6 GiB changed* by +205.6 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 6b41c90 merge: b640acf diff diff %
ydbd size 6 002 342 032 Bytes 6 002 552 600 Bytes +205.6 KiB +0.004%
ydbd stripped size 1 504 186 816 Bytes 1 504 212 896 Bytes +25.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 14:14:37 UTC Pre-commit check for b640acf has started.
2025-01-16 14:17:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-16 15:00:31 UTC Build successful.
2025-01-16 15:00:50 UTC Tests are running...
🔴 2025-01-16 16:29:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14732 13364 0 21 1306 41

🟡 2025-01-16 16:30:46 UTC ydbd size 8.3 GiB changed* by +181.8 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 2962665 merge: b640acf diff diff %
ydbd size 8 874 034 952 Bytes 8 874 221 104 Bytes +181.8 KiB +0.002%
ydbd stripped size 484 395 624 Bytes 484 292 680 Bytes -100.5 KiB -0.021%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury self-assigned this Jan 16, 2025
@snaury snaury marked this pull request as ready for review January 17, 2025 13:59
@snaury snaury requested a review from a team as a code owner January 17, 2025 13:59
@snaury snaury merged commit 2257ad4 into ydb-platform:stable-24-3 Jan 17, 2025
6 of 10 checks passed
@snaury snaury deleted the bugfix-13387-uncommitted-tx-leak-24-3 branch January 17, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants