Skip to content

Conversation

@alexv-smirnov
Copy link
Member

@alexv-smirnov alexv-smirnov commented Jan 15, 2025

Changelog entry

Fix possible node crash in HTML rendering code

Changelog category

  • Bugfix

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 17:05:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for ef556d0 has started.
2025-01-15 17:05:40 UTC Artifacts will be uploaded here
2025-01-15 17:08:42 UTC ya make is running...
2025-01-15 17:14:46 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 17:06:42 UTC Pre-commit check linux-x86_64-release-asan for ef556d0 has started.
2025-01-15 17:06:53 UTC Artifacts will be uploaded here
2025-01-15 17:09:53 UTC ya make is running...
2025-01-15 17:14:31 UTC Check cancelled

@alexv-smirnov alexv-smirnov changed the title Remove unnesessary verify in html building code Remove possible node crash from HTML rendering code Jan 15, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Jan 15, 2025
@alexv-smirnov alexv-smirnov changed the title Remove possible node crash from HTML rendering code Fix possible node crash from HTML rendering code Jan 15, 2025
@alexv-smirnov alexv-smirnov changed the title Fix possible node crash from HTML rendering code Fix possible node crash in HTML rendering code Jan 15, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Jan 15, 2025
va-kuznecov
va-kuznecov previously approved these changes Jan 15, 2025
@github-actions
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 17:15:29 UTC Pre-commit check linux-x86_64-release-asan for 12839d3 has started.
2025-01-15 17:15:59 UTC Artifacts will be uploaded here
2025-01-15 17:18:54 UTC ya make is running...
🟡 2025-01-15 18:10:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11874 11819 0 14 16 25

2025-01-15 18:11:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 18:23:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 66 0 0 5 23

🟢 2025-01-15 18:23:58 UTC Build successful.
🟢 2025-01-15 18:24:23 UTC ydbd size 3.6 GiB changed* by -7.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 852697f merge: 12839d3 diff diff %
ydbd size 3 903 013 480 Bytes 3 903 005 480 Bytes -7.8 KiB -0.000%
ydbd stripped size 1 362 770 448 Bytes 1 362 767 312 Bytes -3.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 17:18:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 12839d3 has started.
2025-01-15 17:18:52 UTC Artifacts will be uploaded here
2025-01-15 17:21:56 UTC ya make is running...
🟡 2025-01-15 18:09:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19020 17724 0 3 1169 124

2025-01-15 18:10:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 18:22:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 66 0 0 0 120

🟢 2025-01-15 18:22:30 UTC Build successful.
🟢 2025-01-15 18:22:49 UTC ydbd size 2.1 GiB changed* by -688 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 852697f merge: 12839d3 diff diff %
ydbd size 2 252 423 944 Bytes 2 252 423 256 Bytes -688 Bytes -0.000%
ydbd stripped size 473 490 448 Bytes 473 490 192 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexv-smirnov alexv-smirnov enabled auto-merge (squash) January 15, 2025 17:35
@alexv-smirnov alexv-smirnov merged commit ef3837c into ydb-platform:main Jan 15, 2025
12 checks passed
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants