Skip to content

fixed bug in S3 Physical Optimizer 2 #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

evanevanevanevannnn
Copy link
Collaborator

Changelog entry

исправление для YQ-3957

откат #12985

оптимизатор ругался на вложенные DQ стейджи, которые получались при работе TS3PhysicalOptimizer (yql_s3_phy_opt.cpp:211, 244). Чтобы стейджи не были вложенными надо передавать input в Inputs() dq стейджа, а в лямбде тела стейджа использовать входной аргумент

Changelog category

  • Bugfix

Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 12:28:56 UTC Pre-commit check linux-x86_64-release-asan for d4d9546 has started.
2025-01-15 12:29:25 UTC Artifacts will be uploaded here
2025-01-15 12:33:00 UTC ya make is running...
🟡 2025-01-15 13:59:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11378 11332 0 17 2 27

2025-01-15 14:00:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 14:12:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 (only retried tests) 53 0 2 1 23

2025-01-15 14:12:18 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-15 14:15:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
50 (only retried tests) 27 0 0 0 23

🟢 2025-01-15 14:15:37 UTC Build successful.
🟢 2025-01-15 14:16:06 UTC ydbd size 3.6 GiB changed* by +13.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1edb570 merge: d4d9546 diff diff %
ydbd size 3 895 435 096 Bytes 3 895 449 096 Bytes +13.7 KiB +0.000%
ydbd stripped size 1 360 977 648 Bytes 1 360 982 704 Bytes +4.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 12:30:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for d4d9546 has started.
2025-01-15 12:30:51 UTC Artifacts will be uploaded here
2025-01-15 12:33:56 UTC ya make is running...
🟡 2025-01-15 13:56:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25095 22485 0 107 2380 123

2025-01-15 13:59:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 14:12:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
293 (only retried tests) 70 0 102 0 121

2025-01-15 14:12:25 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-15 14:24:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
284 (only retried tests) 61 0 102 0 121

🟢 2025-01-15 14:24:16 UTC Build successful.
🟢 2025-01-15 14:24:40 UTC ydbd size 2.1 GiB changed* by +3.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2555770 merge: d4d9546 diff diff %
ydbd size 2 247 501 384 Bytes 2 247 505 064 Bytes +3.6 KiB +0.000%
ydbd stripped size 472 866 896 Bytes 472 867 408 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Hor911
Hor911 previously approved these changes Jan 15, 2025
Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 09:40:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for e7faf7e has started.
2025-01-17 09:40:43 UTC Artifacts will be uploaded here
2025-01-17 09:43:42 UTC ya make is running...
🟡 2025-01-17 10:36:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25140 22623 0 10 2380 127

2025-01-17 10:38:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-17 10:49:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
201 (only retried tests) 81 0 1 0 119

2025-01-17 10:49:59 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-17 11:01:38 UTC ydbd size 2.1 GiB changed* by -45.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: db1f75f merge: e7faf7e diff diff %
ydbd size 2 252 494 928 Bytes 2 252 448 432 Bytes -45.4 KiB -0.002%
ydbd stripped size 473 412 144 Bytes 473 392 368 Bytes -19.3 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-17 11:01:40 UTC Check cancelled

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 09:40:41 UTC Pre-commit check linux-x86_64-release-asan for e7faf7e has started.
2025-01-17 09:40:52 UTC Artifacts will be uploaded here
2025-01-17 09:43:51 UTC ya make is running...
🟡 2025-01-17 10:41:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11110 11048 0 27 7 28

2025-01-17 10:42:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-17 10:54:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 70 0 1 3 24

2025-01-17 10:54:20 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-17 11:01:29 UTC ydbd size 3.6 GiB changed* by -80.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: db1f75f merge: e7faf7e diff diff %
ydbd size 3 903 151 288 Bytes 3 903 069 272 Bytes -80.1 KiB -0.002%
ydbd stripped size 1 362 659 120 Bytes 1 362 578 128 Bytes -79.1 KiB -0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-17 11:01:30 UTC Check cancelled

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 11:04:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 72fe944 has started.
2025-01-17 11:05:02 UTC Artifacts will be uploaded here
2025-01-17 11:07:54 UTC ya make is running...
🟡 2025-01-17 12:00:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25188 22629 0 11 2424 124

2025-01-17 12:02:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-17 12:14:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
240 (only retried tests) 118 0 1 0 121

2025-01-17 12:14:43 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-17 12:26:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 58 0 0 0 118

🟢 2025-01-17 12:26:37 UTC Build successful.
🟢 2025-01-17 12:27:00 UTC ydbd size 2.1 GiB changed* by -45.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3712773 merge: 72fe944 diff diff %
ydbd size 2 252 515 384 Bytes 2 252 468 368 Bytes -45.9 KiB -0.002%
ydbd stripped size 473 418 704 Bytes 473 398 864 Bytes -19.4 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 11:05:10 UTC Pre-commit check linux-x86_64-release-asan for 72fe944 has started.
2025-01-17 11:05:22 UTC Artifacts will be uploaded here
2025-01-17 11:08:24 UTC ya make is running...
🟡 2025-01-17 12:06:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11182 11116 0 21 15 30

2025-01-17 12:07:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-17 12:19:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 75 0 1 1 24

2025-01-17 12:19:12 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-17 12:31:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 23 0 1 0 24

🟢 2025-01-17 12:31:30 UTC Build successful.
🟢 2025-01-17 12:31:58 UTC ydbd size 3.6 GiB changed* by -85.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3712773 merge: 72fe944 diff diff %
ydbd size 3 903 186 552 Bytes 3 903 099 320 Bytes -85.2 KiB -0.002%
ydbd stripped size 1 362 669 904 Bytes 1 362 586 928 Bytes -81.0 KiB -0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 13:01:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for b84d6e8 has started.
2025-01-17 13:01:47 UTC Artifacts will be uploaded here
2025-01-17 13:04:42 UTC ya make is running...
🟡 2025-01-17 14:13:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25188 22684 0 4 2380 120

2025-01-17 14:15:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-17 14:28:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
179 (only retried tests) 61 0 0 0 118

🟢 2025-01-17 14:28:32 UTC Build successful.
🟢 2025-01-17 14:28:53 UTC ydbd size 2.1 GiB changed* by -41.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8617043 merge: b84d6e8 diff diff %
ydbd size 2 252 592 656 Bytes 2 252 549 728 Bytes -41.9 KiB -0.002%
ydbd stripped size 473 436 944 Bytes 473 421 200 Bytes -15.4 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 13:01:35 UTC Pre-commit check linux-x86_64-release-asan for b84d6e8 has started.
2025-01-17 13:01:47 UTC Artifacts will be uploaded here
2025-01-17 13:04:42 UTC ya make is running...
🟡 2025-01-17 14:15:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11182 11136 0 12 6 28

2025-01-17 14:16:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-17 14:31:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 49 0 0 0 25

🟢 2025-01-17 14:31:11 UTC Build successful.
🟢 2025-01-17 14:31:37 UTC ydbd size 3.6 GiB changed* by -89.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8617043 merge: b84d6e8 diff diff %
ydbd size 3 903 322 136 Bytes 3 903 230 792 Bytes -89.2 KiB -0.002%
ydbd stripped size 1 362 714 512 Bytes 1 362 627 440 Bytes -85.0 KiB -0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@evanevanevanevannnn evanevanevanevannnn merged commit 10720d0 into ydb-platform:main Jan 17, 2025
12 checks passed
@evanevanevanevannnn evanevanevanevannnn deleted the YQ_3957_fix branch January 17, 2025 14:54
the-ancient-1 pushed a commit to the-ancient-1/ydb that referenced this pull request Jan 21, 2025
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Jan 23, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants