Skip to content

Add light indicator for bursts to BsCostModel, #1336 #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 31, 2024
Merged

Add light indicator for bursts to BsCostModel, #1336 #1337

merged 5 commits into from
Jan 31, 2024

Conversation

serbel324
Copy link
Collaborator

  • Move TLight to core/util, add BurstDetector to TBsCostTracker
  • Add UT

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

⚪ 2024-01-26 10:55:06 UTC Pre-commit check for e90117d has started.
⚪ 2024-01-26 10:55:09 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-26 11:00:47 UTC Build failed. see the build logs.
⚪ 2024-01-26 11:01:00 UTC Tests are running...
🔴 2024-01-26 11:31:35 UTC Test run completed, no test results found for commit 3587f65. Please check build logs.
⚫ 2024-01-26 11:31:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

⚪ 2024-01-26 10:55:30 UTC Pre-commit check for e90117d has started.
⚪ 2024-01-26 10:55:32 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-26 11:01:46 UTC Build failed. see the build logs.
⚪ 2024-01-26 11:02:03 UTC Tests are running...
🔴 2024-01-26 11:31:31 UTC Test run completed, no test results found for commit 3587f65. Please check build logs.
⚫ 2024-01-26 11:31:35 UTC Check cancelled

@serbel324 serbel324 force-pushed the bs/vdisk/cost-bucket branch from 3587f65 to aff8ebc Compare January 26, 2024 11:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

⚪ 2024-01-26 11:35:07 UTC Pre-commit check for 2d3a44c has started.
⚪ 2024-01-26 11:35:10 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-26 11:37:09 UTC Build failed. see the build logs.
⚪ 2024-01-26 11:37:21 UTC Tests are running...
🔴 2024-01-26 12:47:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60046 50774 0 1 9247 24

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

⚪ 2024-01-26 11:35:45 UTC Pre-commit check for 2d3a44c has started.
⚪ 2024-01-26 11:35:48 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-26 11:38:05 UTC Build failed. see the build logs.
⚪ 2024-01-26 11:38:18 UTC Tests are running...
🔴 2024-01-26 13:12:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15952 15844 0 16 58 34

@serbel324 serbel324 force-pushed the bs/vdisk/cost-bucket branch from 29c19a7 to 85e2f60 Compare January 29, 2024 09:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 09:26:34 UTC Pre-commit check for bf03aa7 has started.
⚪ 2024-01-29 09:26:36 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-29 09:31:44 UTC Build successful.
⚪ 2024-01-29 09:31:57 UTC Tests are running...
🔴 2024-01-29 10:49:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60137 50813 0 19 9257 48

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

⚪ 2024-01-29 09:27:34 UTC Pre-commit check for bf03aa7 has started.
⚪ 2024-01-29 09:27:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-29 09:33:49 UTC Build successful.
⚪ 2024-01-29 09:34:00 UTC Tests are running...
🔴 2024-01-29 11:12:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15888 15779 0 24 63 22

alexvru
alexvru requested changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@alexvru alexvru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тесты попадали

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 15:52:32 UTC Pre-commit check for 534e2bf has started.
⚪ 2024-01-30 15:52:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 15:57:51 UTC Build successful.
⚪ 2024-01-30 15:58:01 UTC Tests are running...
🔴 2024-01-30 17:21:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60304 50926 0 37 9311 30

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 15:54:48 UTC Pre-commit check for 534e2bf has started.
⚪ 2024-01-30 15:54:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 16:00:45 UTC Build successful.
⚪ 2024-01-30 16:00:56 UTC Tests are running...
🔴 2024-01-30 17:36:30 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16020 15815 0 53 110 42

@serbel324 serbel324 force-pushed the bs/vdisk/cost-bucket branch from f2fdde9 to 05c39a1 Compare January 30, 2024 20:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 20:07:44 UTC Pre-commit check for 94e9b60 has started.
⚪ 2024-01-30 20:07:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 20:15:20 UTC Build successful.
⚪ 2024-01-30 20:15:33 UTC Tests are running...
🔴 2024-01-30 21:41:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60317 50998 0 1 9264 54

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 20:07:45 UTC Pre-commit check for 94e9b60 has started.
⚪ 2024-01-30 20:07:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 20:15:46 UTC Build successful.
⚪ 2024-01-30 20:16:03 UTC Tests are running...
🔴 2024-01-30 21:50:47 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16025 15918 0 12 54 41

@serbel324 serbel324 merged commit 3b1a363 into ydb-platform:main Jan 31, 2024
serbel324 added a commit to serbel324/ydb that referenced this pull request Jan 31, 2024
@serbel324
Revert "Add light indicator for bursts to BsCostModel, ydb-platform#1336
adc08f3 
 (ydb-platform#1337)"

This reverts commit 3b1a363.
CyberROFL added a commit that referenced this pull request Jan 31, 2024
@CyberROFL
Revert "Add light indicator for bursts to BsCostModel, #1336 (#1337)"
475b78d 
This reverts commit 3b1a363.
@CyberROFL CyberROFL mentioned this pull request Jan 31, 2024
Merged
CyberROFL added a commit that referenced this pull request Jan 31, 2024
@CyberROFL
Revert "Add light indicator for bursts to BsCostModel, #1336 (#1337)" (…
83b8570 
…#1458)

This reverts commit 3b1a363.
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 31, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru alexvru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serbel324 @alexvru