Tests update #12946
Tests update #12946
Conversation
ydb/tests/sql/test_crud.py
Outdated
| class TestYdbCrudOperations(object): | ||
|
|
||
| @classmethod | ||
| def setup_class(cls): |
There was a problem hiding this comment.
Много копипасты, мне кажется надо сделать базовый класс а в самих тестах только бомбить запросами
There was a problem hiding this comment.
все так. ты обещал порефакторить
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/tests/sql/test_inserts.py
Outdated
| rows = result[0].rows | ||
| assert len(rows) == 1 and rows[0].count == 100, f"Expected 100 rows, found: {rows[0].count}" | ||
|
|
||
| # def test_transactional_update(self): |
There was a problem hiding this comment.
Ну вот наверное не надо комментить код просто так
There was a problem hiding this comment.
это код про транзакции в ExecuteQuery. Как только разберусь - раскомменчу
ydb/tests/sql/test_sql.py
Outdated
| PRIMARY KEY (id) | ||
| );""" | ||
| ) | ||
| table_name = table_name = "{}/{}_{}_{}".format(self.table_path, type_, value, is_column) |
There was a problem hiding this comment.
я бы ожидал, что в self.table_path уже лежит полное имя теста, и тебе самому не нужно конструировать путь с использованием параметров
There was a problem hiding this comment.
это из-за параметризации теста. или таблицы удаляются после выхода из функции?
ydb/tests/sql/test_crud.py
Outdated
| ) | ||
|
|
||
| # Create (Insert) | ||
| self.pool.execute_with_retries( |
There was a problem hiding this comment.
self.pool.execute_with_retries слишком вербозно. Желательно self.query(...)
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Additional information
...