Skip to content

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

Fixed the errors:

  1. The program deleted the service partition if the message TEvLongTxService::TEvLockStatus arrived before the transaction was completed. As a result, the transaction could be partially executed. Added a check that the service partition can only be deleted if no TEvProposeTransaction messages have been received yet.
  2. The program did not take into account that it can receive a TEvReadSet more times than the number of senders in TEvProposeTransaction. Deleted the check from `Y_ABORT_UNLESS'.
  3. Replaced the 'Y_ABORT_UNLESSchecks with theForceFalseflag. Instead of an abnormal termination, the program returnsABORTED'.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner December 23, 2024 13:43
@Alek5andr-Kotov Alek5andr-Kotov changed the title Logbroker 9262x Fixed errors with transactions in the PQ tablet Dec 23, 2024
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:45:25 UTC Pre-commit check for c16c326 has started.
2024-12-23 13:48:10 UTC Build linux-x86_64-relwithdebinfo is running...
2024-12-23 14:00:35 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:45:51 UTC Pre-commit check for c16c326 has started.
2024-12-23 13:48:31 UTC Build linux-x86_64-release-asan is running...
2024-12-23 14:00:50 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 14:03:23 UTC Pre-commit check for ffe6cfe has started.
2024-12-23 14:06:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-23 14:29:50 UTC Build successful.
2024-12-23 14:30:03 UTC Tests are running...
🔴 2024-12-23 16:42:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11630 11534 0 25 29 42

🟡 2024-12-23 16:43:41 UTC ydbd size 5.6 GiB changed* by +262.7 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: ef48b00 merge: ffe6cfe diff diff %
ydbd size 6 002 617 848 Bytes 6 002 886 848 Bytes +262.7 KiB +0.004%
ydbd stripped size 1 504 212 928 Bytes 1 504 283 456 Bytes +68.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 14:04:41 UTC Pre-commit check for ffe6cfe has started.
2024-12-23 14:07:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-23 14:46:58 UTC Build successful.
2024-12-23 14:47:18 UTC Tests are running...
🔴 2024-12-23 16:16:40 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15959 14614 0 8 1300 37

🟡 2024-12-23 16:17:28 UTC ydbd size 8.3 GiB changed* by +295.4 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: ef48b00 merge: ffe6cfe diff diff %
ydbd size 8 873 577 592 Bytes 8 873 880 088 Bytes +295.4 KiB +0.003%
ydbd stripped size 484 354 664 Bytes 484 378 728 Bytes +23.5 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants