Skip to content

add restricting tablet availability to hive ui KIKIMR-20617 #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 2, 2024
Merged

add restricting tablet availability to hive ui KIKIMR-20617 #1288

merged 6 commits into from
Feb 2, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

Restrict which nodes may run which tablet types through Hive developer web ui.

Changelog category

  • New feature

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 10:39:05 UTC Pre-commit check for 1b0c47e has started.
⚪ 2024-01-25 10:39:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-25 10:49:49 UTC Build successful.
⚪ 2024-01-25 10:50:03 UTC Tests are running...
🔴 2024-01-25 12:14:36 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60106 50840 0 8 9238 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 10:41:29 UTC Pre-commit check for 1b0c47e has started.
⚪ 2024-01-25 10:41:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-25 10:54:18 UTC Build successful.
⚪ 2024-01-25 10:54:31 UTC Tests are running...
🔴 2024-01-25 12:30:12 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15942 15827 0 22 63 30

@vporyadke
Copy link
Collaborator Author

image
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 12:24:18 UTC Pre-commit check for c1627c9 has started.
⚪ 2024-02-01 12:24:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-01 12:35:21 UTC Build successful.
⚪ 2024-02-01 12:35:36 UTC Tests are running...
🟢 2024-02-01 14:00:51 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58830 49531 0 0 9270 29

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 12:24:33 UTC Pre-commit check for c1627c9 has started.
⚪ 2024-02-01 12:24:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-01 12:36:11 UTC Build successful.
⚪ 2024-02-01 12:36:24 UTC Tests are running...
🔴 2024-02-01 14:14:18 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14512 14390 0 26 66 30

@vporyadke
Copy link
Collaborator Author

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 17:21:14 UTC Pre-commit check for c7843b5 has started.
⚪ 2024-02-01 17:21:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-01 17:32:33 UTC Build successful.
⚪ 2024-02-01 17:32:43 UTC Tests are running...
🟢 2024-02-01 18:57:56 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58832 49528 0 0 9268 36

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

⚪ 2024-02-01 17:23:23 UTC Pre-commit check for c7843b5 has started.
⚪ 2024-02-01 17:23:26 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-01 17:34:32 UTC Build successful.
⚪ 2024-02-01 17:34:49 UTC Tests are running...
🔴 2024-02-01 19:09:22 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14521 14394 0 35 59 33

ijon
ijon reviewed Feb 2, 2024
View reviewed changes
ydb/core/mind/hive/hive.h Outdated
Comment on lines 232 to 237
const std::unordered_map<TTabletTypes::EType, TString> TABLET_TYPE_SHORT_NAMES = {{TTabletTypes::SchemeShard, "SS"},
{TTabletTypes::Hive, "H"},
{TTabletTypes::DataShard, "DS"},
{TTabletTypes::ColumnShard, "CS"},
{TTabletTypes::KeyValue, "KV"},
{TTabletTypes::PersQueue, "PQ"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it would be a good idea to move TABLET_TYPE_SHORT_NAMES and TABLET_TYPE_BY_SHORT_NAME mapping definitions to hive.cpp (along with supporting function MakeReverseMap()).

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 12:53:08 UTC Pre-commit check for bee02f1 has started.
⚪ 2024-02-02 12:53:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-02 13:03:25 UTC Build successful.
⚪ 2024-02-02 13:03:38 UTC Tests are running...
🔴 2024-02-02 14:28:13 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58853 49555 0 5 9265 28

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 12:54:54 UTC Pre-commit check for bee02f1 has started.
⚪ 2024-02-02 12:54:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-02 13:05:36 UTC Build successful.
⚪ 2024-02-02 13:10:09 UTC Tests are running...
🔴 2024-02-02 14:52:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14533 14362 0 53 70 48

@vporyadke vporyadke merged commit a486f30 into ydb-platform:main Feb 2, 2024
@vitstn vitstn mentioned this pull request Feb 2, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Feb 4, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 4, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vporyadke @ijon