Skip to content

Conversation

@VPolka
Copy link
Collaborator

@VPolka VPolka commented Dec 18, 2024

Changelog entry

...

Changelog category

  • Improvement

Additional information

...

@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 14:51:52 UTC Pre-commit check linux-x86_64-release-asan for cd33dba has started.
2024-12-18 14:51:58 UTC Artifacts will be uploaded here
2024-12-18 14:54:53 UTC ya make is running...
🟡 2024-12-18 16:03:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13727 13620 0 55 5 47

🟢 2024-12-18 16:05:02 UTC Build successful.
🟢 2024-12-18 16:05:28 UTC ydbd size 3.6 GiB changed* by +71.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 47dde79 merge: cd33dba diff diff %
ydbd size 3 895 061 568 Bytes 3 895 134 376 Bytes +71.1 KiB +0.002%
ydbd stripped size 1 364 015 184 Bytes 1 364 038 864 Bytes +23.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 14:53:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for cd33dba has started.
2024-12-18 14:53:19 UTC Artifacts will be uploaded here
2024-12-18 14:56:13 UTC ya make is running...
🟡 2024-12-18 17:24:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20915 19376 0 6 1414 119

2024-12-18 17:26:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-18 17:37:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 56 0 3 0 110

2024-12-18 17:37:59 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-18 17:49:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
158 (only retried tests) 49 0 0 0 109

🟢 2024-12-18 17:49:34 UTC Build successful.
🟢 2024-12-18 17:49:55 UTC ydbd size 2.1 GiB changed* by +28.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 47dde79 merge: cd33dba diff diff %
ydbd size 2 254 038 592 Bytes 2 254 067 544 Bytes +28.3 KiB +0.001%
ydbd stripped size 483 096 208 Bytes 483 100 496 Bytes +4.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 8f9f617 to 9b834dc Compare December 18, 2024 18:19
@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 18:22:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 10980d7 has started.
2024-12-18 18:22:16 UTC Artifacts will be uploaded here
2024-12-18 18:25:08 UTC ya make is running...
🔴 2024-12-18 18:29:00 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 18:22:17 UTC Pre-commit check linux-x86_64-release-asan for 10980d7 has started.
2024-12-18 18:22:20 UTC Artifacts will be uploaded here
2024-12-18 18:25:16 UTC ya make is running...
🔴 2024-12-18 18:29:17 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 10:12:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 51848eb has started.
2024-12-20 10:12:19 UTC Artifacts will be uploaded here
2024-12-20 10:15:20 UTC ya make is running...
🔴 2024-12-20 10:18:24 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 10:12:24 UTC Pre-commit check linux-x86_64-release-asan for 51848eb has started.
2024-12-20 10:12:35 UTC Artifacts will be uploaded here
2024-12-20 10:15:33 UTC ya make is running...
🔴 2024-12-20 10:18:43 UTC Build failed, see the logs. Also see fail summary

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 766fedf to 214733e Compare December 23, 2024 09:58
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 10:01:42 UTC Pre-commit check linux-x86_64-release-asan for d2e2246 has started.
2024-12-23 10:01:53 UTC Artifacts will be uploaded here
2024-12-23 10:04:46 UTC ya make is running...
🔴 2024-12-23 10:08:03 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 10:01:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for d2e2246 has started.
2024-12-23 10:02:04 UTC Artifacts will be uploaded here
2024-12-23 10:05:11 UTC ya make is running...
🔴 2024-12-23 10:08:08 UTC Build failed, see the logs. Also see fail summary

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 214733e to 570c9ea Compare December 23, 2024 13:09
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:13:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for e455829 has started.
2024-12-23 13:13:24 UTC Artifacts will be uploaded here
2024-12-23 13:16:33 UTC ya make is running...
🔴 2024-12-23 13:20:14 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:13:13 UTC Pre-commit check linux-x86_64-release-asan for e455829 has started.
2024-12-23 13:13:52 UTC Artifacts will be uploaded here
2024-12-23 13:17:21 UTC ya make is running...
🔴 2024-12-23 13:21:49 UTC Build failed, see the logs. Also see fail summary

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 570c9ea to 53e78ec Compare December 23, 2024 16:43
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 16:46:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 565783b has started.
2024-12-23 16:51:12 UTC Artifacts will be uploaded here
2024-12-23 16:54:05 UTC ya make is running...
🔴 2024-12-23 16:56:31 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 16:46:34 UTC Pre-commit check linux-x86_64-release-asan for 565783b has started.
2024-12-23 16:46:58 UTC Artifacts will be uploaded here
2024-12-23 16:49:52 UTC ya make is running...
🔴 2024-12-23 16:54:55 UTC Build failed, see the logs. Also see fail summary

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 53e78ec to 9ae693b Compare December 23, 2024 17:51
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 17:53:14 UTC Pre-commit check linux-x86_64-release-asan for 55ebc1f has started.
2024-12-23 17:53:25 UTC Artifacts will be uploaded here
2024-12-23 17:56:19 UTC ya make is running...
2024-12-23 18:40:46 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 17:55:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 55ebc1f has started.
2024-12-23 17:56:07 UTC Artifacts will be uploaded here
2024-12-23 17:59:12 UTC ya make is running...
2024-12-23 18:40:45 UTC Check cancelled

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 9ae693b to 7084292 Compare December 23, 2024 18:40
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 18:42:21 UTC Pre-commit check linux-x86_64-release-asan for f11d065 has started.
2024-12-23 18:43:23 UTC Check cancelled

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 7084292 to 0ef8627 Compare December 23, 2024 18:43
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 18:44:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 673784e has started.
2024-12-23 18:45:03 UTC Artifacts will be uploaded here
2024-12-23 18:46:39 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 18:44:52 UTC Pre-commit check linux-x86_64-release-asan for 673784e has started.
2024-12-23 18:45:03 UTC Artifacts will be uploaded here
2024-12-23 18:46:39 UTC Check cancelled

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 0ef8627 to 25d4a1e Compare December 23, 2024 18:46
@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 18:48:06 UTC Pre-commit check linux-x86_64-release-asan for 7342855 has started.
2024-12-23 18:48:10 UTC Artifacts will be uploaded here
2024-12-23 18:51:03 UTC ya make is running...
🔴 2024-12-23 18:57:39 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 18:49:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7342855 has started.
2024-12-23 18:49:58 UTC Artifacts will be uploaded here
2024-12-23 18:53:32 UTC ya make is running...
🔴 2024-12-23 18:55:59 UTC Build failed, see the logs. Also see fail summary

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 25d4a1e to dd39ea3 Compare December 24, 2024 08:50
@github-actions
Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 08:53:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9570dd has started.
2024-12-24 08:54:00 UTC Artifacts will be uploaded here
2024-12-24 08:57:03 UTC ya make is running...
🟡 2024-12-24 10:04:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20932 19397 0 3 1415 117

2024-12-24 10:05:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 10:17:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
170 (only retried tests) 58 0 0 1 111

🟢 2024-12-24 10:17:45 UTC Build successful.
🟢 2024-12-24 10:18:03 UTC ydbd size 2.1 GiB changed* by +72.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 18ed18e merge: a9570dd diff diff %
ydbd size 2 235 030 744 Bytes 2 235 104 560 Bytes +72.1 KiB +0.003%
ydbd stripped size 477 983 088 Bytes 477 992 624 Bytes +9.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

template <typename TEv>
TCommonHandleClass(const TEv& ev) {
if constexpr (THasRecordWithGetHandleClass<TEv>::value) {
TCommonHandleClass(ev.Record.GetHandleClass());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does exactly nothing, as I suppose

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more details on this issue please?
I did this because in some events HandleClass is in Record field, while in others it is not

};

struct TReportingOSStatus {
using EnableFor = std::tuple<
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it is a good idea to use tuple to describe a set of types

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made special template type for this

@VPolka VPolka force-pushed the add-ok-and-error-request-metrics branch from 17bad97 to 76ed742 Compare February 20, 2025 12:30
@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 12:31:59 UTC Pre-commit check linux-x86_64-release-asan for 8815822 has started.
2025-02-20 12:32:12 UTC Artifacts will be uploaded here
2025-02-20 12:35:09 UTC ya make is running...
🟡 2025-02-20 14:10:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13447 13365 0 32 11 39

2025-02-20 14:12:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-20 14:35:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 82 0 1 6 34

2025-02-20 14:35:59 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-20 14:47:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 33 0 0 4 32

🟢 2025-02-20 14:47:44 UTC Build successful.
🟡 2025-02-20 14:48:16 UTC ydbd size 3.6 GiB changed* by +104.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fe62452 merge: 8815822 diff diff %
ydbd size 3 895 673 176 Bytes 3 895 779 672 Bytes +104.0 KiB +0.003%
ydbd stripped size 1 364 069 600 Bytes 1 364 107 744 Bytes +37.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 12:32:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8815822 has started.
2025-02-20 12:32:49 UTC Artifacts will be uploaded here
2025-02-20 12:35:51 UTC ya make is running...
🟡 2025-02-20 14:05:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20765 19400 0 3 1228 134

2025-02-20 14:07:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 14:21:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 90 0 0 2 128

🟢 2025-02-20 14:21:19 UTC Build successful.
🟡 2025-02-20 14:21:40 UTC ydbd size 2.1 GiB changed* by +164.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2c7f23f merge: 8815822 diff diff %
ydbd size 2 239 408 024 Bytes 2 239 576 544 Bytes +164.6 KiB +0.008%
ydbd stripped size 474 528 696 Bytes 474 565 208 Bytes +35.7 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 08:52:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 75dcb79 has started.
2025-02-26 08:52:50 UTC Artifacts will be uploaded here
2025-02-26 08:55:41 UTC ya make is running...
🟡 2025-02-26 09:50:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20805 19431 0 5 1229 140

2025-02-26 09:52:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 10:19:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
230 (only retried tests) 98 0 0 0 132

🟢 2025-02-26 10:19:21 UTC Build successful.
🟢 2025-02-26 10:19:42 UTC ydbd size 2.1 GiB changed* by +69.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a378163 merge: 75dcb79 diff diff %
ydbd size 2 263 579 104 Bytes 2 263 650 472 Bytes +69.7 KiB +0.003%
ydbd stripped size 477 117 880 Bytes 477 128 056 Bytes +9.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 08:52:36 UTC Pre-commit check linux-x86_64-release-asan for 75dcb79 has started.
2025-02-26 08:52:51 UTC Artifacts will be uploaded here
2025-02-26 08:55:50 UTC ya make is running...
🟡 2025-02-26 10:01:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13352 13218 0 88 13 33

2025-02-26 10:03:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 10:21:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 135 0 0 7 31

🟢 2025-02-26 10:21:27 UTC Build successful.
🟡 2025-02-26 10:21:52 UTC ydbd size 3.7 GiB changed* by +127.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a378163 merge: 75dcb79 diff diff %
ydbd size 3 942 835 520 Bytes 3 942 966 496 Bytes +127.9 KiB +0.003%
ydbd stripped size 1 374 042 544 Bytes 1 374 086 128 Bytes +42.6 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 12:13:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for bab6ca5 has started.
2025-02-26 12:14:11 UTC Artifacts will be uploaded here
2025-02-26 12:17:51 UTC ya make is running...
🟡 2025-02-26 13:12:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20821 19462 0 3 1225 131

2025-02-26 13:14:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 13:25:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 85 0 1 0 124

2025-02-26 13:25:15 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-26 13:35:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 62 0 0 0 124

🟢 2025-02-26 13:36:04 UTC Build successful.
🟢 2025-02-26 13:36:26 UTC ydbd size 2.1 GiB changed* by +62.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8d25dd3 merge: bab6ca5 diff diff %
ydbd size 2 265 216 328 Bytes 2 265 279 776 Bytes +62.0 KiB +0.003%
ydbd stripped size 477 290 904 Bytes 477 300 120 Bytes +9.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 12:14:40 UTC Pre-commit check linux-x86_64-release-asan for bab6ca5 has started.
2025-02-26 12:14:53 UTC Artifacts will be uploaded here
2025-02-26 12:17:43 UTC ya make is running...
🟡 2025-02-26 13:22:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13359 13288 0 35 4 32

2025-02-26 13:24:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 13:35:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 85 0 4 1 27

2025-02-26 13:36:01 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-26 13:46:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 31 0 2 0 27

🟢 2025-02-26 13:46:14 UTC Build successful.
🟡 2025-02-26 13:46:46 UTC ydbd size 3.7 GiB changed* by +140.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8d25dd3 merge: bab6ca5 diff diff %
ydbd size 3 945 558 464 Bytes 3 945 702 704 Bytes +140.9 KiB +0.004%
ydbd stripped size 1 374 591 760 Bytes 1 374 638 672 Bytes +45.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@VPolka VPolka merged commit 297dee3 into ydb-platform:main Feb 26, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
VPolka added a commit to VPolka/ydb that referenced this pull request May 14, 2025
VPolka added a commit to VPolka/ydb that referenced this pull request May 14, 2025
VPolka added a commit to VPolka/ydb that referenced this pull request May 14, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/f25-3 PR участвует в списке изменений improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants