Skip to content

Enable antlr4 parser by default #12737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Feb 24, 2025
Merged

Enable antlr4 parser by default #12737

merged 23 commits into from
Feb 24, 2025

Conversation

@asmyasnikov
Copy link
Member

@asmyasnikov asmyasnikov commented Dec 18, 2024

Changelog entry

Enabled by default ANTLRv4 parser of YQL

Changelog category

  • Experimental feature

Additional information

...

@asmyasnikov asmyasnikov added the area/yql YQL query language issues label Dec 18, 2024
@asmyasnikov asmyasnikov self-assigned this Dec 18, 2024
@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 18, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 18, 2024
@github-actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

⚪ 2024-12-18 14:33:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 52dd3f7 has started.
⚪ 2024-12-18 14:38:47 UTC Artifacts will be uploaded here
⚪ 2024-12-18 14:41:59 UTC ya make is running...
🟡 2024-12-18 17:41:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31193 28239 0 8 2830 116

⚪ 2024-12-18 17:45:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-18 17:57:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 59 0 4 0 111

⚪ 2024-12-18 17:57:30 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-18 18:09:19 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 49 0 4 0 110

🟢 2024-12-18 18:09:26 UTC Build successful.
🟢 2024-12-18 18:09:47 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 47dde79 merge: 52dd3f7 diff diff %
ydbd size 2 254 038 592 Bytes 2 254 038 592 Bytes 0 Bytes 0.000%
ydbd stripped size 483 096 208 Bytes 483 096 208 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

⚪ 2024-12-18 14:33:31 UTC Pre-commit check linux-x86_64-release-asan for 52dd3f7 has started.
⚪ 2024-12-18 14:33:43 UTC Artifacts will be uploaded here
⚪ 2024-12-18 14:37:03 UTC ya make is running...
🟡 2024-12-18 16:20:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14181 14057 0 66 9 49

🟢 2024-12-18 16:21:58 UTC Build successful.
🟢 2024-12-18 16:22:24 UTC ydbd size 3.6 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 47dde79 merge: 52dd3f7 diff diff %
ydbd size 3 895 061 568 Bytes 3 895 061 488 Bytes -80 Bytes -0.000%
ydbd stripped size 1 364 015 184 Bytes 1 364 015 120 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 17:17:18 UTC Pre-commit check linux-x86_64-release-asan for 61bf41f has started.
⚪ 2024-12-23 17:17:29 UTC Artifacts will be uploaded here
⚪ 2024-12-23 17:20:51 UTC ya make is running...
🟡 2024-12-23 19:00:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14048 13959 0 31 7 51

🟢 2024-12-23 19:02:01 UTC Build successful.
🟢 2024-12-23 19:02:27 UTC ydbd size 3.6 GiB changed* by -240 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ab00ae5 merge: 61bf41f diff diff %
ydbd size 3 865 642 504 Bytes 3 865 642 264 Bytes -240 Bytes -0.000%
ydbd stripped size 1 350 675 856 Bytes 1 350 675 792 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 17:17:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 61bf41f has started.
⚪ 2024-12-23 17:17:42 UTC Artifacts will be uploaded here
⚪ 2024-12-23 17:20:56 UTC ya make is running...
🟡 2024-12-23 18:52:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31020 28050 0 14 2835 121

⚪ 2024-12-23 18:55:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-23 19:07:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
197 (only retried tests) 77 0 9 0 111

⚪ 2024-12-23 19:07:28 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-23 19:19:04 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 52 0 9 0 111

🟢 2024-12-23 19:19:11 UTC Build successful.
🟢 2024-12-23 19:19:34 UTC ydbd size 2.1 GiB changed* by -128 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ab00ae5 merge: 61bf41f diff diff %
ydbd size 2 235 025 960 Bytes 2 235 025 832 Bytes -128 Bytes -0.000%
ydbd stripped size 477 982 320 Bytes 477 982 320 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@asmyasnikov asmyasnikov requested review from a team as code owners December 23, 2024 19:44
@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 23, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 23, 2024
@github-actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 19:46:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 896d56c has started.
⚪ 2024-12-23 19:46:30 UTC Artifacts will be uploaded here
⚫ 2024-12-23 19:46:56 UTC Check cancelled

@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 23, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 23, 2024
@github-actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 19:49:09 UTC Pre-commit check linux-x86_64-release-asan for 3c0efeb has started.
⚪ 2024-12-23 19:49:20 UTC Artifacts will be uploaded here
⚪ 2024-12-23 19:52:43 UTC ya make is running...
🟡 2024-12-23 21:26:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14048 13955 0 30 16 47

🟢 2024-12-23 21:27:39 UTC Build successful.
🟢 2024-12-23 21:28:03 UTC ydbd size 3.6 GiB changed* by -240 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4f48bf5 merge: 3c0efeb diff diff %
ydbd size 3 865 642 504 Bytes 3 865 642 264 Bytes -240 Bytes -0.000%
ydbd stripped size 1 350 675 856 Bytes 1 350 675 792 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 19:52:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3c0efeb has started.
⚪ 2024-12-23 19:52:14 UTC Artifacts will be uploaded here
⚪ 2024-12-23 19:55:36 UTC ya make is running...
🟡 2024-12-23 21:25:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31020 28059 0 11 2833 117

⚪ 2024-12-23 21:28:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-23 21:39:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 69 0 7 1 113

⚪ 2024-12-23 21:40:03 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-23 21:52:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 55 0 6 0 113

🟢 2024-12-23 21:52:15 UTC Build successful.
🟢 2024-12-23 21:52:37 UTC ydbd size 2.1 GiB changed* by -128 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4f48bf5 merge: 3c0efeb diff diff %
ydbd size 2 235 025 960 Bytes 2 235 025 832 Bytes -128 Bytes -0.000%
ydbd stripped size 477 982 320 Bytes 477 982 320 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 17:28:52 UTC Pre-commit check linux-x86_64-release-asan for 834fc6c has started.
⚪ 2025-02-22 17:32:22 UTC Artifacts will be uploaded here
⚪ 2025-02-22 17:35:36 UTC ya make is running...
🔴 2025-02-22 17:46:25 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 17:31:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 834fc6c has started.
⚪ 2025-02-22 17:31:57 UTC Artifacts will be uploaded here
⚪ 2025-02-22 17:35:14 UTC ya make is running...
🔴 2025-02-22 17:47:45 UTC Build failed, see the logs. Also see fail summary

@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 22, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 22, 2025
@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 18:04:32 UTC Pre-commit check linux-x86_64-release-asan for ed0a05d has started.
⚪ 2025-02-22 18:05:34 UTC Artifacts will be uploaded here
⚪ 2025-02-22 18:08:42 UTC ya make is running...
🟡 2025-02-22 19:13:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13830 13745 0 41 10 34

⚪ 2025-02-22 19:14:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-22 19:31:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
132 (only retried tests) 96 0 0 5 31

🟢 2025-02-22 19:31:51 UTC Build successful.
🟡 2025-02-22 19:32:17 UTC ydbd size 3.6 GiB changed* by +805.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1041280 merge: ed0a05d diff diff %
ydbd size 3 899 596 224 Bytes 3 900 420 608 Bytes +805.1 KiB +0.021%
ydbd stripped size 1 364 895 696 Bytes 1 365 064 272 Bytes +164.6 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 18:05:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for ed0a05d has started.
⚪ 2025-02-22 18:06:00 UTC Artifacts will be uploaded here
⚪ 2025-02-22 18:09:10 UTC ya make is running...
🟡 2025-02-22 19:05:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28073 25463 0 4 2474 132

⚪ 2025-02-22 19:07:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-22 19:31:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
215 (only retried tests) 84 0 1 1 129

⚪ 2025-02-22 19:31:30 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-22 19:43:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 (only retried tests) 66 0 1 1 125

🟢 2025-02-22 19:43:53 UTC Build successful.
🟡 2025-02-22 19:44:15 UTC ydbd size 2.1 GiB changed* by +325.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1041280 merge: ed0a05d diff diff %
ydbd size 2 241 693 936 Bytes 2 242 026 920 Bytes +325.2 KiB +0.015%
ydbd stripped size 474 795 416 Bytes 474 822 104 Bytes +26.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 22, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 22, 2025
@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 20:41:28 UTC Pre-commit check linux-x86_64-release-asan for ac4ef4d has started.
⚪ 2025-02-22 20:42:09 UTC Artifacts will be uploaded here
⚪ 2025-02-22 20:45:18 UTC ya make is running...
🟡 2025-02-22 21:48:30 UTC ydbd size 3.6 GiB changed* by +805.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1041280 merge: ac4ef4d diff diff %
ydbd size 3 899 596 224 Bytes 3 900 420 608 Bytes +805.1 KiB +0.021%
ydbd stripped size 1 364 895 696 Bytes 1 365 064 272 Bytes +164.6 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-22 21:48:32 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 20:41:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for ac4ef4d has started.
⚪ 2025-02-22 20:41:47 UTC Artifacts will be uploaded here
⚪ 2025-02-22 20:44:56 UTC ya make is running...
🟡 2025-02-22 21:39:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28073 25458 0 3 2473 139

⚪ 2025-02-22 21:41:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-22 21:48:17 UTC ydbd size 2.1 GiB changed* by +325.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1041280 merge: ac4ef4d diff diff %
ydbd size 2 241 693 936 Bytes 2 242 026 920 Bytes +325.2 KiB +0.015%
ydbd stripped size 474 795 416 Bytes 474 822 104 Bytes +26.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-22 21:48:19 UTC Check cancelled

@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 22, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Feb 22, 2025
@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 21:52:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 590127d has started.
⚪ 2025-02-22 21:52:45 UTC Artifacts will be uploaded here
⚪ 2025-02-22 21:55:57 UTC ya make is running...
🟡 2025-02-22 23:05:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28073 25476 0 3 2460 134

⚪ 2025-02-22 23:08:29 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-22 23:21:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 75 0 0 2 126

🟢 2025-02-22 23:21:08 UTC Build successful.
🟡 2025-02-22 23:21:27 UTC ydbd size 2.1 GiB changed* by +325.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1041280 merge: 590127d diff diff %
ydbd size 2 241 693 936 Bytes 2 242 026 920 Bytes +325.2 KiB +0.015%
ydbd stripped size 474 795 416 Bytes 474 822 104 Bytes +26.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

⚪ 2025-02-22 21:52:39 UTC Pre-commit check linux-x86_64-release-asan for 590127d has started.
⚪ 2025-02-22 21:52:51 UTC Artifacts will be uploaded here
⚪ 2025-02-22 21:56:15 UTC ya make is running...
🟡 2025-02-22 23:00:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13831 13756 0 35 9 31

⚪ 2025-02-22 23:01:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-22 23:17:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 71 0 0 4 32

🟢 2025-02-22 23:17:28 UTC Build successful.
🟡 2025-02-22 23:17:55 UTC ydbd size 3.6 GiB changed* by +805.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1041280 merge: 590127d diff diff %
ydbd size 3 899 596 224 Bytes 3 900 420 608 Bytes +805.1 KiB +0.021%
ydbd stripped size 1 364 895 696 Bytes 1 365 064 272 Bytes +164.6 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@asmyasnikov asmyasnikov merged commit 5dda5b9 into ydb-platform:main Feb 24, 2025
12 checks passed
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@asmyasnikov
Enable antlr4 parser by default (ydb-platform#12737)
90e175e
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@asmyasnikov @blinkov
Enable antlr4 parser by default (#12737)
e37b1c5
asmyasnikov added a commit to asmyasnikov/ydb that referenced this pull request Jul 23, 2025
@asmyasnikov
Enable antlr4 parser by default (ydb-platform#12737)
ed36ed7
asmyasnikov added a commit to asmyasnikov/ydb that referenced this pull request Jul 23, 2025
@asmyasnikov
Enable antlr4 parser by default (ydb-platform#12737)
e308931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blinkov blinkov blinkov left review comments

@spuchin spuchin spuchin approved these changes

@uzhastik uzhastik uzhastik approved these changes

@FloatingCrowbar FloatingCrowbar Awaiting requested review from FloatingCrowbar FloatingCrowbar was automatically assigned from ydb-platform/topics

Assignees

@asmyasnikov asmyasnikov

Labels

area/yql YQL query language issues experimental-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asmyasnikov @blinkov @spuchin @uzhastik