Skip to content

Fixed finalizer leak #12679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fixed finalizer leak #12679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ydb/core/tx/schemeshard/schemeshard_cdc_stream_scan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class TCdcStreamScanFinalizer: public TActorBootstrapped<TCdcStreamScanFinalizer
void Handle(TEvTxUserProxy::TEvAllocateTxIdResult::TPtr& ev) {
Request->Record.SetTxId(ev->Get()->TxId);
Send(SSActorId, Request.Release());
TActorBootstrapped::PassAway();
}

private:
Expand Down Expand Up @@ -126,7 +127,7 @@ struct TSchemeShard::TCdcStreamScan::TTxProgress: public TTransactionBase<TSchem
}

if (Finalize) {
Self->CdcStreamScanFinalizer = ctx.Register(new TCdcStreamScanFinalizer(ctx.SelfID, std::move(Finalize)));
ctx.Register(new TCdcStreamScanFinalizer(ctx.SelfID, std::move(Finalize)));
}
}

Expand Down
4 changes: 0 additions & 4 deletions ydb/core/tx/schemeshard/schemeshard_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4512,10 +4512,6 @@ void TSchemeShard::Die(const TActorContext &ctx) {
ctx.Send(TabletMigrator, new TEvents::TEvPoisonPill());
}

if (CdcStreamScanFinalizer) {
ctx.Send(CdcStreamScanFinalizer, new TEvents::TEvPoisonPill());
}

IndexBuildPipes.Shutdown(ctx);
CdcStreamScanPipes.Shutdown(ctx);
ShardDeleter.Shutdown(ctx);
Expand Down
1 change: 0 additions & 1 deletion ydb/core/tx/schemeshard/schemeshard_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,6 @@ class TSchemeShard

TActorId TabletMigrator;

TActorId CdcStreamScanFinalizer;
ui32 MaxCdcInitialScanShardsInFlight = 10;

TDuration StatsMaxExecuteTime;
Expand Down
Loading