Skip to content

Fix incorrect Uuid serialization for CDC. #12587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

dcherednik
Copy link
Member

TCell stores uuid as binary data therefore it can contains \0 byte.

Changelog category

  • Bugfix

Additional information

...

TCell stores uuid as binary data therefore it can contains \0 byte.
Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 19:15:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0992ee3 has started.
2024-12-12 19:15:48 UTC Artifacts will be uploaded here
2024-12-12 19:19:10 UTC ya make is running...
🔴 2024-12-12 19:22:18 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 19:16:12 UTC Pre-commit check linux-x86_64-release-asan for 0992ee3 has started.
2024-12-12 19:16:23 UTC Artifacts will be uploaded here
2024-12-12 19:19:18 UTC ya make is running...
🔴 2024-12-12 19:22:13 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 19:31:34 UTC Pre-commit check linux-x86_64-release-asan for 6905b16 has started.
2024-12-12 19:32:05 UTC Artifacts will be uploaded here
2024-12-12 19:35:37 UTC ya make is running...
🟡 2024-12-12 20:36:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13345 13279 0 17 4 45

🟢 2024-12-12 20:37:24 UTC Build successful.
🟢 2024-12-12 20:37:48 UTC ydbd size 3.6 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7a1a682 merge: 6905b16 diff diff %
ydbd size 3 899 123 120 Bytes 3 899 124 896 Bytes +1.7 KiB +0.000%
ydbd stripped size 1 366 840 144 Bytes 1 366 841 296 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 19:33:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6905b16 has started.
2024-12-12 19:33:21 UTC Artifacts will be uploaded here
2024-12-12 19:36:30 UTC ya make is running...
🟡 2024-12-12 20:29:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20846 19311 0 9 1410 116

2024-12-12 20:31:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-12 20:43:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
748 (only retried tests) 639 0 0 0 109

🟢 2024-12-12 20:43:10 UTC Build successful.
🟢 2024-12-12 20:43:27 UTC ydbd size 2.1 GiB changed* by +520 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7a1a682 merge: 6905b16 diff diff %
ydbd size 2 256 566 000 Bytes 2 256 566 520 Bytes +520 Bytes +0.000%
ydbd stripped size 484 005 744 Bytes 484 006 064 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit 4b3df28 into ydb-platform:main Dec 13, 2024
10 checks passed
dcherednik added a commit to dcherednik/ydb that referenced this pull request Dec 13, 2024
TCell stores uuid as binary data therefore it can contains \0 byte.
dcherednik added a commit to dcherednik/ydb that referenced this pull request Dec 13, 2024
TCell stores uuid as binary data therefore it can contains \0 byte.
dcherednik added a commit that referenced this pull request Dec 13, 2024
TCell stores uuid as binary data therefore it can contains \0 byte.
dcherednik added a commit that referenced this pull request Dec 16, 2024
TCell stores uuid as binary data therefore it can contains \0 byte.

Changelog category

Bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants