Skip to content

channels count fix for standalone table #12410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024
Merged

channels count fix for standalone table #12410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ydb/core/statistics/service/ut/ut_http_request.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,18 @@ void ProbeTest(bool isServerless) {
TString columnName = "Value";
const auto sender = runtime.AllocateEdgeActor();

bool firstStatsToSA = false;
auto statsObserver1 = runtime.AddObserver<TEvStatistics::TEvSchemeShardStats>([&](auto& ev){
firstStatsToSA = true;
});
runtime.WaitFor("TEvSchemeShardStats 1", [&]{ return firstStatsToSA; });

bool secondStatsToSA = false;
auto statsObserver2 = runtime.AddObserver<TEvStatistics::TEvSchemeShardStats>([&](auto& ev){
secondStatsToSA = true;
});
runtime.WaitFor("TEvSchemeShardStats 2", [&]{ return secondStatsToSA; });

const auto operationId = TULIDGenerator().Next(TInstant::Now()).ToBinary();
auto analyzeRequest = MakeAnalyzeRequest({{tableInfo.PathId, {1, 2}}}, operationId);
runtime.SendToPipe(tableInfo.SaTabletId, sender, analyzeRequest.release());
Expand Down Expand Up @@ -96,4 +108,4 @@ Y_UNIT_TEST_SUITE(HttpRequest) {
}

} // NStat
} // NKikimr
} // NKikimr
5 changes: 2 additions & 3 deletions ydb/core/tx/schemeshard/olap/operations/create_table.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,8 +785,8 @@ class TCreateColumnTable: public TSubOperation {
olapStorePath.Base()->LastTxId = opTxId;
context.SS->PersistLastTxId(db, olapStorePath.Base());
} else {
NKikimrSchemeOp::TColumnStorageConfig storageConfig; // default
storageConfig.SetDataChannelCount(1);
tableInfo->StandaloneSharding = NKikimrSchemeOp::TColumnStoreSharding();
const NKikimrSchemeOp::TColumnStorageConfig& storageConfig = tableInfo->Description.GetStorageConfig();

TChannelsBindings channelsBindings;
if (!context.SS->GetOlapChannelsBindings(dstPath.GetPathIdForDomain(), storageConfig, channelsBindings, errStr)) {
Expand All @@ -800,7 +800,6 @@ class TCreateColumnTable: public TSubOperation {
TShardInfo columnShardInfo = TShardInfo::ColumnShardInfo(opTxId, pathId);
columnShardInfo.BindedChannels = channelsBindings;

tableInfo->StandaloneSharding = NKikimrSchemeOp::TColumnStoreSharding();
Y_ABORT_UNLESS(tableInfo->GetOwnedColumnShardsVerified().empty());

for (ui64 i = 0; i < shardsCount; ++i) {
Expand Down
Loading