Skip to content

Cli parquet #12372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Cli parquet #12372

merged 6 commits into from
Dec 9, 2024

Conversation

iddqdex
Copy link
Collaborator

@iddqdex iddqdex commented Dec 6, 2024

No description provided.

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 14:49:09 UTC Pre-commit check linux-x86_64-release-asan for 5e20c1f has started.
2024-12-06 14:49:21 UTC Artifacts will be uploaded here
2024-12-06 14:52:14 UTC ya make is running...
🟡 2024-12-06 15:56:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13304 13238 0 17 5 44

🟢 2024-12-06 15:57:15 UTC Build successful.
🟢 2024-12-06 15:57:42 UTC ydbd size 4.9 GiB changed* by +53.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 17066f1 merge: 5e20c1f diff diff %
ydbd size 5 305 570 352 Bytes 5 305 625 384 Bytes +53.7 KiB +0.001%
ydbd stripped size 1 365 574 736 Bytes 1 365 581 904 Bytes +7.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 14:51:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5e20c1f has started.
2024-12-06 14:51:35 UTC Artifacts will be uploaded here
2024-12-06 14:54:28 UTC ya make is running...
🟡 2024-12-06 15:45:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21067 19557 0 2 1397 111

2024-12-06 15:47:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-06 16:00:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
729 (only retried tests) 623 0 0 0 106

🟢 2024-12-06 16:00:10 UTC Build successful.
🟢 2024-12-06 16:00:29 UTC ydbd size 2.5 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 17066f1 merge: 5e20c1f diff diff %
ydbd size 2 699 201 576 Bytes 2 699 217 608 Bytes +15.7 KiB +0.001%
ydbd stripped size 483 500 720 Bytes 483 500 592 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 08:25:38 UTC Pre-commit check linux-x86_64-release-asan for 3f782d9 has started.
2024-12-09 08:26:04 UTC Artifacts will be uploaded here
2024-12-09 08:28:51 UTC Check cancelled

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 08:27:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f782d9 has started.
2024-12-09 08:28:10 UTC Artifacts will be uploaded here
2024-12-09 08:28:51 UTC Check cancelled

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 08:29:30 UTC Pre-commit check linux-x86_64-release-asan for 9f223b7 has started.
2024-12-09 08:29:34 UTC Artifacts will be uploaded here
2024-12-09 08:32:28 UTC ya make is running...
2024-12-09 09:00:44 UTC Check cancelled

@iddqdex iddqdex marked this pull request as ready for review December 9, 2024 08:29
@iddqdex iddqdex requested a review from a team as a code owner December 9, 2024 08:29
Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 08:32:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9f223b7 has started.
2024-12-09 08:32:51 UTC Artifacts will be uploaded here
2024-12-09 08:35:46 UTC ya make is running...
2024-12-09 09:00:46 UTC Check cancelled

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 09:02:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for d2d7d5f has started.
2024-12-09 09:02:30 UTC Artifacts will be uploaded here
2024-12-09 09:05:23 UTC ya make is running...
🟡 2024-12-09 09:54:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21079 19560 0 1 1408 110

2024-12-09 09:56:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-09 10:07:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
656 (only retried tests) 549 0 1 0 106

2024-12-09 10:08:02 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-09 10:20:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
633 (only retried tests) 526 0 0 0 107

🟢 2024-12-09 10:20:11 UTC Build successful.
🟢 2024-12-09 10:20:34 UTC ydbd size 2.5 GiB changed* by +22.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e19930f merge: d2d7d5f diff diff %
ydbd size 2 699 417 784 Bytes 2 699 440 808 Bytes +22.5 KiB +0.001%
ydbd stripped size 483 519 888 Bytes 483 520 272 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 09:04:39 UTC Pre-commit check linux-x86_64-release-asan for d2d7d5f has started.
2024-12-09 09:04:50 UTC Artifacts will be uploaded here
2024-12-09 09:07:46 UTC ya make is running...
🟡 2024-12-09 10:57:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13309 12860 0 305 95 49

🟢 2024-12-09 10:58:56 UTC Build successful.
🟢 2024-12-09 10:59:29 UTC ydbd size 4.9 GiB changed* by +69.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e19930f merge: d2d7d5f diff diff %
ydbd size 5 305 999 104 Bytes 5 306 069 904 Bytes +69.1 KiB +0.001%
ydbd stripped size 1 365 628 432 Bytes 1 365 633 552 Bytes +5.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@pnv1 pnv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI part LGTM

@iddqdex iddqdex merged commit 018b441 into ydb-platform:main Dec 9, 2024
10 checks passed
@iddqdex iddqdex deleted the cli-parquet branch December 9, 2024 11:01
@@ -1,5 +1,9 @@
#include "ydb_workload_import.h"
#include <ydb/core/io_formats/arrow/table/table.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему мы из CLI делаем зависимость на ydb/core? Мы так спокойно можем подцепить кучу серверного кода в CLI случайно. Давайте вынесем ydb/core/io_formats в ydb/library тогда, если CLI эта компонента так нужна

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants