Public API bootstrap command #12308

alexvru · 2024-12-05T09:43:13Z

Changelog entry

Public API bootstrap command

Changelog category

Not for changelog (changelog entry is not required)

Additional information

"ydb admin cluster bootstrap" command has been added to public API.

github-actions · 2024-12-05T09:44:48Z

⚪ 2024-12-05 09:44:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9f5b3d7 has started.
⚪ 2024-12-05 09:45:23 UTC Artifacts will be uploaded here
⚪ 2024-12-05 09:49:07 UTC ya make is running...
🔴 2024-12-05 09:52:22 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-12-05T09:47:10Z

⚪ 2024-12-05 09:47:10 UTC Pre-commit check linux-x86_64-release-asan for 9f5b3d7 has started.
⚪ 2024-12-05 09:47:23 UTC Artifacts will be uploaded here
⚪ 2024-12-05 09:50:45 UTC ya make is running...
⚫ 2024-12-05 09:53:40 UTC Check cancelled

github-actions · 2024-12-05T09:56:52Z

⚪ 2024-12-05 09:56:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 563eca2 has started.
⚪ 2024-12-05 09:57:37 UTC Artifacts will be uploaded here
⚪ 2024-12-05 10:01:24 UTC ya make is running...
⚫ 2024-12-05 10:03:16 UTC Check cancelled

pnv1 · 2024-12-05T09:55:29Z

ydb/public/lib/ydb_cli/commands/ydb_admin.cpp

@@ -10,6 +11,7 @@ TCommandAdmin::TCommandAdmin()
 {
    AddCommand(std::make_unique<NDynamicConfig::TCommandConfig>());
    AddCommand(std::make_unique<NDynamicConfig::TCommandVolatileConfig>());
+    AddCommand(std::make_unique<NCluster::TCommandCluster>());


Aren't config and volatile-config cluster-wide?
Was there a support meeting about this?

it's still a draft

We have discussed this, and decided to use "admin cluster bootstrap" command to emphasize the fact that this applies to the whole cluster.

pnv1 · 2024-12-05T09:56:57Z

ydb/public/lib/ydb_cli/commands/ydb_cluster.cpp

+
+void TCommandClusterBootstrap::Config(TConfig& config) {
+    TYdbCommand::Config(config);
+    config.Opts->AddLongOption("guid", "Self-assembly UUID")


GUID / UUID
Maybe we should stick to one terminology?

github-actions · 2024-12-05T09:57:47Z

⚪ 2024-12-05 09:57:47 UTC Pre-commit check linux-x86_64-release-asan for 563eca2 has started.
⚪ 2024-12-05 09:57:58 UTC Artifacts will be uploaded here
⚪ 2024-12-05 10:01:12 UTC ya make is running...
⚫ 2024-12-05 10:03:17 UTC Check cancelled

github-actions · 2024-12-05T10:05:09Z

⚪ 2024-12-05 10:05:08 UTC Pre-commit check linux-x86_64-release-asan for 4a43106 has started.
⚪ 2024-12-05 10:05:20 UTC Artifacts will be uploaded here
⚪ 2024-12-05 10:08:35 UTC ya make is running...
🟡 2024-12-05 11:40:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15760	15686	0	20	7	47

🟢 2024-12-05 11:41:45 UTC Build successful.
🟡 2024-12-05 11:42:14 UTC ydbd size 4.9 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ffa5093`	merge: `4a43106`	diff	diff %
ydbd size	5 304 181 048 Bytes	5 305 531 944 Bytes	+1.3 MiB	+0.025%
ydbd stripped size	1 365 337 968 Bytes	1 365 824 624 Bytes	+475.2 KiB	+0.036%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-05T10:05:38Z

⚪ 2024-12-05 10:05:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4a43106 has started.
⚪ 2024-12-05 10:05:52 UTC Artifacts will be uploaded here
⚪ 2024-12-05 10:09:20 UTC ya make is running...
🟡 2024-12-05 11:38:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33225	30391	0	2	2720	112

⚪ 2024-12-05 11:41:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-05 11:53:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
771 (only retried tests)	663	0	1	0	107

⚪ 2024-12-05 11:53:55 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-05 12:05:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
665 (only retried tests)	560	0	0	0	105

🟢 2024-12-05 12:05:30 UTC Build successful.
🟡 2024-12-05 12:05:50 UTC ydbd size 2.5 GiB changed* by +567.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `ffa5093`	merge: `4a43106`	diff	diff %
ydbd size	2 699 922 216 Bytes	2 700 503 672 Bytes	+567.8 KiB	+0.022%
ydbd stripped size	483 579 248 Bytes	483 721 264 Bytes	+138.7 KiB	+0.029%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-09T08:35:36Z

⚪ 2024-12-09 08:35:36 UTC Pre-commit check linux-x86_64-release-asan for 1d49d4c has started.
⚪ 2024-12-09 08:36:13 UTC Artifacts will be uploaded here
⚪ 2024-12-09 08:40:17 UTC ya make is running...
⚫ 2024-12-09 08:46:37 UTC Check cancelled

github-actions · 2024-12-09T08:36:46Z

⚪ 2024-12-09 08:36:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1d49d4c has started.
⚪ 2024-12-09 08:37:19 UTC Artifacts will be uploaded here
⚪ 2024-12-09 08:41:13 UTC ya make is running...
⚫ 2024-12-09 08:46:36 UTC Check cancelled

github-actions · 2024-12-09T08:47:59Z

⚪ 2024-12-09 08:47:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for d970047 has started.
⚪ 2024-12-09 08:48:13 UTC Artifacts will be uploaded here
⚪ 2024-12-09 08:51:30 UTC ya make is running...
🟡 2024-12-09 10:17:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33262	30428	0	1	2720	113

⚪ 2024-12-09 10:20:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-09 10:32:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
647 (only retried tests)	539	0	1	0	107

⚪ 2024-12-09 10:32:16 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-09 10:44:11 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
633 (only retried tests)	526	0	1	0	106

🟢 2024-12-09 10:44:22 UTC Build successful.
🟡 2024-12-09 10:44:42 UTC ydbd size 2.5 GiB changed* by +573.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `1382681`	merge: `d970047`	diff	diff %
ydbd size	2 699 417 000 Bytes	2 700 004 216 Bytes	+573.5 KiB	+0.022%
ydbd stripped size	483 519 568 Bytes	483 665 936 Bytes	+142.9 KiB	+0.030%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-09T08:49:32Z

⚪ 2024-12-09 08:49:31 UTC Pre-commit check linux-x86_64-release-asan for d970047 has started.
⚪ 2024-12-09 08:50:05 UTC Artifacts will be uploaded here
⚪ 2024-12-09 08:54:07 UTC ya make is running...
🟡 2024-12-09 10:26:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15793	15728	0	14	6	45

🟢 2024-12-09 10:28:12 UTC Build successful.
🟡 2024-12-09 10:28:42 UTC ydbd size 4.9 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `1382681`	merge: `d970047`	diff	diff %
ydbd size	5 305 993 888 Bytes	5 307 350 880 Bytes	+1.3 MiB	+0.026%
ydbd stripped size	1 365 623 632 Bytes	1 366 111 472 Bytes	+476.4 KiB	+0.036%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T09:25:13Z

⚪ 2024-12-11 09:25:12 UTC Pre-commit check linux-x86_64-release-asan for 263539b has started.
⚪ 2024-12-11 09:25:26 UTC Artifacts will be uploaded here
⚪ 2024-12-11 09:28:48 UTC ya make is running...
🟡 2024-12-11 11:10:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15828	15752	0	24	9	43

🟢 2024-12-11 11:11:58 UTC Build successful.
🟡 2024-12-11 11:12:21 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e838a62`	merge: `263539b`	diff	diff %
ydbd size	3 897 699 800 Bytes	3 898 810 504 Bytes	+1.1 MiB	+0.028%
ydbd stripped size	1 366 522 384 Bytes	1 367 021 936 Bytes	+487.8 KiB	+0.037%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T09:25:59Z

⚪ 2024-12-11 09:25:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 263539b has started.
⚪ 2024-12-11 09:26:11 UTC Artifacts will be uploaded here
⚪ 2024-12-11 09:29:27 UTC ya make is running...
🟡 2024-12-11 10:57:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33334	30417	0	1	2810	106

⚪ 2024-12-11 11:00:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-11 11:10:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
638 (only retried tests)	533	0	1	0	104

⚪ 2024-12-11 11:10:32 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-11 11:20:00 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
635 (only retried tests)	531	0	1	0	103

🟢 2024-12-11 11:20:16 UTC Build successful.
🟡 2024-12-11 11:20:39 UTC ydbd size 2.1 GiB changed* by +535.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e838a62`	merge: `263539b`	diff	diff %
ydbd size	2 255 721 664 Bytes	2 256 269 648 Bytes	+535.1 KiB	+0.024%
ydbd stripped size	483 873 296 Bytes	484 026 256 Bytes	+149.4 KiB	+0.032%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T11:53:37Z

⚪ 2024-12-11 11:53:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e35b31 has started.
⚪ 2024-12-11 11:53:41 UTC Artifacts will be uploaded here
⚪ 2024-12-11 11:56:55 UTC ya make is running...
🟡 2024-12-11 16:05:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33334	30345	0	5	2873	111

⚪ 2024-12-11 16:08:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-11 16:20:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
719 (only retried tests)	612	0	1	0	106

⚪ 2024-12-11 16:20:18 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-11 16:31:51 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
627 (only retried tests)	520	0	1	0	106

🟢 2024-12-11 16:32:01 UTC Build successful.
🟡 2024-12-11 16:32:20 UTC ydbd size 2.1 GiB changed* by +542.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `94c93fe`	merge: `8e35b31`	diff	diff %
ydbd size	2 255 709 176 Bytes	2 256 264 472 Bytes	+542.3 KiB	+0.025%
ydbd stripped size	483 853 712 Bytes	484 007 568 Bytes	+150.2 KiB	+0.032%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T11:54:42Z

⚪ 2024-12-11 11:54:41 UTC Pre-commit check linux-x86_64-release-asan for 8e35b31 has started.
⚪ 2024-12-11 11:54:45 UTC Artifacts will be uploaded here
⚪ 2024-12-11 11:58:09 UTC ya make is running...
🟡 2024-12-11 13:28:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15828	15759	0	16	7	46

🟢 2024-12-11 13:29:53 UTC Build successful.
🟡 2024-12-11 13:30:18 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `94c93fe`	merge: `8e35b31`	diff	diff %
ydbd size	3 897 704 336 Bytes	3 898 826 696 Bytes	+1.1 MiB	+0.029%
ydbd stripped size	1 366 512 400 Bytes	1 367 013 296 Bytes	+489.2 KiB	+0.037%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T17:11:54Z

⚪ 2024-12-11 17:11:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 860ccab has started.
⚪ 2024-12-11 17:12:25 UTC Artifacts will be uploaded here
⚪ 2024-12-11 17:16:24 UTC ya make is running...
🟢 2024-12-11 18:47:17 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33339	30415	0	0	2812	112

🟢 2024-12-11 18:50:02 UTC Build successful.
🟡 2024-12-11 18:50:17 UTC ydbd size 2.1 GiB changed* by +654.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `4ca0cb6`	merge: `860ccab`	diff	diff %
ydbd size	2 256 127 880 Bytes	2 256 798 280 Bytes	+654.7 KiB	+0.030%
ydbd stripped size	483 904 976 Bytes	484 088 912 Bytes	+179.6 KiB	+0.038%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-11T17:11:59Z

⚪ 2024-12-11 17:11:58 UTC Pre-commit check linux-x86_64-release-asan for 860ccab has started.
⚪ 2024-12-11 17:12:10 UTC Artifacts will be uploaded here
⚪ 2024-12-11 17:15:42 UTC ya make is running...
🟡 2024-12-11 18:55:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15830	15751	0	19	14	46

🟢 2024-12-11 18:56:25 UTC Build successful.
🟡 2024-12-11 18:56:50 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `7037279`	merge: `860ccab`	diff	diff %
ydbd size	3 898 599 456 Bytes	3 899 721 800 Bytes	+1.1 MiB	+0.029%
ydbd stripped size	1 366 736 656 Bytes	1 367 237 552 Bytes	+489.2 KiB	+0.037%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-12T07:01:36Z

⚪ 2024-12-12 07:01:35 UTC Pre-commit check linux-x86_64-release-asan for d4b1190 has started.
⚪ 2024-12-12 07:01:48 UTC Artifacts will be uploaded here
⚪ 2024-12-12 07:05:20 UTC ya make is running...
🟡 2024-12-12 08:47:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15830	15748	0	27	10	45

🟢 2024-12-12 08:49:00 UTC Build successful.
🟡 2024-12-12 08:49:25 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `95f1072`	merge: `d4b1190`	diff	diff %
ydbd size	3 898 441 552 Bytes	3 899 588 800 Bytes	+1.1 MiB	+0.029%
ydbd stripped size	1 366 674 160 Bytes	1 367 191 440 Bytes	+505.2 KiB	+0.038%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-12T07:02:54Z

⚪ 2024-12-12 07:02:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for d4b1190 has started.
⚪ 2024-12-12 07:03:06 UTC Artifacts will be uploaded here
⚪ 2024-12-12 07:06:30 UTC ya make is running...
🟡 2024-12-12 08:37:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33339	30417	0	1	2810	111

⚪ 2024-12-12 08:40:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-12 08:51:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
643 (only retried tests)	535	0	1	1	106

⚪ 2024-12-12 08:52:09 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-12 09:03:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
618 (only retried tests)	512	0	0	0	106

🟢 2024-12-12 09:03:43 UTC Build successful.
🟡 2024-12-12 09:04:03 UTC ydbd size 2.1 GiB changed* by +542.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `95f1072`	merge: `d4b1190`	diff	diff %
ydbd size	2 256 178 200 Bytes	2 256 733 296 Bytes	+542.1 KiB	+0.025%
ydbd stripped size	483 930 096 Bytes	484 075 760 Bytes	+142.2 KiB	+0.030%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-13T08:52:55Z

⚪ 2024-12-13 08:52:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 194a113 has started.
⚪ 2024-12-13 08:53:39 UTC Artifacts will be uploaded here
⚪ 2024-12-13 08:57:21 UTC ya make is running...
🟡 2024-12-13 10:23:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33352	30417	0	2	2822	111

⚪ 2024-12-13 10:26:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-13 10:37:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
700 (only retried tests)	592	0	0	0	108

🟢 2024-12-13 10:37:48 UTC Build successful.
🟡 2024-12-13 10:38:07 UTC ydbd size 2.1 GiB changed* by +538.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `7782482`	merge: `194a113`	diff	diff %
ydbd size	2 256 566 000 Bytes	2 257 116 992 Bytes	+538.1 KiB	+0.024%
ydbd stripped size	484 005 744 Bytes	484 147 312 Bytes	+138.2 KiB	+0.029%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

pnv1

CLI part LGTM

github-actions · 2024-12-13T08:54:27Z

⚪ 2024-12-13 08:54:27 UTC Pre-commit check linux-x86_64-release-asan for 194a113 has started.
⚪ 2024-12-13 08:54:38 UTC Artifacts will be uploaded here
⚪ 2024-12-13 08:58:04 UTC ya make is running...
🟡 2024-12-13 10:37:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15845	15766	0	24	10	45

🟢 2024-12-13 10:38:45 UTC Build successful.
🟡 2024-12-13 10:39:23 UTC ydbd size 3.6 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `7782482`	merge: `194a113`	diff	diff %
ydbd size	3 899 123 120 Bytes	3 900 262 200 Bytes	+1.1 MiB	+0.029%
ydbd stripped size	1 366 840 144 Bytes	1 367 349 264 Bytes	+497.2 KiB	+0.037%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Gazizonoki · 2024-12-16T12:42:55Z

ydb/public/sdk/cpp/client/ydb_bsconfig/ydb_storage_config.cpp

+        auto request = MakeRequest<Ydb::BSConfig::BootstrapClusterRequest>();
+        request.set_self_assembly_uuid(selfAssemblyUUID);
+
+        return RunSimple<Ydb::BSConfig::V1::BSConfigService, Ydb::BSConfig::BootstrapClusterRequest,


А почему RunSimple без TRpcRequestSettings вызывается? Клиент получается прокинуть клиентский таймаут не сможет

Gazizonoki · 2024-12-16T12:45:51Z

ydb/public/sdk/cpp/client/ydb_bsconfig/ydb_storage_config.h

@@ -46,6 +46,9 @@ class TStorageConfigClient {
    // Fetch current cluster storage config
    TAsyncFetchStorageConfigResult FetchStorageConfig(const TStorageConfigSettings& settings = {});

+    // Bootstrap cluster with automatic configuration
+    TAsyncStatus BootstrapCluster(const TString& selfAssemblyUUID);


ReplaceStorageConfig и BootstrapCluster вызываются без settings. Так нельзя, любой вызов через SDK должен иметь как минимум TSimpleRequestSettings

И еще это скорее не к тебе вопрос, но почему TStorageConfigSettings наследуется от TOperationRequestSettings? Это специфичные настройки, тут они не используются явно

alexvru requested a review from a team as a code owner December 5, 2024 09:43

github-actions bot added the not-for-changelog label Dec 5, 2024

alexvru force-pushed the distconf/bootstrap-api branch from 845103f to 9a54e3c Compare December 5, 2024 09:53

pnv1 reviewed Dec 5, 2024

View reviewed changes

alexvru force-pushed the distconf/bootstrap-api branch from 9a54e3c to db34672 Compare December 5, 2024 10:02

alexvru marked this pull request as draft December 5, 2024 10:47

alexvru force-pushed the distconf/bootstrap-api branch from db34672 to 9f0e266 Compare December 9, 2024 08:33

alexvru force-pushed the distconf/bootstrap-api branch from 9f0e266 to 478fbe8 Compare December 9, 2024 08:46

alexvru force-pushed the distconf/bootstrap-api branch from 478fbe8 to e0c3402 Compare December 11, 2024 09:22

alexvru force-pushed the distconf/bootstrap-api branch from e0c3402 to f29b764 Compare December 11, 2024 11:50

alexvru added the rebase-and-check Rebase PR with the current base branch and check label Dec 11, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 11, 2024

alexvru marked this pull request as ready for review December 12, 2024 04:32

alexvru requested a review from a team as a code owner December 12, 2024 04:32

alexvru marked this pull request as draft December 12, 2024 06:25

kruall previously approved these changes Dec 12, 2024

View reviewed changes

alexvru dismissed kruall’s stale review via d44111b December 12, 2024 06:55

alexvru force-pushed the distconf/bootstrap-api branch from f29b764 to d44111b Compare December 12, 2024 06:55

alexvru marked this pull request as ready for review December 12, 2024 12:23

alexvru requested a review from pnv1 December 12, 2024 13:29

kruall previously approved these changes Dec 12, 2024

View reviewed changes

Public API bootstrap command

bab9bf2

alexvru dismissed kruall’s stale review via bab9bf2 December 13, 2024 08:50

alexvru force-pushed the distconf/bootstrap-api branch from d44111b to bab9bf2 Compare December 13, 2024 08:50

pnv1 approved these changes Dec 13, 2024

View reviewed changes

alexvru enabled auto-merge (squash) December 13, 2024 09:03

alexvru merged commit ee3d7ef into ydb-platform:main Dec 13, 2024
10 checks passed

alexvru deleted the distconf/bootstrap-api branch December 13, 2024 10:41

Gazizonoki reviewed Dec 16, 2024

View reviewed changes

GrigoriyPA mentioned this pull request Dec 18, 2024

YQ-3975 RD fixed fault for parsing errors without filter #12707

Merged

niksaveliev mentioned this pull request Dec 25, 2024

Kafka connect distributed #12960

Merged

Public API bootstrap command #12308

Public API bootstrap command #12308

Uh oh!

Conversation

alexvru commented Dec 5, 2024

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pnv1 Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

alexvru Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

alexvru Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

pnv1 Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pnv1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

Gazizonoki Dec 16, 2024 •

edited

Loading