Skip to content

Conversation

@kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@kardymonds kardymonds requested a review from a team as a code owner December 5, 2024 07:29
@github-actions
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 07:32:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for b78e87c has started.
2024-12-05 07:32:28 UTC Artifacts will be uploaded here
2024-12-05 07:33:31 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 07:36:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1218549 has started.
2024-12-05 07:36:57 UTC Artifacts will be uploaded here
2024-12-05 07:39:51 UTC ya make is running...
🟡 2024-12-05 08:34:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30142 27286 0 4 2735 117

2024-12-05 08:37:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-05 08:48:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
697 (only retried tests) 589 0 1 0 107

2024-12-05 08:48:40 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-05 08:59:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
626 (only retried tests) 521 0 0 0 105

🟢 2024-12-05 09:00:08 UTC Build successful.
🟡 2024-12-05 09:00:30 UTC ydbd size 2.5 GiB changed* by +203.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fb73171 merge: 1218549 diff diff %
ydbd size 2 699 707 304 Bytes 2 699 915 744 Bytes +203.6 KiB +0.008%
ydbd stripped size 483 518 448 Bytes 483 578 800 Bytes +58.9 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 07:39:15 UTC Pre-commit check linux-x86_64-release-asan for 1218549 has started.
2024-12-05 07:39:26 UTC Artifacts will be uploaded here
2024-12-05 07:42:28 UTC ya make is running...
🟡 2024-12-05 08:49:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12972 12888 0 32 5 47

🟢 2024-12-05 08:50:54 UTC Build successful.
🟢 2024-12-05 08:51:23 UTC ydbd size 4.9 GiB changed* by +44.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d917bcb merge: 1218549 diff diff %
ydbd size 5 304 092 728 Bytes 5 304 137 984 Bytes +44.2 KiB +0.001%
ydbd stripped size 1 365 328 560 Bytes 1 365 333 808 Bytes +5.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

return hash;
}
bool operator==(const TTopicKey& other) const {
return Endpoint == other.Endpoint && Database == other.Database
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А connection_id в отдельном ревью в это место приедет?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Обсудили отдельно, не планировалось что сюда приедет connection_id. Или приедет с позже

@kardymonds kardymonds merged commit 800705f into ydb-platform:main Dec 9, 2024
10 checks passed
kardymonds added a commit to kardymonds/ydb that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants