Skip to content

Optimize CPU usage when read blob (#12153) #12221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2024
Merged

Optimize CPU usage when read blob (#12153) #12221

merged 4 commits into from
Dec 4, 2024

Conversation

nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Performance improvement

Additional information

...

@nshestakov nshestakov requested a review from a team as a code owner December 2, 2024 15:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

⚪ 2024-12-02 15:58:42 UTC Pre-commit check for 54504c7 has started.
⚪ 2024-12-02 16:01:40 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-12-02 16:11:10 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

⚪ 2024-12-02 15:59:30 UTC Pre-commit check for 54504c7 has started.
⚪ 2024-12-02 16:02:06 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-12-02 16:05:39 UTC Build failed. see the build logs.
🔴 2024-12-02 16:05:40 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

⚪ 2024-12-02 15:59:49 UTC Pre-commit check for 54504c7 has started.
⚪ 2024-12-02 16:02:29 UTC Build linux-x86_64-release-asan is running...
🔴 2024-12-02 16:06:43 UTC Build failed. see the build logs.
🔴 2024-12-02 16:06:45 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

⚪ 2024-12-02 16:25:14 UTC Pre-commit check for 0a8e59d has started.
⚪ 2024-12-02 16:27:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-12-02 16:50:14 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

⚪ 2024-12-02 16:25:19 UTC Pre-commit check for 0a8e59d has started.
⚪ 2024-12-02 16:27:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-02 17:06:58 UTC Build successful.
⚪ 2024-12-02 17:07:15 UTC Tests are running...
🔴 2024-12-02 18:32:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14670 13322 0 8 1300 40

🟢 2024-12-02 18:33:08 UTC ydbd size 8.3 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: d08116a merge: 0a8e59d diff diff %
ydbd size 8 868 191 352 Bytes 8 868 192 720 Bytes +1.3 KiB +0.000%
ydbd stripped size 484 082 536 Bytes 484 082 664 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

⚪ 2024-12-02 16:25:25 UTC Pre-commit check for 0a8e59d has started.
⚪ 2024-12-02 16:28:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-02 16:52:18 UTC Build successful.
⚪ 2024-12-02 16:52:39 UTC Tests are running...
🔴 2024-12-02 18:53:03 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10345 10245 0 18 37 45

🟢 2024-12-02 18:53:49 UTC ydbd size 5.6 GiB changed* by -25.9 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: d08116a merge: 0a8e59d diff diff %
ydbd size 5 998 656 224 Bytes 5 998 629 728 Bytes -25.9 KiB -0.000%
ydbd stripped size 1 503 260 704 Bytes 1 503 251 744 Bytes -8.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

⚪ 2024-12-03 13:14:52 UTC Pre-commit check for af31a5b has started.
⚪ 2024-12-03 13:17:47 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-12-03 13:22:53 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

⚪ 2024-12-03 13:15:16 UTC Pre-commit check for af31a5b has started.
⚪ 2024-12-03 13:18:04 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-12-03 13:31:34 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

⚪ 2024-12-03 13:15:42 UTC Pre-commit check for af31a5b has started.
⚪ 2024-12-03 13:18:18 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-12-03 13:31:14 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

⚪ 2024-12-03 13:35:27 UTC Pre-commit check for 359b91e has started.
⚪ 2024-12-03 13:38:03 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-12-03 13:44:14 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

⚪ 2024-12-03 13:35:33 UTC Pre-commit check for 359b91e has started.
⚪ 2024-12-03 13:38:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-03 14:16:14 UTC Build successful.
⚪ 2024-12-03 14:16:30 UTC Tests are running...
🔴 2024-12-03 15:42:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14672 13308 0 10 1313 41

🟢 2024-12-03 15:43:11 UTC ydbd size 8.3 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: d08116a merge: 359b91e diff diff %
ydbd size 8 868 191 352 Bytes 8 868 192 720 Bytes +1.3 KiB +0.000%
ydbd stripped size 484 082 536 Bytes 484 082 664 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

⚪ 2024-12-03 13:35:44 UTC Pre-commit check for 359b91e has started.
⚪ 2024-12-03 13:38:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-03 14:02:52 UTC Build successful.
⚪ 2024-12-03 14:03:15 UTC Tests are running...
🔴 2024-12-03 16:19:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10350 10245 0 29 34 42

🟢 2024-12-03 16:20:25 UTC ydbd size 5.6 GiB changed* by -25.9 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: d08116a merge: 359b91e diff diff %
ydbd size 5 998 656 224 Bytes 5 998 629 728 Bytes -25.9 KiB -0.000%
ydbd stripped size 1 503 260 704 Bytes 1 503 251 744 Bytes -8.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov merged commit d91df89 into ydb-platform:stable-24-3 Dec 4, 2024
8 of 12 checks passed
@nshestakov nshestakov deleted the 24-3-Codecs-optimization branch December 4, 2024 06:27
zinal pushed a commit to zinal/ydb that referenced this pull request Dec 14, 2024
@nshestakov @zinal
Optimize CPU usage when read blob (ydb-platform#12153) (ydb-platform#…
8d9694b 
…12221)
@naspirato naspirato mentioned this pull request Dec 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nshestakov @fomichev3000