Skip to content

Conversation

@vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Jan 22, 2024

Changelog entry

Added storage balancer releated metrics to sensors and Hive web ui

Changelog category

  • Improvement

Additional information

...

@github-actions
Copy link

github-actions bot commented Jan 22, 2024

2024-01-23 15:00:34 UTC Pre-commit check for cede032 has started.
2024-01-23 15:00:39 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-23 15:13:28 UTC Build failed. see the build logs.
2024-01-23 15:13:40 UTC Tests are running...
🔴 2024-01-23 16:48:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15891 15819 0 12 47 13

@github-actions
Copy link

github-actions bot commented Jan 22, 2024

2024-01-23 14:56:12 UTC Pre-commit check for cede032 has started.
2024-01-23 14:56:19 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-23 15:09:11 UTC Build failed. see the build logs.
2024-01-23 15:09:20 UTC Tests are running...
🔴 2024-01-23 16:31:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59995 50754 0 3 9228 10

ijon
ijon previously approved these changes Jan 22, 2024
Comment on lines +1328 to +1330
HIVE_CHANNEL_BALANCE_STRATEGY_HEAVIEST = 0;
HIVE_CHANNEL_BALANCE_STRATEGY_RANDOM = 1;
HIVE_CHANNEL_BALANCE_STRATEGY_WEIGHTED_RANDOM = 2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces compatibility issues with config versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but this is the PR that adds the ability to use this enum through web ui. The enum is not in any of stable releases, and I don't believe anyone has a yaml-config with it anywhere at this point.
(I changed it because it turns out C++ proto enum descriptors assume that enum values are consecutive and start with zero)

COUNTER_SUGGESTED_SCALE_UP = 10 [(CounterOpts) = {Name: "SuggestedScaleUp"}];
COUNTER_SUGGESTED_SCALE_DOWN = 11 [(CounterOpts) = {Name: "SuggestedScaleDown"}];
COUNTER_STORAGE_BALANCER_EXECUTED = 12 [(CounterOpts) = {Name: "StorageBalancerExecuted"}];
COUNTER_TABLETS_REASSIGNED = 13 [(CounterOpts) = {Name: "TabletsReassigned"}];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TabletsReassigned quite possibly will be confused with TabletsMoved.
May be there is a more accurate name for tablet-storage groups assignment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the word 'storage' to counter name.

@github-actions
Copy link

github-actions bot commented Jan 30, 2024

2024-01-30 16:01:34 UTC Pre-commit check for 99b326a has started.
2024-01-30 16:01:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 16:38:23 UTC Build successful.
2024-01-30 16:38:34 UTC Tests are running...
🔴 2024-01-30 18:17:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16033 15844 0 43 109 37

@github-actions
Copy link

github-actions bot commented Jan 30, 2024

2024-01-30 16:05:09 UTC Pre-commit check for 99b326a has started.
2024-01-30 16:05:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 16:42:05 UTC Build successful.
2024-01-30 16:42:15 UTC Tests are running...
🔴 2024-01-30 18:05:41 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60304 50936 0 31 9309 28

ijon
ijon previously approved these changes Jan 30, 2024
@github-actions
Copy link

github-actions bot commented Jan 30, 2024

2024-01-30 21:48:36 UTC Pre-commit check for cd2f6b3 has started.
2024-01-30 21:48:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 22:25:48 UTC Build successful.
2024-01-30 22:26:02 UTC Tests are running...
🟢 2024-01-30 23:48:39 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60313 51005 0 0 9264 44

@github-actions
Copy link

github-actions bot commented Jan 30, 2024

2024-01-30 21:48:56 UTC Pre-commit check for cd2f6b3 has started.
2024-01-30 21:48:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 22:23:44 UTC Build successful.
2024-01-30 22:23:59 UTC Tests are running...
🔴 2024-01-30 23:55:58 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16028 15889 0 18 72 49

@vporyadke vporyadke enabled auto-merge (squash) January 31, 2024 13:27
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants