Skip to content

refactoring the transaction processing cycle #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 26, 2024
Merged

refactoring the transaction processing cycle #1196

merged 8 commits into from
Jan 26, 2024

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Рефакторинг цикла обработки транзакций

alexnick88
alexnick88 reviewed Jan 23, 2024
View reviewed changes
ydb/core/persqueue/partition.cpp Outdated
@@ -854,7 +870,7 @@ void TPartition::Handle(TEvPersQueue::TEvProposeTransaction::TPtr& ev, const TAc
return;
}

if (ImmediateTxs.size() > MAX_TXS) {
if (UserActionAndTransactionEvents.size() > MAX_TXS) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а тут надо считать только транзакции же. У нас лимит на пропоузы, а не на все-все события.

Copy link
Collaborator Author

@Alek5andr-Kotov Alek5andr-Kotov Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавил счётчик
8d45220

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 15:15:40 UTC Pre-commit check for 6a05ae4 has started.
⚪ 2024-01-25 15:15:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-25 15:18:05 UTC Build successful.
⚪ 2024-01-25 15:18:15 UTC Tests are running...
🔴 2024-01-25 15:35:39 UTC Test run completed, no test results found for commit b31e7b8. Please check build logs.
⚫ 2024-01-25 15:35:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 15:27:53 UTC Pre-commit check for 6a05ae4 has started.
⚪ 2024-01-25 15:27:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-25 15:30:09 UTC Build successful.
⚪ 2024-01-25 15:30:22 UTC Tests are running...
🔴 2024-01-25 15:35:39 UTC Test run completed, no test results found for commit b31e7b8. Please check build logs.
⚫ 2024-01-25 15:35:42 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 15:40:01 UTC Pre-commit check for 5f79ef2 has started.
⚪ 2024-01-25 15:40:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-25 15:41:49 UTC Build successful.
⚪ 2024-01-25 15:41:59 UTC Tests are running...
🔴 2024-01-25 16:42:06 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60111 50826 0 4 9240 41

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

⚪ 2024-01-25 15:47:18 UTC Pre-commit check for 5f79ef2 has started.
⚪ 2024-01-25 15:47:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-25 15:49:16 UTC Build successful.
⚪ 2024-01-25 15:49:29 UTC Tests are running...
🔴 2024-01-25 17:21:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15950 15837 0 20 57 36

@Alek5andr-Kotov Alek5andr-Kotov merged commit b62d4c4 into ydb-platform:main Jan 26, 2024
This was referenced Jan 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alek5andr-Kotov @alexnick88