checkpointing vs abort: wait for completion before aborting #11896
Conversation
yumkam
changed the title
yumkam
changed the title
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ++*Metrics.StorageError; | ||
| } | ||
| if (checkpoint.GotAllAcknowledges()) { | ||
| if (checkpoint.GetStats().Aborted) { |
There was a problem hiding this comment.
А эта checkpoint структура постоянно пересоздается? Не нужно обнулить здесь Aborted?
There was a problem hiding this comment.
Вместе с чекпоинтом, не переиспользуется
yumkam
changed the title
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…form#11896) (cherry picked from commit ec75229)
2 participants
Changelog entry
...
Changelog category
Additional information
Otherwise checkpoint is removed from Pending and second checkpoint can be sent before previous completed in actors, leading to