Skip to content

YQL-17542 remove unused abstraction #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

YQL-17542 remove unused abstraction #1184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 11 additions & 26 deletions ydb/library/yql/providers/dq/task_runner/tasks_runner_local.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,13 @@ class TLocalTaskRunner: public ITaskRunner {

/*______________________________________________________________________________________________*/

class TAbstractFactory: public IProxyFactory {
class TLocalFactory: public IProxyFactory {
public:
TAbstractFactory(const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
TLocalFactory(const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
NKikimr::NMiniKQL::TComputationNodeFactory compFactory,
TTaskTransformFactory taskTransformFactory,
std::shared_ptr<NKikimr::NMiniKQL::TComputationPatternLRUCache> patternCache)
std::shared_ptr<NKikimr::NMiniKQL::TComputationPatternLRUCache> patternCache,
bool terminateOnError)
: DeterministicMode(!!GetEnv("YQL_DETERMINISTIC_MODE"))
, RandomProvider(
DeterministicMode
Expand All @@ -210,6 +211,7 @@ class TAbstractFactory: public IProxyFactory {
: CreateDefaultTimeProvider())
, FunctionRegistry(functionRegistry)
, TaskTransformFactory(std::move(taskTransformFactory))
, TerminateOnError(terminateOnError)
{
ExecutionContext.FuncRegistry = FunctionRegistry;
ExecutionContext.ComputationFactory = compFactory;
Expand All @@ -218,29 +220,6 @@ class TAbstractFactory: public IProxyFactory {
ExecutionContext.PatternCache = patternCache;
}

protected:
bool DeterministicMode;
TIntrusivePtr<IRandomProvider> RandomProvider;
TIntrusivePtr<ITimeProvider> TimeProvider;
const NKikimr::NMiniKQL::IFunctionRegistry* FunctionRegistry;
TTaskTransformFactory TaskTransformFactory;

NDq::TDqTaskRunnerContext ExecutionContext;
};

/*______________________________________________________________________________________________*/

class TLocalFactory: public TAbstractFactory {
public:
TLocalFactory(const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
NKikimr::NMiniKQL::TComputationNodeFactory compFactory,
TTaskTransformFactory taskTransformFactory,
std::shared_ptr<NKikimr::NMiniKQL::TComputationPatternLRUCache> patternCache,
bool terminateOnError)
: TAbstractFactory(functionRegistry, compFactory, taskTransformFactory, patternCache)
, TerminateOnError(terminateOnError)
{ }

ITaskRunner::TPtr GetOld(const TDqTaskSettings& task, const TString& traceId) override {
return new TLocalTaskRunner(task, Get(task, NDqProto::DQ_STATS_MODE_BASIC, traceId));
}
Expand Down Expand Up @@ -287,6 +266,12 @@ class TLocalFactory: public TAbstractFactory {
}

private:
bool DeterministicMode;
TIntrusivePtr<IRandomProvider> RandomProvider;
TIntrusivePtr<ITimeProvider> TimeProvider;
const NKikimr::NMiniKQL::IFunctionRegistry* FunctionRegistry;
TTaskTransformFactory TaskTransformFactory;
NDq::TDqTaskRunnerContext ExecutionContext;
const bool TerminateOnError;
};

Expand Down