Skip to content

Add GRPC thread CPU time metric #11772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add GRPC thread CPU time metric #11772

merged 1 commit into from
Nov 25, 2024

Conversation

@eivanov89
Copy link
Member

@eivanov89 eivanov89 commented Nov 20, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

⚪ 2024-11-20 07:47:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8da2b84 has started.
⚪ 2024-11-20 07:47:48 UTC Artifacts will be uploaded here
⚪ 2024-11-20 07:51:08 UTC ya make is running...
🔴 2024-11-20 07:55:30 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

⚪ 2024-11-20 07:48:23 UTC Pre-commit check linux-x86_64-release-asan for 8da2b84 has started.
⚪ 2024-11-20 07:48:35 UTC Artifacts will be uploaded here
⚪ 2024-11-20 07:52:00 UTC ya make is running...
🔴 2024-11-20 08:02:29 UTC Build failed, see the logs. Also see fail summary

@eivanov89 eivanov89 force-pushed the add-grpc-cpu-time branch 2 times, most recently from cbbcfce to e3446ce Compare November 20, 2024 12:12
@github-actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

⚪ 2024-11-20 12:14:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for bd9393b has started.
⚪ 2024-11-20 12:14:28 UTC Artifacts will be uploaded here
⚪ 2024-11-20 12:17:36 UTC ya make is running...
🔴 2024-11-20 12:21:28 UTC Build failed, see the logs. Also see fail summary

dcherednik
dcherednik previously approved these changes Nov 20, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

⚪ 2024-11-20 12:16:30 UTC Pre-commit check linux-x86_64-release-asan for bd9393b has started.
⚪ 2024-11-20 12:16:41 UTC Artifacts will be uploaded here
⚪ 2024-11-20 12:19:52 UTC ya make is running...
🔴 2024-11-20 12:23:37 UTC Build failed, see the logs. Also see fail summary

@eivanov89 eivanov89 requested a review from a team as a code owner November 21, 2024 07:57
@github-actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 08:01:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 41701aa has started.
⚪ 2024-11-21 08:01:31 UTC Artifacts will be uploaded here
⚪ 2024-11-21 08:04:41 UTC ya make is running...
🔴 2024-11-21 08:09:44 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 08:01:40 UTC Pre-commit check linux-x86_64-release-asan for 41701aa has started.
⚪ 2024-11-21 08:01:52 UTC Artifacts will be uploaded here
⚪ 2024-11-21 08:04:57 UTC ya make is running...
🔴 2024-11-21 08:11:47 UTC Build failed, see the logs. Also see fail summary

dcherednik
dcherednik previously approved these changes Nov 21, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 19:04:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for c29ebba has started.
⚪ 2024-11-21 19:04:47 UTC Artifacts will be uploaded here
⚪ 2024-11-21 19:07:51 UTC ya make is running...
🔴 2024-11-21 19:15:43 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

⚪ 2024-11-21 12:55:34 UTC Pre-commit check linux-x86_64-release-asan for c29ebba has started.
⚪ 2024-11-21 12:57:45 UTC Artifacts will be uploaded here
⚪ 2024-11-21 13:01:25 UTC ya make is running...
🔴 2024-11-21 13:17:50 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 11:15:28 UTC Pre-commit check linux-x86_64-release-asan for bf8a3c9 has started.
⚪ 2024-11-22 11:15:32 UTC Artifacts will be uploaded here
⚪ 2024-11-22 11:18:39 UTC ya make is running...
⚫ 2024-11-22 11:23:59 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 11:16:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for bf8a3c9 has started.
⚪ 2024-11-22 11:16:13 UTC Artifacts will be uploaded here
⚪ 2024-11-22 11:19:18 UTC ya make is running...
⚫ 2024-11-22 11:24:00 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 11:25:29 UTC Pre-commit check linux-x86_64-release-asan for 6440f7c has started.
⚪ 2024-11-22 11:25:44 UTC Artifacts will be uploaded here
⚪ 2024-11-22 11:28:47 UTC ya make is running...
🟡 2024-11-22 12:49:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10477 10404 0 15 6 52

🟢 2024-11-22 12:50:18 UTC Build successful.
🟢 2024-11-22 12:50:52 UTC ydbd size 4.9 GiB changed* by +64.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 36d42e5 merge: 6440f7c diff diff %
ydbd size 5 281 725 760 Bytes 5 281 792 232 Bytes +64.9 KiB +0.001%
ydbd stripped size 1 358 652 528 Bytes 1 358 662 256 Bytes +9.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 11:26:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6440f7c has started.
⚪ 2024-11-22 11:27:20 UTC Artifacts will be uploaded here
⚪ 2024-11-22 11:31:12 UTC ya make is running...
🟡 2024-11-22 12:48:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41872 36191 0 3 5559 119

⚪ 2024-11-22 12:52:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-22 13:04:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
120 (only retried tests) 9 0 1 1 109

⚪ 2024-11-22 13:04:12 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-22 13:16:06 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 2 0 1 0 106

🟢 2024-11-22 13:16:13 UTC Build successful.
🟢 2024-11-22 13:16:35 UTC ydbd size 2.5 GiB changed* by +31.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 36d42e5 merge: 6440f7c diff diff %
ydbd size 2 690 047 024 Bytes 2 690 079 376 Bytes +31.6 KiB +0.001%
ydbd stripped size 481 886 000 Bytes 481 890 608 Bytes +4.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@eivanov89 eivanov89 requested a review from dcherednik November 22, 2024 11:26
dcherednik
dcherednik previously approved these changes Nov 22, 2024
View reviewed changes
dcherednik
dcherednik previously approved these changes Nov 22, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 14:29:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 72ac898 has started.
⚪ 2024-11-22 14:29:58 UTC Artifacts will be uploaded here
⚪ 2024-11-22 14:33:02 UTC ya make is running...
🟡 2024-11-22 15:45:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41907 36195 0 2 5595 115

⚪ 2024-11-22 15:49:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-22 16:01:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 7 0 1 1 109

⚪ 2024-11-22 16:01:45 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-22 16:13:12 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
110 (only retried tests) 0 0 1 0 109

🟢 2024-11-22 16:13:20 UTC Build successful.
🟢 2024-11-22 16:13:42 UTC ydbd size 2.5 GiB changed* by +31.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fb228ee merge: 72ac898 diff diff %
ydbd size 2 691 738 904 Bytes 2 691 771 256 Bytes +31.6 KiB +0.001%
ydbd stripped size 482 182 960 Bytes 482 187 568 Bytes +4.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 14:29:50 UTC Pre-commit check linux-x86_64-release-asan for 72ac898 has started.
⚪ 2024-11-22 14:30:01 UTC Artifacts will be uploaded here
⚪ 2024-11-22 14:33:05 UTC ya make is running...
🟡 2024-11-22 15:54:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10477 10405 0 17 8 47

🟢 2024-11-22 15:55:28 UTC Build successful.
🟢 2024-11-22 15:55:55 UTC ydbd size 4.9 GiB changed* by +64.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fb228ee merge: 72ac898 diff diff %
ydbd size 5 285 187 664 Bytes 5 285 254 128 Bytes +64.9 KiB +0.001%
ydbd stripped size 1 359 579 888 Bytes 1 359 589 616 Bytes +9.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@eivanov89 eivanov89 enabled auto-merge (squash) November 22, 2024 16:09
@github-actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 09:48:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6510aff has started.
⚪ 2024-11-25 09:49:05 UTC Artifacts will be uploaded here
⚪ 2024-11-25 09:52:51 UTC ya make is running...
🟡 2024-11-25 11:09:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26242 23405 0 1 2719 117

⚪ 2024-11-25 11:11:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-25 11:23:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 8 0 0 0 108

🟢 2024-11-25 11:23:42 UTC Build successful.
🟢 2024-11-25 11:24:04 UTC ydbd size 2.5 GiB changed* by +31.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: afbc266 merge: 6510aff diff diff %
ydbd size 2 690 053 656 Bytes 2 690 085 992 Bytes +31.6 KiB +0.001%
ydbd stripped size 482 185 488 Bytes 482 190 096 Bytes +4.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 09:48:50 UTC Pre-commit check linux-x86_64-release-asan for 6510aff has started.
⚪ 2024-11-25 09:49:02 UTC Artifacts will be uploaded here
⚪ 2024-11-25 09:52:09 UTC ya make is running...
🟡 2024-11-25 11:14:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10483 10409 0 15 12 47

🟢 2024-11-25 11:15:09 UTC Build successful.
🟢 2024-11-25 11:15:40 UTC ydbd size 4.9 GiB changed* by +68.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: afbc266 merge: 6510aff diff diff %
ydbd size 5 284 319 504 Bytes 5 284 390 072 Bytes +68.9 KiB +0.001%
ydbd stripped size 1 359 968 560 Bytes 1 359 982 384 Bytes +13.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@eivanov89 eivanov89 requested review from dcherednik and removed request for a team November 25, 2024 14:29
@eivanov89 eivanov89 merged commit 1dd2b99 into ydb-platform:main Nov 25, 2024
10 checks passed
@eivanov89 eivanov89 deleted the add-grpc-cpu-time branch November 25, 2024 16:10
This was referenced Nov 27, 2024
Merged
Merged
@naspirato naspirato mentioned this pull request Nov 28, 2024
Open
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
eivanov89 added a commit to eivanov89/ydb that referenced this pull request Dec 9, 2024
@eivanov89
Add GRPC thread CPU time metric (ydb-platform#11772)
682bef8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcherednik dcherednik dcherednik approved these changes

@kruall kruall Awaiting requested review from kruall

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eivanov89 @dcherednik