Skip to content

Added enable_antlr4_parser feature flag #11764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Added enable_antlr4_parser feature flag #11764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/kqp/host/kqp_host.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,7 @@ class TKqpHost : public IKqpHost {
.SetQueryParameters(query.ParameterTypes)
.SetApplicationName(ApplicationName)
.SetIsEnablePgSyntax(SessionCtx->Config().FeatureFlags.GetEnablePgSyntax())
.SetIsEnableAntlr4Parser(SessionCtx->Config().EnableAntlr4Parser);
.SetIsEnableAntlr4Parser(SessionCtx->Config().FeatureFlags.GetEnableAntlr4Parser() || SessionCtx->Config().EnableAntlr4Parser);
NSQLTranslation::TTranslationSettings effectiveSettings;
auto astRes = ParseQuery(
query.Text,
Expand Down
1 change: 1 addition & 0 deletions ydb/core/kqp/provider/yql_kikimr_settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ TKikimrConfiguration::TKikimrConfiguration() {
REGISTER_SETTING(*this, _KqpSlowLogNoticeThresholdMs);
REGISTER_SETTING(*this, _KqpSlowLogTraceThresholdMs);
REGISTER_SETTING(*this, _KqpYqlSyntaxVersion);
REGISTER_SETTING(*this, _KqpYqlAntlr4Parser);
REGISTER_SETTING(*this, _KqpAllowUnsafeCommit);
REGISTER_SETTING(*this, _KqpMaxComputeActors);
REGISTER_SETTING(*this, _KqpEnableSpilling);
Expand Down
1 change: 1 addition & 0 deletions ydb/core/kqp/provider/yql_kikimr_settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ struct TKikimrSettings {
NCommon::TConfSetting<ui32, false> _KqpSlowLogNoticeThresholdMs;
NCommon::TConfSetting<ui32, false> _KqpSlowLogTraceThresholdMs;
NCommon::TConfSetting<ui32, false> _KqpYqlSyntaxVersion;
NCommon::TConfSetting<bool, false> _KqpYqlAntlr4Parser;
NCommon::TConfSetting<bool, false> _KqpAllowUnsafeCommit;
NCommon::TConfSetting<ui32, false> _KqpMaxComputeActors;
NCommon::TConfSetting<bool, false> _KqpEnableSpilling;
Expand Down
1 change: 1 addition & 0 deletions ydb/core/protos/feature_flags.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,5 @@ message TFeatureFlags {
optional bool EnableTopicAutopartitioningForReplication = 151 [default = false];
optional bool EnableDriveSerialsDiscovery = 152 [default = false];
optional bool EnableSeparateDiskSpaceQuotas = 153 [default = false];
optional bool EnableAntlr4Parser = 154 [default = false];
}
1 change: 1 addition & 0 deletions ydb/core/testlib/basics/feature_flags.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class TTestFeatureFlagsHolder {
FEATURE_FLAG_SETTER(EnableBackupService)
FEATURE_FLAG_SETTER(EnableGranularTimecast)
FEATURE_FLAG_SETTER(EnablePgSyntax)
FEATURE_FLAG_SETTER(EnableAntlr4Parser)
FEATURE_FLAG_SETTER(EnableTieringInColumnShard)
FEATURE_FLAG_SETTER(EnableMetadataObjectsOnServerless)
FEATURE_FLAG_SETTER(EnableOlapCompression)
Expand Down
Loading