Skip to content

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Nov 12, 2024

Changelog entry

Performing rw-transactions concurrently with schema operations can lead to disruption of persistent locks and loss of a schema snapshot used for serialization of CDC records.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL requested a review from snaury November 12, 2024 10:27
@CyberROFL CyberROFL self-assigned this Nov 12, 2024
@CyberROFL CyberROFL marked this pull request as ready for review November 12, 2024 10:27
@CyberROFL CyberROFL enabled auto-merge (squash) November 12, 2024 10:28
@CyberROFL CyberROFL changed the title break locks on scheme tx Break persistent locks on scheme tx Nov 12, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 12, 2024
@github-actions
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 10:29:45 UTC Pre-commit check linux-x86_64-release-asan for 8afc7ed has started.
2024-11-12 10:30:19 UTC Artifacts will be uploaded here
2024-11-12 10:33:49 UTC ya make is running...
🟡 2024-11-12 11:39:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8993 8905 0 32 7 49

🟢 2024-11-12 11:40:09 UTC Build successful.
🟡 2024-11-12 11:40:40 UTC ydbd size 5.7 GiB changed* by +103.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7be730f merge: 8afc7ed diff diff %
ydbd size 6 172 558 040 Bytes 6 172 664 464 Bytes +103.9 KiB +0.002%
ydbd stripped size 1 538 385 328 Bytes 1 538 456 048 Bytes +69.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 10:30:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8afc7ed has started.
2024-11-12 10:30:46 UTC Artifacts will be uploaded here
2024-11-12 10:33:56 UTC ya make is running...
🟡 2024-11-12 11:28:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15368 13837 0 11 1405 115

2024-11-12 11:29:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 11:41:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
121 (only retried tests) 11 0 0 1 109

🟢 2024-11-12 11:41:10 UTC Build successful.
🟢 2024-11-12 11:41:30 UTC ydbd size 2.8 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7be730f merge: 8afc7ed diff diff %
ydbd size 3 050 195 960 Bytes 3 050 203 200 Bytes +7.1 KiB +0.000%
ydbd stripped size 482 470 456 Bytes 482 471 224 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL linked an issue Nov 12, 2024 that may be closed by this pull request
@CyberROFL CyberROFL merged commit 91cc642 into ydb-platform:main Nov 12, 2024
13 checks passed
@CyberROFL CyberROFL deleted the break-locks-on-scheme-tx branch November 12, 2024 11:54
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Nov 12, 2024
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataShard: investigate uncommitted changes + alter with json cdc

2 participants