Skip to content

Conversation

@snaury
Copy link
Member

@snaury snaury commented Nov 12, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Several tables have been missing in precharge lists, which could cause multiple unnecessary restarts during datashard initialization. Fixes #11508.

@snaury snaury self-assigned this Nov 12, 2024
@github-actions
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 10:22:05 UTC Pre-commit check linux-x86_64-release-asan for 7531855 has started.
2024-11-12 10:22:16 UTC Artifacts will be uploaded here
2024-11-12 10:25:29 UTC ya make is running...
🟡 2024-11-12 12:01:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10289 10196 0 41 8 44

🟢 2024-11-12 12:02:04 UTC Build successful.
🟢 2024-11-12 12:02:38 UTC ydbd size 5.7 GiB changed* by +18.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7be730f merge: 7531855 diff diff %
ydbd size 6 172 558 040 Bytes 6 172 576 640 Bytes +18.2 KiB +0.000%
ydbd stripped size 1 538 385 328 Bytes 1 538 390 448 Bytes +5.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 10:25:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7531855 has started.
2024-11-12 10:25:23 UTC Artifacts will be uploaded here
2024-11-12 10:28:37 UTC ya make is running...
🟡 2024-11-12 11:48:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41636 35943 0 15 5563 115

2024-11-12 11:51:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 12:03:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 19 0 0 1 108

🟢 2024-11-12 12:03:29 UTC Build successful.
🟢 2024-11-12 12:03:49 UTC ydbd size 2.8 GiB changed* by +10.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7be730f merge: 7531855 diff diff %
ydbd size 3 050 195 960 Bytes 3 050 206 192 Bytes +10.0 KiB +0.000%
ydbd stripped size 482 470 456 Bytes 482 472 632 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review November 12, 2024 13:31
@snaury snaury requested a review from azevaykin November 12, 2024 13:31
@snaury snaury merged commit 8fb382c into ydb-platform:main Nov 12, 2024
11 checks passed
@snaury snaury deleted the bugfix-11508-missing-precharge branch November 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataShard: KIKIMR-22197: add precharge for missing tables in TTxInit

2 participants