Skip to content

Conversation

@azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Nov 11, 2024

Changelog entry

A datashard could catch VERIFY during restart with scheme transaction inflight

KIKIMR-22195

Changelog category

  • Bugfix

Additional information

VERIFY failed (2024-11-11T15:00:23.255997+0300):
  contrib/ydb/core/tx/datashard/datashard_pipeline.cpp:49
  Load(): requirement !SchemaTx failed
0. /-S/util/system/yassert.cpp:55: NPrivate::Panic(NPrivate::TStaticBuf const&, int, char const*, char const*, char const*, ...) @ 0x556B236FD67B
1. /-S/contrib/ydb/core/tx/datashard/datashard_pipeline.cpp:49: NKikimr::NDataShard::TPipeline::Load(NKikimr::NIceDb::TNiceDb&) @ 0x556B31C29326
2. /-S/contrib/ydb/core/tx/datashard/datashard__init.cpp:227: NKikimr::NDataShard::TDataShard::TTxInit::ReadEverything(NKikimr::NTabletFlatExecutor::TTransactionContext&) @ 0x556B31D80397
3. /-S/contrib/ydb/core/tx/datashard/datashard__init.cpp:43: NKikimr::NDataShard::TDataShard::TTxInit::Execute(NKikimr::NTabletFlatExecutor::TTransactionContext&, NActors::TActorContext const&) @ 0x556B31D7CDBC
4. /-S/contrib/ydb/core/tablet_flat/flat_executor.cpp:1717: NKikimr::NTabletFlatExecutor::TExecutor::ExecuteTransaction(TAutoPtr<NKikimr::NTabletFlatExecutor::TSeat, TDelete>, NActors::TActorContext const&) @ 0x556B276FF229
5. /-S/contrib/ydb/core/tablet_flat/flat_executor.cpp:2637: NKikimr::NTabletFlatExecutor::TExecutor::Handle(TAutoPtr<NActors::TEventHandle<NKikimr::NTabletFlatExecutor::TExecutor::TEvPrivate::TEvActivateExecution>, TDelete>&, NActors::TActorContext const&) @ 0x556B2770EBFF
6. /-S/contrib/ydb/core/tablet_flat/flat_executor.cpp:3951: NKikimr::NTabletFlatExecutor::TExecutor::StateWork(TAutoPtr<NActors::IEventHandle, TDelete>&) @ 0x556B276E7F1C
7. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:251: NActors::TGenericExecutorThread::TProcessingResult NActors::TGenericExecutorThread::Execute<NActors::TMailboxTable::TReadAsFilledMailbox>(NActors::TMailboxTable::TReadAsFilledMailbox*, unsigned int, bool) @ 0x556B23C8C036
8. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:440: NActors::TGenericExecutorThread::ProcessExecutorPool(NActors::IExecutorPool*)::$_0::operator()(unsigned int, bool) const @ 0x556B23C7EBDE
9. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:492: NActors::TGenericExecutorThread::ProcessExecutorPool(NActors::IExecutorPool*) @ 0x556B23C7E41F
10. /-S/contrib/ydb/library/actors/core/executor_thread.cpp:523: NActors::TExecutorThread::ThreadProc() @ 0x556B23C7F804
11. /-S/util/system/thread.cpp:244: (anonymous namespace)::TPosixThread::ThreadProxy(void*) @ 0x556B2370B859
12. ??:0: ?? @ 0x7FBBE7B20608
13. ??:0: ?? @ 0x7FBBE7A40352

...

@azevaykin azevaykin changed the title TPipeline::Reset() Reset pipeline in datashard init Nov 11, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 11, 2024
@github-actions
Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 15:09:49 UTC Pre-commit check linux-x86_64-release-asan for 14e5e2f has started.
2024-11-11 15:10:01 UTC Artifacts will be uploaded here
2024-11-11 15:13:02 UTC ya make is running...
🟡 2024-11-11 16:18:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8980 8890 0 34 13 43

🟢 2024-11-11 16:19:30 UTC Build successful.
🟢 2024-11-11 16:20:03 UTC ydbd size 5.7 GiB changed* by +37.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e31118f merge: 14e5e2f diff diff %
ydbd size 6 166 282 472 Bytes 6 166 320 920 Bytes +37.5 KiB +0.001%
ydbd stripped size 1 537 605 392 Bytes 1 537 611 792 Bytes +6.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 11, 2024

2024-11-11 15:09:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 14e5e2f has started.
2024-11-11 15:10:08 UTC Artifacts will be uploaded here
2024-11-11 15:13:14 UTC ya make is running...
🟡 2024-11-11 16:05:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15354 13830 0 10 1405 109

2024-11-11 16:07:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-11 16:19:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
114 (only retried tests) 11 0 0 0 103

🟢 2024-11-11 16:19:23 UTC Build successful.
🟢 2024-11-11 16:19:42 UTC ydbd size 2.8 GiB changed* by +29.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e31118f merge: 14e5e2f diff diff %
ydbd size 3 047 107 000 Bytes 3 047 137 296 Bytes +29.6 KiB +0.001%
ydbd stripped size 482 255 288 Bytes 482 258 296 Bytes +2.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Nov 11, 2024
@azevaykin azevaykin self-assigned this Nov 11, 2024
@azevaykin azevaykin merged commit 57ae3a3 into ydb-platform:main Nov 11, 2024
14 checks passed
@azevaykin azevaykin deleted the PipelineReset branch November 11, 2024 16:27
azevaykin added a commit to azevaykin/ydb that referenced this pull request Nov 11, 2024
azevaykin added a commit to azevaykin/ydb that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants