YQ-3824 Shared reading: fix is not distinct from with optional field
#11378
Conversation
|
⚪ |
|
⚪ |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if (predicate.Ref().ChildrenSize() != 2 ) { | ||
| return false; | ||
| } | ||
| auto expr1 = predicate.Ref().Child(0); |
There was a problem hiding this comment.
оберни сразу в TExprBase, у тебя выражения повторяются в этой функции
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| auto sqlIn = predicate.Cast<TCoSqlIn>(); | ||
| predicateTree.CanBePushed = SqlInCanBePushed(sqlIn, lambdaArg, lambdaBody, settings); | ||
| } else if (settings.IsEnabled(TSettings::EFeatureFlag::IsDistinctOperator) && | ||
| (predicate.Ref().IsCallable("IsNotDistinctFrom") || predicate.Ref().IsCallable("IsDistinctFrom"))) { |
There was a problem hiding this comment.
в IsCallable можно передать сразу несколько строк
IsCallable({"IsNotDistinctFrom"sv, "IsDistinctFrom"sv})
| auto predicate = coalesce.Predicate(); | ||
| if (auto compare = predicate.Maybe<TCoCompare>()) { | ||
| return SerializeCompare(compare.Cast(), proto, arg, err); | ||
| } else if (auto sqlIn = predicate.Maybe<TCoSqlIn>()) { |
There was a problem hiding this comment.
какая связь между in и coalesce ? странно видеть in внутри coalesce
| auto predicate = coalesce.Predicate(); | ||
| if (auto compare = predicate.Maybe<TCoCompare>()) { | ||
| return SerializeCompare(compare.Cast(), proto, arg, err); | ||
| } else if (auto sqlIn = predicate.Maybe<TCoSqlIn>()) { |
|
|
||
| bool SerializeIsNotDistinctFrom(const TExprBase& predicate, TPredicate* predicateProto, const TCoArgument& arg, TStringBuilder& err, bool invert) { | ||
| if (predicate.Ref().ChildrenSize() != 2 ) { | ||
| err << "unknown predicate, children size " << predicate.Ref().ChildrenSize(); |
There was a problem hiding this comment.
напиши, что ожидалось 2, а пришло столько-то
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
kardymonds
changed the title
kardymonds
changed the title
is not dinstinct from with optional field
dorooleg
changed the title
is not dinstinct from with optional field is not distinct from with optional field
…dintinct-with-opt-field
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| predicateTree.CanBePushed = SqlInCanBePushed(sqlIn, lambdaArg, lambdaBody, settings); | ||
| } else if (settings.IsEnabled(TSettings::EFeatureFlag::IsDistinctOperator) && | ||
| (predicate.Ref().IsCallable({"IsNotDistinctFrom", "IsDistinctFrom"}))) { | ||
| predicateTree.CanBePushed = IsDistinctCanBePushed(predicate, lambdaArg, lambdaBody, settings);; |
| || !CheckExpressionNodeForPushdown(expr2, lambdaArg, settings)) { | ||
| return false; | ||
| } | ||
| const TTypeAnnotationNode* inputType = lambdaBody.Ptr()->GetTypeAnn(); |
There was a problem hiding this comment.
Переменную можно перетащить внутрь if
| return SerializeExpression(compare.Left(), proto->mutable_left_value(), arg, err) && SerializeExpression(compare.Right(), proto->mutable_right_value(), arg, err); | ||
| } | ||
|
|
||
| bool SerializeSqlIn(const TCoSqlIn& sqlIn, TPredicate* proto, const TCoArgument& arg, TStringBuilder& err); |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
3 participants
Changelog entry
...
Changelog category
Additional information
...