Skip to content

Make MVCC always enabled and no longer optional KIKIMR-20802 #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 18, 2024

Changelog entry

MVCC is now always enabled and no longer optional.

Changelog category

  • New feature

Additional information

We expected MVCC to be enabled for some time now. Some older tests disabled mvcc to test legacy behavior, but those are increasingly difficult to maintain, and it's not a configuration we want to support. MVCC is now mandatory and cannot be disabled.

Copy link

github-actions bot commented Jan 18, 2024

2024-01-19 07:52:08 UTC Pre-commit check for 329eafc has started.
2024-01-19 07:52:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-19 07:53:36 UTC Build successful.
2024-01-19 07:53:49 UTC Tests are running...
🔴 2024-01-19 08:43:22 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59953 50716 0 1 9222 14

Copy link

github-actions bot commented Jan 18, 2024

2024-01-19 07:50:49 UTC Pre-commit check for 329eafc has started.
2024-01-19 07:50:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-19 07:52:11 UTC Build successful.
2024-01-19 07:52:28 UTC Tests are running...
🔴 2024-01-19 08:47:12 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15893 15803 0 24 43 23

@snaury snaury force-pushed the KIKIMR-20802-remove-disable-mvcc branch from f8aeb24 to 28ea936 Compare January 18, 2024 12:49
@snaury snaury requested review from spuchin and azevaykin January 18, 2024 14:03
@snaury snaury marked this pull request as ready for review January 18, 2024 14:04
azevaykin
azevaykin previously approved these changes Jan 18, 2024
spuchin
spuchin previously approved these changes Jan 18, 2024
@snaury snaury marked this pull request as draft January 18, 2024 18:52
@snaury snaury dismissed stale reviews from spuchin and azevaykin via 45cba70 January 19, 2024 07:47
@snaury snaury marked this pull request as ready for review January 19, 2024 07:57
@snaury snaury requested a review from azevaykin January 19, 2024 07:57
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants