Skip to content

YQ-3809 Shared reading: fix logging #11175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2024
Merged

YQ-3809 Shared reading: fix logging #11175

merged 4 commits into from
Nov 6, 2024

Conversation

@kardymonds
Copy link
Collaborator

@kardymonds kardymonds commented Nov 1, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@kardymonds kardymonds requested a review from a team as a code owner November 1, 2024 06:03
@github-actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

⚪ 2024-11-01 06:10:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9460c14 has started.
⚪ 2024-11-01 06:11:10 UTC Artifacts will be uploaded here
⚪ 2024-11-01 06:14:08 UTC ya make is running...
🟡 2024-11-01 07:09:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39917 34233 0 5 5575 104

⚪ 2024-11-01 07:13:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-01 07:24:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
133 (only retried tests) 42 0 0 0 91

🟢 2024-11-01 07:24:40 UTC Build successful.
🟢 2024-11-01 07:25:01 UTC ydbd size 2.8 GiB changed* by -456 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 846a92b merge: 9460c14 diff diff %
ydbd size 3 039 579 960 Bytes 3 039 579 504 Bytes -456 Bytes -0.000%
ydbd stripped size 481 372 088 Bytes 481 371 640 Bytes -448 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

⚪ 2024-11-01 06:11:11 UTC Pre-commit check linux-x86_64-release-asan for 9460c14 has started.
⚪ 2024-11-01 06:11:21 UTC Artifacts will be uploaded here
⚪ 2024-11-01 06:14:21 UTC ya make is running...
🟡 2024-11-01 07:22:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9089 9004 0 32 19 34

🟢 2024-11-01 07:23:27 UTC Build successful.
🟢 2024-11-01 07:23:59 UTC ydbd size 5.7 GiB changed* by -3.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 846a92b merge: 9460c14 diff diff %
ydbd size 6 150 464 320 Bytes 6 150 460 560 Bytes -3.7 KiB -0.000%
ydbd stripped size 1 534 580 400 Bytes 1 534 579 824 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

⚪ 2024-11-01 07:31:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 84faee4 has started.
⚪ 2024-11-01 07:31:57 UTC Artifacts will be uploaded here
⚪ 2024-11-01 07:34:57 UTC ya make is running...
🟡 2024-11-01 08:27:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39915 34272 0 2 5548 93

⚪ 2024-11-01 08:30:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-01 08:42:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 4 0 0 1 90

🟢 2024-11-01 08:42:12 UTC Build successful.
🟢 2024-11-01 08:42:30 UTC ydbd size 2.8 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 846a92b merge: 84faee4 diff diff %
ydbd size 3 039 579 960 Bytes 3 039 582 344 Bytes +2.3 KiB +0.000%
ydbd stripped size 481 372 088 Bytes 481 372 024 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

⚪ 2024-11-01 07:31:46 UTC Pre-commit check linux-x86_64-release-asan for 84faee4 has started.
⚪ 2024-11-01 07:31:58 UTC Artifacts will be uploaded here
⚪ 2024-11-01 07:34:57 UTC ya make is running...
🟡 2024-11-01 08:44:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9091 8992 0 42 25 32

🟢 2024-11-01 08:45:21 UTC Build successful.
🟢 2024-11-01 08:45:56 UTC ydbd size 5.7 GiB changed* by +1000 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 846a92b merge: 84faee4 diff diff %
ydbd size 6 150 464 320 Bytes 6 150 465 320 Bytes +1000 Bytes +0.000%
ydbd stripped size 1 534 580 400 Bytes 1 534 581 200 Bytes +800 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kardymonds kardymonds enabled auto-merge (squash) November 1, 2024 10:10
uzhastik
uzhastik reviewed Nov 1, 2024
View reviewed changes
ydb/core/fq/libs/row_dispatcher/row_dispatcher.cpp

void TRowDispatcher::Handle(NFq::TEvPrivate::TEvPrintStateToLog::TPtr&) {
Schedule(TDuration::Seconds(PrintStateToLogPeriodSec), new NFq::TEvPrivate::TEvPrintStateToLog());
PrintInternalState();
Copy link
Collaborator

@uzhastik uzhastik Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай строчки местами поменяем, чтобы сами себя не заспамили, если функция медленная

Copy link
Collaborator Author

@kardymonds kardymonds Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переставил

@github-actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

⚪ 2024-11-02 11:50:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for ac855d8 has started.
⚪ 2024-11-02 11:50:31 UTC Artifacts will be uploaded here
⚪ 2024-11-02 11:53:46 UTC ya make is running...
🟡 2024-11-02 12:47:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39928 34271 0 4 5557 96

⚪ 2024-11-02 12:52:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-02 13:04:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 5 0 0 0 94

🟢 2024-11-02 13:04:18 UTC Build successful.
🟢 2024-11-02 13:04:39 UTC ydbd size 2.8 GiB changed* by +26.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 05a2731 merge: ac855d8 diff diff %
ydbd size 3 038 333 472 Bytes 3 038 360 880 Bytes +26.8 KiB +0.001%
ydbd stripped size 481 449 464 Bytes 481 460 088 Bytes +10.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

⚪ 2024-11-02 11:52:11 UTC Pre-commit check linux-x86_64-release-asan for ac855d8 has started.
⚪ 2024-11-02 11:52:30 UTC Artifacts will be uploaded here
⚪ 2024-11-02 11:55:37 UTC ya make is running...
🟡 2024-11-02 13:01:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9092 9016 0 29 14 33

🟢 2024-11-02 13:02:53 UTC Build successful.
🟢 2024-11-02 13:03:26 UTC ydbd size 5.7 GiB changed* by +1016 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8950220 merge: ac855d8 diff diff %
ydbd size 6 147 902 144 Bytes 6 147 903 160 Bytes +1016 Bytes +0.000%
ydbd stripped size 1 534 604 240 Bytes 1 534 605 040 Bytes +800 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kardymonds kardymonds merged commit 2d120ed into ydb-platform:main Nov 6, 2024
10 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 6, 2024
Merged
kardymonds added a commit to kardymonds/ydb that referenced this pull request Nov 6, 2024
@kardymonds
YQ-3809 Shared reading: fix logging (ydb-platform#11175)
11f26e8
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
This was referenced Nov 10, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik left review comments

@dorooleg dorooleg dorooleg approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kardymonds @dorooleg @uzhastik