Skip to content

[24-3] Fix double PassAway call in Healthcheck actor #11104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

UgnineSirdis
Copy link
Collaborator

(cherry picked from commit dd3e736)

Changelog entry

Fix double PassAway call in Healthcheck actor

Changelog category

  • Bugfix

Additional information

...

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner October 30, 2024 10:58
@UgnineSirdis UgnineSirdis changed the title Fix double PassAway call in Healthcheck actor [24-3] Fix double PassAway call in Healthcheck actor Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

2024-10-30 11:01:50 UTC Pre-commit check for 927d2ad has started.
2024-10-30 11:04:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-30 11:44:09 UTC Build successful.
2024-10-30 11:44:27 UTC Tests are running...
🔴 2024-10-30 13:05:41 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14240 12883 0 14 1301 42

🟢 2024-10-30 13:06:28 UTC ydbd size 8.2 GiB changed* by -80 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: e936c2b merge: 927d2ad diff diff %
ydbd size 8 856 729 152 Bytes 8 856 729 072 Bytes -80 Bytes -0.000%
ydbd stripped size 483 621 448 Bytes 483 621 448 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 30, 2024

2024-10-30 11:01:52 UTC Pre-commit check for 927d2ad has started.
2024-10-30 11:04:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-30 11:27:39 UTC Build successful.
2024-10-30 11:27:55 UTC Tests are running...
🔴 2024-10-30 13:33:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10096 10006 0 21 26 43

🟢 2024-10-30 13:34:27 UTC ydbd size 5.6 GiB changed* by -208 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: e936c2b merge: 927d2ad diff diff %
ydbd size 5 990 325 888 Bytes 5 990 325 680 Bytes -208 Bytes -0.000%
ydbd stripped size 1 501 452 288 Bytes 1 501 452 160 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 30, 2024

2024-10-30 11:02:51 UTC Pre-commit check for 927d2ad has started.
2024-10-30 11:05:23 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-30 11:12:07 UTC Build successful.

@mvgorbunov mvgorbunov merged commit b2ea93c into ydb-platform:stable-24-3 Oct 31, 2024
8 of 12 checks passed
@UgnineSirdis UgnineSirdis deleted the fix-healthcheck-crash-24-3 branch October 31, 2024 09:44
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants