Skip to content

add result checking function in arrow_ut.cpp #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2024
Merged

add result checking function in arrow_ut.cpp #1109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f22bb11
add result checking function in arrow_ut.cpp
Jan 17, 2024
0f4b136
Fix stylistic mistakes
Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 29 additions & 32 deletions ydb/library/yql/parser/pg_wrapper/ut/arrow_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,28 @@ extern "C" {
#include "utils/fmgrprotos.h"
}

namespace {

void checkResult(const char ** expected, std::shared_ptr<arrow::ArrayData> data) {

NYql::NUdf::TStringBlockReader<arrow::BinaryType, true> reader;
for (int i = 0; i < data->length; i++) {
auto item = reader.GetItem(*data, i);
if (!item) {
UNIT_ASSERT(expected[i] == nullptr);
} else {
const char* addr = item.AsStringRef().Data() + sizeof(void*);
UNIT_ASSERT(expected[i] != nullptr);
UNIT_ASSERT_VALUES_EQUAL(
TString(DatumGetCString(DirectFunctionCall1(numeric_out, (Datum)addr))),
expected[i]
);
}
}
}

} // namespace {

namespace NYql {

Y_UNIT_TEST_SUITE(TArrowUtilsTests) {
Expand Down Expand Up @@ -49,25 +71,14 @@ Y_UNIT_TEST(PgConvertNumericDouble) {

auto result = PgConvertNumeric<double>(array);
const auto& data = result->data();



const char* expected[] = {
"1.1", "31.37", nullptr, "-1.337", "0"
};

NUdf::TStringBlockReader<arrow::BinaryType, true> reader;
for (int i = 0; i < 5; i++) {
auto item = reader.GetItem(*data, i);
if (!item) {
UNIT_ASSERT(expected[i] == nullptr);
} else {
const char* addr = item.AsStringRef().Data() + sizeof(void*);
UNIT_ASSERT(expected[i] != nullptr);
UNIT_ASSERT_VALUES_EQUAL(
TString(DatumGetCString(DirectFunctionCall1(numeric_out, (Datum)addr))),
expected[i]
);
}
}

checkResult(expected, data);
}

Y_UNIT_TEST(PgConvertNumericInt) {
Expand All @@ -89,21 +100,8 @@ Y_UNIT_TEST(PgConvertNumericInt) {
const char* expected[] = {
"11", "3137", nullptr, "-1337", "0"
};

NUdf::TStringBlockReader<arrow::BinaryType, true> reader;
for (int i = 0; i < 5; i++) {
auto item = reader.GetItem(*data, i);
if (!item) {
UNIT_ASSERT(expected[i] == nullptr);
} else {
const char* addr = item.AsStringRef().Data() + sizeof(void*);
UNIT_ASSERT(expected[i] != nullptr);
UNIT_ASSERT_VALUES_EQUAL(
TString(DatumGetCString(DirectFunctionCall1(numeric_out, (Datum)addr))),
expected[i]
);
}
}

checkResult(expected, data);
}

Y_UNIT_TEST(PgConvertDate32Date) {
Expand Down Expand Up @@ -150,5 +148,4 @@ Y_UNIT_TEST(PgConvertDate32Date) {

} // Y_UNIT_TEST_SUITE(TArrowUtilsTests)

} // namespace NYql

} // namespace NYql