Skip to content

introduce snapshot_ro isolation level #11085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2024
Merged

introduce snapshot_ro isolation level #11085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdfc771
introduce snapshot_ro isolation level
ssmike Oct 30, 2024
0b5e6d1
set nodeid consistently
ssmike Oct 30, 2024
ae54cbf
fix snapshot logic
ssmike Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ydb/core/kqp/common/kqp_tx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ bool NeedSnapshot(const TKqpTransactionContext& txCtx, const NYql::TKikimrConfig
{
Y_UNUSED(config);

if (*txCtx.EffectiveIsolationLevel != NKikimrKqp::ISOLATION_LEVEL_SERIALIZABLE)
if (*txCtx.EffectiveIsolationLevel != NKikimrKqp::ISOLATION_LEVEL_SERIALIZABLE &&
*txCtx.EffectiveIsolationLevel != NKikimrKqp::ISOLATION_LEVEL_SNAPSHOT_RO)
return false;

if (txCtx.GetSnapshot().IsValid())
Expand Down
3 changes: 1 addition & 2 deletions ydb/core/kqp/common/kqp_tx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,7 @@ class TKqpTransactionContext : public NYql::TKikimrTransactionContextBase {
break;

case Ydb::Table::TransactionSettings::kSnapshotReadOnly:
// TODO: (KIKIMR-3374) Use separate isolation mode to avoid optimistic locks.
EffectiveIsolationLevel = NKikimrKqp::ISOLATION_LEVEL_SERIALIZABLE;
EffectiveIsolationLevel = NKikimrKqp::ISOLATION_LEVEL_SNAPSHOT_RO;
Readonly = true;
break;

Expand Down
2 changes: 1 addition & 1 deletion ydb/core/kqp/executer_actor/kqp_planner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ std::unique_ptr<TEvKqpNode::TEvStartKqpTasksRequest> TKqpPlanner::SerializeReque
request.SetTxId(TxId);
if (LockTxId) {
request.SetLockTxId(*LockTxId);
request.SetLockNodeId(LockNodeId);
}
request.SetLockNodeId(LockNodeId);
ActorIdToProto(ExecuterId, request.MutableExecuterActorId());

if (Deadline) {
Expand Down
1 change: 1 addition & 0 deletions ydb/core/protos/kqp.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ enum EIsolationLevel {
ISOLATION_LEVEL_READ_COMMITTED = 2;
ISOLATION_LEVEL_READ_UNCOMMITTED = 3;
ISOLATION_LEVEL_READ_STALE = 4;
ISOLATION_LEVEL_SNAPSHOT_RO = 5;
};

message TTopicOperationsRequest {
Expand Down
Loading