Remove yatest_common from ydb #10964

maximyurchuk · 2024-10-27T17:35:23Z

Changelog entry

remove yatest_common usage (not needed anymore)
fix some harness usage of yatest_common (catching vanilla yatest exceptions)

Also see comments in PR

Changelog category

Not for changelog (changelog entry is not required)

Additional information

See https://st.yandex-team.ru/KIKIMR-16114

github-actions · 2024-10-27T17:39:22Z

⚪ 2024-10-27 17:39:21 UTC Pre-commit check linux-x86_64-release-asan for b907814 has started.
⚪ 2024-10-27 17:39:32 UTC Artifacts will be uploaded here
⚪ 2024-10-27 17:42:17 UTC ya make is running...
🔴 2024-10-27 17:48:03 UTC Too many tests failed, NOT going to retry
🟡 2024-10-27 17:48:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
998	349	0	617	0	32

🟢 2024-10-27 17:48:37 UTC Build successful.
🟢 2024-10-27 17:48:52 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `b907814`	diff	diff %
ydbd size	6 138 292 144 Bytes	6 138 292 048 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 531 755 696 Bytes	1 531 755 632 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T17:42:01Z

⚪ 2024-10-27 17:42:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for b907814 has started.
⚪ 2024-10-27 17:42:13 UTC Artifacts will be uploaded here
⚪ 2024-10-27 17:44:48 UTC ya make is running...
🔴 2024-10-27 17:48:55 UTC Too many tests failed, NOT going to retry
🔴 2024-10-27 17:49:24 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1291	367	0	841	0	83

🟢 2024-10-27 17:49:40 UTC Build successful.
🟢 2024-10-27 17:49:55 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `b907814`	diff	diff %
ydbd size	3 033 086 168 Bytes	3 033 086 168 Bytes	0 Bytes	0.000%
ydbd stripped size	480 539 160 Bytes	480 539 160 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T18:01:00Z

⚪ 2024-10-27 18:01:00 UTC Pre-commit check linux-x86_64-release-asan for 0dbb41a has started.
⚪ 2024-10-27 18:01:12 UTC Artifacts will be uploaded here
⚪ 2024-10-27 18:03:47 UTC ya make is running...
🔴 2024-10-27 18:13:25 UTC Too many tests failed, NOT going to retry
🟡 2024-10-27 18:14:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2218	362	0	1742	4	110

🟢 2024-10-27 18:15:09 UTC Build successful.
🟢 2024-10-27 18:15:28 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `0dbb41a`	diff	diff %
ydbd size	6 138 292 144 Bytes	6 138 292 048 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 531 755 696 Bytes	1 531 755 632 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T18:01:16Z

⚪ 2024-10-27 18:01:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0dbb41a has started.
⚪ 2024-10-27 18:01:27 UTC Artifacts will be uploaded here
⚪ 2024-10-27 18:04:06 UTC ya make is running...
🔴 2024-10-27 18:11:13 UTC Too many tests failed, NOT going to retry
🔴 2024-10-27 18:12:47 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2597	425	0	2006	4	162

🟢 2024-10-27 18:13:07 UTC Build successful.
🟢 2024-10-27 18:13:22 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `0dbb41a`	diff	diff %
ydbd size	3 033 086 168 Bytes	3 033 086 168 Bytes	0 Bytes	0.000%
ydbd stripped size	480 539 160 Bytes	480 539 160 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T18:50:37Z

⚪ 2024-10-27 18:50:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7ae8b2e has started.
⚪ 2024-10-27 18:50:43 UTC Artifacts will be uploaded here
⚪ 2024-10-27 18:53:18 UTC ya make is running...
🟡 2024-10-27 19:11:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2597	2339	0	92	19	147

⚪ 2024-10-27 19:12:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-27 19:15:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
95 (only retried tests)	1	0	21	0	73

⚪ 2024-10-27 19:15:36 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-27 19:18:51 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
94 (only retried tests)	0	0	21	0	73

🟢 2024-10-27 19:18:57 UTC Build successful.
🟢 2024-10-27 19:19:09 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `7ae8b2e`	diff	diff %
ydbd size	3 033 086 168 Bytes	3 033 086 168 Bytes	0 Bytes	0.000%
ydbd stripped size	480 539 160 Bytes	480 539 160 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T18:51:06Z

⚪ 2024-10-27 18:51:05 UTC Pre-commit check linux-x86_64-release-asan for 7ae8b2e has started.
⚪ 2024-10-27 18:51:16 UTC Artifacts will be uploaded here
⚪ 2024-10-27 18:53:58 UTC ya make is running...
🟡 2024-10-27 19:23:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2221	2041	0	63	24	93

🟢 2024-10-27 19:23:42 UTC Build successful.
🟢 2024-10-27 19:23:58 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `7ae8b2e`	diff	diff %
ydbd size	6 138 292 144 Bytes	6 138 292 048 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 531 755 696 Bytes	1 531 755 632 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T19:55:19Z

⚪ 2024-10-27 19:55:19 UTC Pre-commit check linux-x86_64-release-asan for ed75546 has started.
⚪ 2024-10-27 19:55:30 UTC Artifacts will be uploaded here
⚪ 2024-10-27 19:58:11 UTC ya make is running...
🟡 2024-10-27 20:33:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2669	2533	0	22	39	75

🟢 2024-10-27 20:33:26 UTC Build successful.
🟢 2024-10-27 20:33:43 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `ed75546`	diff	diff %
ydbd size	6 138 292 144 Bytes	6 138 292 048 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 531 755 696 Bytes	1 531 755 632 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T19:55:30Z

⚪ 2024-10-27 19:55:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for ed75546 has started.
⚪ 2024-10-27 19:55:40 UTC Artifacts will be uploaded here
⚪ 2024-10-27 19:58:19 UTC ya make is running...
🟡 2024-10-27 20:25:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3912	3796	0	1	36	79

⚪ 2024-10-27 20:25:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-27 20:29:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
79 (only retried tests)	2	0	1	0	76

⚪ 2024-10-27 20:29:18 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-27 20:32:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
77 (only retried tests)	1	0	1	0	75

🟢 2024-10-27 20:32:52 UTC Build successful.
🟢 2024-10-27 20:33:05 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `ed75546`	diff	diff %
ydbd size	3 033 086 168 Bytes	3 033 086 168 Bytes	0 Bytes	0.000%
ydbd stripped size	480 539 160 Bytes	480 539 160 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T20:38:40Z

⚪ 2024-10-27 20:38:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for d81399b has started.
⚪ 2024-10-27 20:38:50 UTC Artifacts will be uploaded here
⚪ 2024-10-27 20:41:33 UTC ya make is running...
🟡 2024-10-27 21:08:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
3912	3788	0	12	36	76

⚪ 2024-10-27 21:08:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-27 21:12:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
87 (only retried tests)	13	0	0	0	74

🟢 2024-10-27 21:12:43 UTC Build successful.
🟢 2024-10-27 21:12:54 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `d81399b`	diff	diff %
ydbd size	3 033 086 168 Bytes	3 033 086 168 Bytes	0 Bytes	0.000%
ydbd stripped size	480 539 160 Bytes	480 539 160 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-27T20:38:49Z

⚪ 2024-10-27 20:38:48 UTC Pre-commit check linux-x86_64-release-asan for d81399b has started.
⚪ 2024-10-27 20:38:59 UTC Artifacts will be uploaded here
⚪ 2024-10-27 20:41:34 UTC ya make is running...
🟡 2024-10-27 21:12:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
2667	2537	0	19	35	76

🟢 2024-10-27 21:13:10 UTC Build successful.
🟢 2024-10-27 21:13:27 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `67d74e2`	merge: `d81399b`	diff	diff %
ydbd size	6 138 292 144 Bytes	6 138 292 048 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 531 755 696 Bytes	1 531 755 632 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

maximyurchuk · 2024-10-27T20:39:42Z

ydb/tests/library/common/helpers.py

        return [item]
+
+
+def plain_or_under_sanitizer(plain, sanitized):


Притащил копию сюда
Не удалил прошлую, потому что совместимость с Аркадией
По имени файла вроде подходящее место

maximyurchuk · 2024-10-27T20:40:12Z

ydb/tests/library/common/yatest_common.py

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# TODO (2024): remove this file, it is not needed. See KIKIMR-16114 for details


Это нужно было чтобы в cmake тесты запускать, насколько я понял

Короче кажется нафиг это не нужно

maximyurchuk · 2024-10-27T20:40:40Z

ydb/tests/library/harness/daemon.py

        super(SeveralDaemonErrors, self).__init__("\n".join(str(x) for x in exceptions))


+def _work_path(name):


Тут и ниже внезапно в каких то кейсах запускается и вне тестов (в рецепте навпример)

Remove yatest_common from ydb

931acd4

github-actions bot added the new-feature label Oct 27, 2024

maximyurchuk added 2 commits October 27, 2024 17:53

fix

6d2d770

fix

ab23198

fix

2c4d55e

fixes

9bca600

github-actions bot added not-for-changelog and removed new-feature labels Oct 27, 2024

fix

25c33ba

github-actions bot added not-for-changelog and removed not-for-changelog labels Oct 27, 2024

maximyurchuk commented Oct 27, 2024

View reviewed changes

gridnevvvit approved these changes Oct 27, 2024

View reviewed changes

maximyurchuk merged commit e0f8bdc into ydb-platform:main Oct 27, 2024
12 checks passed

maximyurchuk mentioned this pull request Oct 28, 2024

Fast fix in harness after prev commit #10968

Merged

GrigoriyPA mentioned this pull request Oct 28, 2024

YQ RD fixed use after free #10978

Merged

maximyurchuk mentioned this pull request Oct 29, 2024

Fix typo in tools/lib/cmds #11038

Merged

shnikd mentioned this pull request Nov 7, 2024

Support QueryMeta and diagnostics #11371

Merged

niksaveliev mentioned this pull request Nov 8, 2024

Fix read session correct close ut #11407

Merged

GrigoriyPA mentioned this pull request Nov 13, 2024

YQ WM fixed race with actor context #11576

Merged

niksaveliev mentioned this pull request Nov 14, 2024

Commit for autopartitioned topics #11629

Merged

		return [item]


		def plain_or_under_sanitizer(plain, sanitized):

		@@ -1,4 +1,5 @@
		# -- coding: utf-8 --
		# TODO (2024): remove this file, it is not needed. See KIKIMR-16114 for details

		super(SeveralDaemonErrors, self).__init__("\n".join(str(x) for x in exceptions))


		def _work_path(name):

Remove yatest_common from ydb #10964

Remove yatest_common from ydb #10964

Uh oh!

Conversation

maximyurchuk commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maximyurchuk Oct 27, 2024

Choose a reason for hiding this comment

Uh oh!

maximyurchuk Oct 27, 2024

Choose a reason for hiding this comment

Uh oh!

maximyurchuk Oct 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maximyurchuk commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading

github-actions bot commented Oct 27, 2024 •

edited

Loading