Skip to content

Conversation

@snaury
Copy link
Member

@snaury snaury commented Oct 25, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Various improvements around outgoing readsets:

  • Avoid re-reading very small readsets from disk by keeping them in-memory
  • Don't re-read large readsets from disk twice after a restart
  • Remove readsets from resend sets as soon as acks are received
  • Avoid potential quadratic complexity when resending readsets to rapidly restarting tablets

Fixes #10772.

@github-actions
Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 13:58:21 UTC Pre-commit check linux-x86_64-release-asan for d2e3836 has started.
2024-10-25 13:58:31 UTC Artifacts will be uploaded here
2024-10-25 14:01:32 UTC ya make is running...
🟡 2024-10-25 15:12:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10142 9943 0 63 37 99

🟢 2024-10-25 15:13:33 UTC Build successful.
🟢 2024-10-25 15:14:05 UTC ydbd size 5.7 GiB changed* by +51.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d93b735 merge: d2e3836 diff diff %
ydbd size 6 137 482 032 Bytes 6 137 534 320 Bytes +51.1 KiB +0.001%
ydbd stripped size 1 531 563 440 Bytes 1 531 569 328 Bytes +5.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 13:58:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for d2e3836 has started.
2024-10-25 13:58:32 UTC Artifacts will be uploaded here
2024-10-25 14:01:41 UTC ya make is running...
🟡 2024-10-25 14:51:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15275 13776 0 4 1396 99

2024-10-25 14:52:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-25 15:04:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 9 0 0 0 95

🟢 2024-10-25 15:04:20 UTC Build successful.
🟢 2024-10-25 15:04:41 UTC ydbd size 2.8 GiB changed* by +8.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d93b735 merge: d2e3836 diff diff %
ydbd size 3 032 827 456 Bytes 3 032 836 576 Bytes +8.9 KiB +0.000%
ydbd stripped size 480 532 888 Bytes 480 534 104 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury self-assigned this Oct 25, 2024
@snaury snaury requested a review from azevaykin October 25, 2024 14:24
@snaury snaury marked this pull request as ready for review October 25, 2024 14:24
@snaury snaury merged commit bb2d8c4 into ydb-platform:main Oct 28, 2024
11 checks passed
@snaury snaury deleted the bugfix-10772-out-readsets branch October 28, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataShard: keep small outgoing readsets in memory and fix some small issues

2 participants